Bargraph code is not working??

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
RishikeshJha
Forum Newbie
Posts: 11
Joined: Tue Mar 31, 2009 1:54 am

Bargraph code is not working??

Post by RishikeshJha »

pickle | Please use [ code=php ], [ code=text ], etc tags where appropriate when posting code. Your post has been edited to reflect how we'd like it posted. Please read: :arrow: Posting Code in the Forums to learn how to do it too.


Hi,

i want to create dynamic bar graph. i am using the following code. it is woriking fine bt when i implement this in ajax page it show gargabe values.

Code: Select all

 
include("../../includes/configure.php");
for($j=0; $j< 12; $j++)
    {
 
        $today = mktime(0,0,0,date("m")- $j, date("d"),date("y"));
        $da=date("M",$today).' '.date("y",$today);
        $currentmonth=$da=date("m",$today);
        $sql="SELECT sum(`totalamount`) FROM `hj_employers_payment` where employers_id='1' and substring(substring_index(payment_date,'-',2),6)='$currentmonth' group by employers_id";
        //echo $sql;
        $query=mysql_query($sql);
        if(mysql_num_rows($query))
        {
            $result=mysql_fetch_array($query);
            $amt=$result[0];
        }
        else
        {
            $amt=0;
        }
        $arraymonth[$da].=$amt;
    }
//print_r($values);
$values=$arraymonth;
 
 
    $img_width=600;
    $img_height=300; 
    $margins=25;
 
 
    # ---- Find the size of graph by substracting the size of borders
    $graph_width=$img_width - $margins * 2;
    $graph_height=$img_height - $margins * 2; 
    $img=imagecreate($img_width,$img_height);
 
 
    $bar_width=30; // for bard with change here
    $total_bars=count($values);
    
    $gap= ($graph_width- $total_bars * $bar_width ) / ($total_bars +1);
 
 
    # -------  Define Colors ----------------
    $bar_color=imagecolorallocate($img,0,64,128);
    $background_color=imagecolorallocate($img,240,240,255);
    $border_color=imagecolorallocate($img,200,200,200);
    $line_color=imagecolorallocate($img,220,220,220);
 
    # ------ Create the border around the graph ------
 
    imagefilledrectangle($img,0,0,$img_width-2,$img_height-2,$border_color);
    imagefilledrectangle($img,$margins,$margins,$img_width-1-$margins,$img_height-1-$margins,$background_color);
 
  
    # ------- Max value is required to adjust the scale -------
    $max_value=max($values);
    $ratio= $graph_height/$max_value;
 
 
    # -------- Create scale and draw horizontal lines  --------
    $horizontal_lines=20;
    $horizontal_gap=$graph_height/$horizontal_lines;
 
    for($i=1;$i<=$horizontal_lines;$i++){
        $y=$img_height - $margins - $horizontal_gap * $i ;
        
        imageline($img,$margins,$y,$img_width-$margins,$y,$line_color);
        $v=intval($horizontal_gap * $i /$ratio);
        imagestring($img,0,5,$y-5,$v,$bar_color);
    }
 
 
    # ----------- Draw the bars here ------
    for($i=0;$i< $total_bars; $i++){ 
    
        # ------ Extract key and value pair from the current pointer position
        list($key,$value)=each($values); 
        
        $x1= $margins + $gap + $i * ($gap+$bar_width) ;
        $x2= $x1 + $bar_width; 
        $y1=$margins +$graph_height- intval($value * $ratio) ;
        $y2=$img_height-$margins;
        imagestring($img,0,$x1+3,$y1-10,$value,$bar_color);imagestring($img,0,$x1+3,$img_height-15,$key,$bar_color);        
        imagefilledrectangle($img,$x1,$y1,$x2,$y2,$bar_color);
        
    }
    header("Content-type:image/png");
    imagepng($img);
    
?>
 
can anyone help me...

thanks in advance...


pickle | Please use [ code=php ], [ code=text ], etc tags where appropriate when posting code. Your post has been edited to reflect how we'd like it posted. Please read: :arrow: Posting Code in the Forums to learn how to do it too.
User avatar
McInfo
DevNet Resident
Posts: 1532
Joined: Wed Apr 01, 2009 1:31 pm

Re: Bargraph code is not working??

Post by McInfo »

Line 21 uses concatenation to assign a value to an array element that does not yet exist (unless it was created in configure.php). This generates a "Notice: Undefined index" error.

Code: Select all

$arraymonth[$da].=$amt;
Replace line 21 with

Code: Select all

$arraymonth[$da]=$amt;
Line 35 is where your main problem appears to be coming from.

Code: Select all

$img=imagecreate($img_width,$img_height);
Replace line 35 with

Code: Select all

$img=imagecreatetruecolor($img_width,$img_height);
This is optional because PHP does garbage collection: After line 89

Code: Select all

imagepng($img);
add

Code: Select all

imagedestroy($img);
Edit: This post was recovered from search engine cache.
Post Reply