Page 1 of 1

upload ugliness

Posted: Wed Oct 07, 2009 7:00 pm
by rottenstock
First and foremost, im new to these forums. So hello!

Secondly, Im new to developing upload pages for php.

Thirdly. I like turtles. :-d

Anyways, i built a page using the following code. The page works perfectly, but the code, is well, ugly. I know abuot white loops and foreach and all that stuff, but im not sure how to actually implement it into the uploading ability.

If anyone has any advice or somewhere they can point me i'd appricaite it. Like everything else in live, nothing is perfect.

Code: Select all

 
<?php
header("Refresh: 15; URL=/logout.php");
session_start();
 
$path1= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][0];
$path2= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][1];
$path3= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][2];
$path4= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][3];
$path5= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][4];
$path6= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][5];
$path7= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][6];
$path8= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][7];
$path9= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][8];
$path10= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][9];
$path11= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][10];
$path12= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][11];
$path13= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][12];
$path14= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][13];
$path15= $_SESSION['foldername'] . '/' . $HTTP_POST_FILES['ufile']['name'][14];
 
if ($HTTP_POST_FILES['ufile']['tmp_name'][0]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][0], $path1);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][1]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][1], $path2);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][2]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][2], $path3);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][3]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][3], $path4);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][4]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][4], $path5);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][5]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][5], $path6);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][6]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][6], $path7);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][7]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][7], $path8);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][8]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][8], $path9);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][9]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][9], $path10);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][10]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][10], $path11);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][11]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][11], $path12);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][12]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][12], $path13);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][13]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][13], $path14);
}
if ($HTTP_POST_FILES['ufile']['tmp_name'][14]) {
copy($HTTP_POST_FILES['ufile']['tmp_name'][14], $path15);
}
 
$filesize1=$HTTP_POST_FILES['ufile']['size'][0];
$filesize2=$HTTP_POST_FILES['ufile']['size'][1];
$filesize3=$HTTP_POST_FILES['ufile']['size'][2];
$filesize4=$HTTP_POST_FILES['ufile']['size'][3];
$filesize5=$HTTP_POST_FILES['ufile']['size'][4];
$filesize6=$HTTP_POST_FILES['ufile']['size'][5];
$filesize7=$HTTP_POST_FILES['ufile']['size'][6];
$filesize8=$HTTP_POST_FILES['ufile']['size'][7];
$filesize9=$HTTP_POST_FILES['ufile']['size'][8];
$filesize10=$HTTP_POST_FILES['ufile']['size'][9];
$filesize11=$HTTP_POST_FILES['ufile']['size'][10];
$filesize12=$HTTP_POST_FILES['ufile']['size'][11];
$filesize13=$HTTP_POST_FILES['ufile']['size'][12];
$filesize14=$HTTP_POST_FILES['ufile']['size'][13];
$filesize15=$HTTP_POST_FILES['ufile']['size'][14];
echo '<html xmlns="http://www.w3.org/1999/xhtml">';
echo '<body>';
echo '<table border="1">';
if ($filesize1 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path1\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][0].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][0].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][0].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize2 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path2\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][1].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][1].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][1].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize3 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path3\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][2].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][2].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][2].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize4 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path4\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][3].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][3].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][3].'<br/>';
echo '</td>';
echo '</tr>';
}
 
if ($filesize5 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path5\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][4].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][4].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][4].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize6 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path6\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][5].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][5].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][5].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize7 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path7\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][6].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][6].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][6].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize8 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path8\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][7].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][7].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][7].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize9 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path9\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][8].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][8].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][8].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize10 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path10\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][9].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][9].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][9].'<br/>';
echo '</td>';
echo '</tr>';
}
 
if ($filesize11 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path11\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][10].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][10].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][10].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize12 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path12\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][11].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][11].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][11].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize13 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path13\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][12].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][12].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][12].'<br/>';
echo '</td>';
echo '</tr>';
}
 
if ($filesize14 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path14\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][13].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][13].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][13].'<br/>';
echo '</td>';
echo '</tr>';
}
if ($filesize15 > 0) {
echo '<tr>';
echo '<td rowspan="4">';
echo "<img src=\"$path15\" width=\"150\" height=\"150\">";
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Name : '.$HTTP_POST_FILES["ufile"]["name"][14].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Size : '.$HTTP_POST_FILES["ufile"]["size"][14].'<br/>';
echo '</td>';
echo '</tr>';
echo '<tr>';
echo '<td>';
echo 'File Type : '.$HTTP_POST_FILES["ufile"]["type"][14].'<br/>';
echo '</td>';
echo '</tr>';
}
 
echo '</table>';
echo '</body>';
echo '</html>';
 
///////////////////////////////////////////////////////
 
// Use this code to display the error or success.
 
 
 
if($filesize1 || $filesize2 || $filesize3 || $filesize4 || $filesize5 ||
    $filesize6 || $filesize7 || $filesize8 || $filesize9 ||
    $filesize10 || $filesize11 || $filesize12 || $filesize13 ||
    $filesize14 || $filesize15 > 0)
{
echo "<br/>";
echo "We have recieved your files";
echo "<br/>";
echo "<a href='logout.php'>Log Out</a>";
}
 
else {
echo "ERROR.....";
}
?>
 

Re: upload ugliness

Posted: Thu Oct 08, 2009 7:06 am
by jackpf
Well, with a for loop:

Code: Select all

for($i = 0; $i < count($_FILES['yourfilename']['name']); $i++)
{
//you can now refer to each file as  $_FILES['yourfilename']['name'][$i]
//or
//$_FILES['yourfilename']['type'][$i]
//or whatever you want
}

Re: upload ugliness

Posted: Thu Oct 08, 2009 12:56 pm
by rottenstock
yeah, i forgot to post here, i figured it all out.

I just made a while loop for the setup and it seems to be working nicely.