Whats wrong here?

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
GK
Forum Commoner
Posts: 51
Joined: Sat Jun 07, 2003 2:58 pm
Contact:

Whats wrong here?

Post by GK »

What is wrong? i tryed a lot but i keep getting a java error
Regel: 172
Teken: 189
Fout: Tekenreeksconstante is niet afgesloten (caractersign not closed)
Code: 0


<td bgcolor=\"#99CCFF\"><font face=verdana size=2><a href=\"#\" onClick=\"MyWindow=window.open('edit.php?sid=$rows[sid]&a=edit','editwindow',toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,resizable=no,width=800,height=600')\; return false\;\">Edit</a> | <a href=\"#\" onClick=\"MyWindow=window.open('edit.php?sid=$rows[sid]&a=delete','deletewindow',toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,resizable=no,width=800,height=600')\; return false\;\">Delete</a></font></td>



-----------
All code
-----------


<?
include "../config.inc";
include "../connect.php";
?>
<html>
<head></head>
<body>
<div align="center">
<table align=center border=2 cellpadding=1 cellspacing=0 width="740" bordercolor="#000000">
<tr bgcolor="#333333">
<td align=center>
<div align="left"><B><font face="verdana" size="2" color="white">Sid:</font></B></div>
</td>
<td align=center>
<div align="left"><B><font face="verdana" size="2" color="white">Scan url:</font></B></div>
</td>
<td align=center>
<div align="left"><B><font face="verdana" size="2" color="white">Domein:</font></B></div>
</td>
<td align=center>
<div align="left"><B><font face="verdana" size="2" color="white">Opties:</font></B></div>
</td>
</tr>

<?
$query = mysql_query ("select sid, file, domein from checker",$db) or die("Sites Database SELECT Error");
while ($rows = mysql_fetch_array($query)) {
echo "<tr>

<td bgcolor=\"#99CCFF\"><font face=verdana size=2>$rows[sid]</font></td>

<td bgcolor=\"#99CCFF\"><font face=verdana size=2>$rows[file]</font></td>

<td bgcolor=\"#99CCFF\"><font face=verdana size=2>$rows[domein]</font></td>

<td bgcolor=\"#99CCFF\"><font face=verdana size=2><a href=\"#\" onClick=\"MyWindow=window.open('edit.php?sid=$rows[sid]&a=edit','editwindow',toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,resizable=no,width=800,height=600')\; return false\;\">Edit</a> | <a href=\"#\" onClick=\"MyWindow=window.open('edit.php?sid=$rows[sid]&a=delete','deletewindow',toolbar=no,location=no,directories=no,status=no,menubar=no,scrollbars=no,resizable=no,width=800,height=600')\; return false\;\">Delete</a></font></td>


</tr>";

}

?>
</table>
<?

if ($sid AND $a) {

if ($a == "edit") {

$query = mysql_db_query ($dbname,"select file, sid, domein from checker where sid=$sid",$db) or die (mysql_error());

$rows = mysql_fetch_array($query);

?>
</div>
<Table Align="center" Border="1" Width="400" CellPadding="3" CellSpacing="0" bordercolor="#000000">
<tr>



<td bgcolor="#FFFFFF">
<form action="edit.php" method="post">
<p>Sid:<BR>
-<BR>
Scan url:<BR>
<input type="text" name="file" size="90%" value="<? echo $rows[file]?>">
<BR>
Domein:<br>
<input type="text" name="domein" size="90%" value="<? echo $rows[domein]?>">
<br>
<BR></font>
<BR>
</p>

<center>

<BR>



<input type="submit" name="submit" value="Submit deze info">

<input type=hidden name=sid value="<? echo $rows[sid]?>">

<input type=hidden name=a value="update">

</center>

</form>

</td>

</tr>

</Table>


<?

}

if ($a == "update") {

$query = mysql_db_query ($dbname,"Update checker set domein='$domein',file='$file' Where sid=$sid",$db) or die(mysql_error());

echo "Update klaar!.<BR>";

}

if ($a == "delete") {

mysql_db_query ($dbname,"delete from checker where sid=$sid",$db) or die (mysql_error());

echo "Gedelete!.<BR>";

}

}


?>
<div align="center">

<br>
</div>
</body>
</html>
qartis
Forum Contributor
Posts: 271
Joined: Sat Dec 14, 2002 4:43 pm
Location: BC, Canada
Contact:

Post by qartis »

A) Very bad title

B) We only need ~30 lines of code around the error, unless we ask for more

C) You can't echo "$row[bar]", because it doesn't know where $row begins and ends; surround them all with { }

Example:

echo "<tr>

<td>{$row['price']}</td>

<td>{$row['quantity']}</td>

</tr>";
pootergeist
Forum Contributor
Posts: 273
Joined: Thu Feb 27, 2003 7:22 am
Location: UK

Post by pootergeist »

and window parameters within a window.open call should be encased in quotes (you are missing one at the start on every call)

window.open('edit.php?sid=$rows[sid]&a=edit','editwindow',here add ' toolbar=no,location
GK
Forum Commoner
Posts: 51
Joined: Sat Jun 07, 2003 2:58 pm
Contact:

still the same

Post by GK »

still same java error


<td bgcolor=\"#99CCFF\"><font face=verdana size=2><a href=\"#\" onClick=\"MyWindow=window.open('edit.php?sid=$rows[sid]&a=edit','editwindow','toolbar=no','location=no','directories=no','status=no','menubar=no','scrollbars=no','resizable=no','width=800','height=600')\; return false\;\">Edit</a> | <a href=\"#\" onClick=\"MyWindow=window.open('edit.php?sid=$rows[sid]&a=delete','deletewindow','toolbar=no','location=no','directories=no','status=no','menubar=no','scrollbars=no','resizable=no','width=800','height=600')\; return false\;\">Delete</a></font></td>
qartis
Forum Contributor
Posts: 271
Joined: Sat Dec 14, 2002 4:43 pm
Location: BC, Canada
Contact:

Post by qartis »

Don't put \ before the ; at the end of those javascript calls:

<td bgcolor=\"#99CCFF\"><font face=verdana size=2><a href=\"#\" onClick=\"MyWindow=window.open('edit.php?sid=$rows[sid]&a=edit','editwindow','toolbar=no','location=no','directories=no','status=no','menubar=no','scrollbars=no','resizable=no','width=800','height=600'); return false;\">Edit</a> | <a href=\"#\" onClick=\"MyWindow=window.open('edit.php?sid=$rows[sid]&a=delete','deletewindow','toolbar=no','location=no','directories=no','status=no','menubar=no','scrollbars=no','resizable=no','width=800','height=600'); return false;\">Delete</a></font></td>
GK
Forum Commoner
Posts: 51
Joined: Sat Jun 07, 2003 2:58 pm
Contact:

Post by GK »

thanks
GK
Forum Commoner
Posts: 51
Joined: Sat Jun 07, 2003 2:58 pm
Contact:

Post by GK »

qartis it opens up the entire page a new window
not only the edit section
Post Reply