List Box will not pick up values from a valid recordset

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
User avatar
steedvlx
Forum Contributor
Posts: 122
Joined: Wed Jun 11, 2003 10:54 pm
Location: Osaka, Japan

List Box will not pick up values from a valid recordset

Post by steedvlx »

I apologize in advance for posting all 545 lines of code for the following page, but I need another few sets of eyes.

The problem is that I have a drop list that picks up option and values from a recordset called rs_make. The same code works in several other pages of my site (see http://www.kokusaibuhin.com/e_index.php) as an example. The select on the right (browse) is the same code.

However in this one page, something has caused the code to break. I cannot for the life of me figure what else on this page could cause this list box not to work in this page.

The exact link to this page is http://www.kokusaibuhin.com/us_english/e_register.php. The list box is toward the bottom of the page in a field labeled 'member_make'

The form itself will not add anything to the database yet because I haven't finished the INSERT code. however all the necessary db links are available.

Code: Select all

<?php
<?php require_once('../Connections/kb_conn.php'); ?>
<?php include "../includes/common_db.php";?>
<?php
mysql_select_db($database_kb_conn, $kb_conn);
$query_rs_make = "SELECT * FROM make_tbl ORDER BY make_name ASC";
$rs_make = mysql_query($query_rs_make, $kb_conn) or die(mysql_error());
$row_rs_make = mysql_fetch_assoc($rs_make);
$totalRows_rs_make = mysql_num_rows($rs_make);
?>
<?php
function in_use($userid) {
   global $user_tablename;
   $query = "SELECT userid FROM $user_tablename WHERE userid = '$userid'";
   $result = mysql_query($query);
   if(!mysql_num_rows($result)) return 0;
   else return 1;
}

function register_form() {
  global $userid, $username, $usercountry, $useremail, $userprofile, $country_array;
  global $PHP_SELF;
?>
<title>Registration Page</title>
<body bgcolor="#FFFFFF">
<CENTER>
  <H3><span id="Layer1" style="position:absolute; width:200px; height:115px; z-index:-1; left: 0; top: 3;"><img src="../images/Banner_with_flag_English.gif" width="800" height="175"></span></H3>
</CENTER>
<span id="Layer2" style="position:absolute; width:799px; height:882px; z-index:0; left: 0px; top: 156px;"> 
<FORM ACTION="<?php echo $PHP_SELF ?>" METHOD="POST" name="form1" id="form1">
  <DIV ALIGN="CENTER">
    <CENTER>
      <TABLE WIDTH="790" BORDER="0" align="center" cellpadding="0" cellspacing="0">
        <TR bgcolor="#A40404">
          <TH height="35" colspan="6" NOWRAP><font color="#FFFFFF" size="4" face="Arial, Helvetica, sans-serif">Create
              Your Very Own (Yippee!!!) KokusaiBuhin Member Account!</font></TH>
        </TR>
        <tr bordercolor="#FFCC00">
          <td height="27" colspan="6" bgcolor="#FFCC00"><font color="#000000" size="3" face="Arial, Helvetica, sans-serif"><strong>&nbsp;&nbsp;<font size="4">&nbsp;&nbsp;Information
                  About You:</font></strong></font></td>
        </tr>
        <tr bordercolor="#FFCC00">
          <td width="8%" align="center" valign="middle" bgcolor="#CCCCCC"><center>
              <font size="2" face="Arial, Helvetica, sans-serif"><strong>Name</strong></font><strong> </strong>
            </center>
          </td>
          <td width="6%" align="right" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">Kanji
              :</font></td>
          <td colspan="2" align="left" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Last:</strong>
                <input name="member_last_name_kanji" type="text" id="member_last_name_kanji2" size="15" maxlength="15">
                <strong> First</strong>:<strong>
                <input name="member_first_name_kanji" type="text" id="member_first_name_kanji2" size="15" maxlength="15">
              </strong></font></td>
          <td align="center" valign="middle" bgcolor="#FFCC00">&nbsp;</td>
          <td align="center" valign="middle" bgcolor="#000000">
            <div align="center"><font size="2" face="Arial, Helvetica, sans-serif"><strong><font color="#00FFFF">Why
                    enter your name three different ways?</font><font color="#000000"><br>
                          </font> </strong></font></div>
          </td>
        </tr>
        <tr bordercolor="#FFCC00">
          <td height="29" colspan="2" align="center" valign="middle" bgcolor="#DDDDDD">
            <div align="right"><font size="2" face="Arial, Helvetica, sans-serif">Furigana
                :</font></div>
          </td>
          <td colspan="2" align="left" valign="middle" bgcolor="#DDDDDD"><font size="2" face="Arial, Helvetica, sans-serif"> <strong>Last:
                  <input name="member_last_name_furi" type="text" id="member_last_name_furi2" size="15" maxlength="15">
      First:
      <input name="member_first_name_furi" type="text" id="member_first_name_furi2" size="15" maxlength="15">
          </strong><strong> </strong></font></td>
          <td rowspan="5" align="center" valign="middle" bgcolor="#FFCC00">&nbsp;</td>
          <td rowspan="5" align="center" valign="middle" bgcolor="#C5C5C5"><font size="2" face="Arial, Helvetica, sans-serif">KokusaiBuhin
              is an International Agent. And, we assist you in acquiring the
              BEST accessories "from Around the World". <br>
      Due to the international nature of our services, it is necessary to provide
      this information in varying forms to different people who may not have
      the ability to operate with non-Western script.</font></td>
        </tr>
        <tr bordercolor="#FFCC00">
          <td height="26" colspan="2" align="right" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif"><font color="#FF0000" size="3"><strong>*</strong></font>Romaji
              :</font></td>
          <td colspan="2" align="left" valign="middle" bgcolor="#CCCCCC"><strong><font size="2" face="Arial, Helvetica, sans-serif">Last:
                  <input name="member_last_name" type="text" id="member_last_name2" size="15" maxlength="15">
      First:
      <input name="member_first_name" type="text" id="member_first_name2" size="15" maxlength="15">
          </font> </strong> </td>
        </tr>
        <tr bordercolor="#FFCC00">
          <td height="32" colspan="2" align="left" valign="middle" bgcolor="#DDDDDD"><div align="right"><font size="4" face="Arial, Helvetica, sans-serif"><strong><font size="3" face="Arial, Helvetica, sans-serif"><font color="#FF0000">*</font></font><font size="2">E-mail
                    Address:</font> </strong></font></div>
          </td>
          <td colspan="2" align="left" valign="middle" bgcolor="#DDDDDD"><font size="4" face="Arial, Helvetica, sans-serif"><strong>
            <input name="useremail" type="text" id="useremail3" size="50" maxlength="50">
          </strong></font> </td>
        </tr>
        <tr bordercolor="#FFCC00">
          <td height="29" colspan="2" align="left" valign="middle" bgcolor="#CCCCCC"><div align="right"><font size="4" face="Arial, Helvetica, sans-serif"><strong><font size="3" face="Arial, Helvetica, sans-serif"><font color="#FF0000">*</font></font><font size="2">Verify
                    E-mail address:</font> </strong></font></div>
          </td>
          <td colspan="2" align="left" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif"><strong>
            <input name="useremail2" type="text" id="useremail22" size="50" maxlength="50">
          </strong></font></td>
        </tr>
        <tr bordercolor="#FFCC00">
          <td colspan="2" align="left" valign="middle" bgcolor="#CCCCCC"><div align="right"><font size="3" face="Arial, Helvetica, sans-serif"><font color="#FF0000" size="5"><strong><font size="3">*</font></strong></font><strong>Country:</strong></font></div>
          </td>
          <td colspan="2" align="left" valign="middle" bgcolor="#CCCCCC"><font size="3" face="Arial, Helvetica, sans-serif">
            <select name="usercountry" size="1">
              <option value="Japan">Japan</option>
              <option value="Singapore">Singapore</option>
              <option value="Hong Kong">Hong Kong</option>
              <option value="Malaysia">Malaysia</option>
              <option value="Australia">Australia</option>
              <option value="US Outer Territories">US Outer Territories</option>
              <option value="Other">Other</option>
            </select>
          </font></td>
        </tr>
        <tr bordercolor="#FFCC00" bgcolor="#FFFFFF">
          <td height="31" colspan="6"><div align="center"><font size="1"><font face="Arial, Helvetica, sans-serif"><strong>All
                    members will periodically receive the "KB News" E-Bulletin
                    which will contain information on additional features and
                    developments at KokusaiBuhin Dot Com as well as developments
                    in motorcycle customizing from around the world.</strong></font></font></div>
          </td>
        </tr>
        <TR>
          <TH height="25" colspan="6" NOWRAP bgcolor="#FFCC33"><div align="left"><font color="#000000" size="3" face="Arial, Helvetica, sans-serif"><strong>&nbsp;&nbsp;&nbsp;<font size="4">&nbsp;Password-Protect
                    Your Information: Choose or change your login information</font></strong></font></div>
          </TH>
        </TR>
        <TR>
          <td height="24" colspan="2" align="right" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD">
            <div align="right"><font size="2" face="Arial, Helvetica, sans-serif"><strong><font color="#FF0000">*</font>Unique
                  User ID:</strong></font></div>
          </td>
          <td colspan="2" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="userid" type="text" id="userid2" size="15" maxlength="10">
      (10 characters maximum)</font> </td>
          <td width="0%" align="center" valign="middle" bordercolor="#FFCC00" bgcolor="#FFCC00">&nbsp;</td>
          <td width="32%" align="center" valign="middle" bordercolor="#FFCC00" bgcolor="#000000">
            <div align="center"><font size="2" face="Arial, Helvetica, sans-serif"><strong><font color="#FFCC00"> <font color="#00FFFF">Choosing
                      a User Name and Password</font></font><font color="#00FFFF"><br>
                          </font> </strong></font></div>
          </td>
        </TR>
        <TR>
          <td height="26" colspan="2" align="center" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC">
            <div align="right"><font size="2" face="Arial, Helvetica, sans-serif"><font color="#FF0000">*</font>Enter
                Password:</font></div>
          </td>
          <td colspan="2" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="erpassword" type="password" id="erpassword3" size="15" maxlength="10">
      (10 characters maximum)<strong> </strong></font></td>
          <td width="0%" rowspan="5" align="center" valign="middle" bordercolor="#FFCC00" bgcolor="#FFCC00">&nbsp;</td>
          <td width="32%" rowspan="5" align="center" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC">
            <div align="justify">
              <p align="center"><font size="2" face="Arial, Helvetica, sans-serif">Choose
                  a unique username and password that is easy to remember but
                  will be difficult or impossible for other people to guess. <br>
                            <br>
          Challenge Phrase and Challenge Response will soon be used for automated
          email password recovery.</font></p>
            </div>
          </td>
        </TR>
        <TR>
          <td height="25" colspan="2" align="right" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD"><font size="2" face="Arial, Helvetica, sans-serif"><font color="#FF0000">*</font>Re-enter
              Password: </font></td>
          <td colspan="2" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="erpassword2" type="password" id="erpassword22" size="15" maxlength="10">
          </font></td>
        </TR>
        <TR>
          <td height="26" colspan="2" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC"><div align="right"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Challenge
                  Phrase:</strong> </font></div>
          </td>
          <td height="26" colspan="2" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="user_challenge_phrase" type="text" id="user_challenge_phrase2" size="50">
          </font></td>
        </TR>
        <TR>
          <td height="25" colspan="2" align="center" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD"><div align="right"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Challenge
                  Response:</strong></font></div>
          </td>
          <td height="25" colspan="2" align="center" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD"><div align="left"><font face="Arial, Helvetica, sans-serif"><font size="2">
              <input name="user_challenge_response" type="text" id="user_challenge_response" size="40" maxlength="40">
            </font></font></div>
          </td>
        </TR>
        <TR>
          <TH height="21" colspan="4" NOWRAP bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">Please
              write this information in a SAFE place.</font></TH>
        </TR>
        <TR>
          <td height="26" colspan="6" bordercolor="#FFCC00" bgcolor="#FFCC00"><font color="#000000" size="3" face="Arial, Helvetica, sans-serif"><strong>&nbsp;&nbsp;<font size="4">&nbsp;&nbsp;Your
                  Shipping Information:</font></strong></font></td>
        </TR>
        <TR>
          <td width="8%" height="25" align="right" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD">
            <div align="right"><font size="2" face="Arial, Helvetica, sans-serif"></font> </div>
          </td>
          <td colspan="3" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD">
            <center>
              <font size="2" face="Arial, Helvetica, sans-serif">Please provide
              your exact shipping address below</font>
            </center>
          </td>
          <TH NOWRAP bgcolor="#FFCC33">&nbsp;</TH>
          <td align="center" valign="middle" bgcolor="#000000"><font color="#00FFFF" size="2" face="Arial, Helvetica, sans-serif"><strong>Personal
                Information</strong></font></td>
        </TR>
        <TR>
          <td height="24" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC">
            <div align="right"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Postal
                  Code:&nbsp;&nbsp;</strong></font></div>
          </td>
          <td height="24" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="member_postal_code" type="text" id="member_postal_code2" size="8" maxlength="8">
          </font></td>
          <td height="24" colspan="2" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC">&nbsp;</td>
          <TH height="24" NOWRAP bgcolor="#FFCC33">&nbsp;</TH>
          <td rowspan="4" align="center" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">It
              is not necessary to provide this data if you have no plans to make
              a purchase directly from<strong> </strong>the<strong> KB </strong> web
              site. <br>
      For instance, online auction customers do not need to provide this information.</font></td>
        </TR>
        <TR>
          <td height="26" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD">
            <div align="right"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Prefecture:&nbsp;&nbsp;</strong></font></div>
          </td>
          <td width="6%" height="26" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="member_ship_pref_prov" type="text" id="member_ship_pref_prov2" size="8" maxlength="8">
          </font></td>
          <td width="17%" align="center" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD">&nbsp;</td>
          <td width="37%" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD"><font size="2" face="Arial, Helvetica, sans-serif"><strong>City:
            <input name="member_ship_city" type="text" id="member_ship_city4">
          </strong></font><font size="2" face="Arial, Helvetica, sans-serif">&nbsp;</font>          </td>
          <TH height="26" NOWRAP bgcolor="#FFCC33">&nbsp;</TH>
        </TR>
        <TR>
          <td height="24" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC">
            <div align="right"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Address:&nbsp;&nbsp;</strong></font></div>
          </td>
          <td height="24" colspan="3" align="left" valign="middle" bordercolor="#FFCC00" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="member_ship_address_1" type="text" id="member_ship_address_12" size="35" maxlength="35">
          </font></td>
          <TH height="24" NOWRAP bgcolor="#FFCC33">&nbsp;</TH>
        </TR>
        <TR>
          <td height="24" align="right" valign="middle" bordercolor="#FFCC00" bgcolor="#DDDDDD"><font size="2" face="Arial, Helvetica, sans-serif"><strong>&nbsp;</strong></font></td>
          <td height="24" colspan="3" bordercolor="#FFCC00" bgcolor="#DDDDDD"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="member_ship_address_2" type="text" id="member_ship_address_22" size="35" maxlength="35">
          </font></td>
          <TH height="24" NOWRAP bgcolor="#FFCC33">&nbsp;</TH>
        </TR>
        <tr bordercolor="#000000">
          <td height="27" colspan="6" bgcolor="#FFCC00"><font color="#000000" size="2" face="Arial, Helvetica, sans-serif"><strong>&nbsp;<font size="4">&nbsp;&nbsp;&nbsp;Advanced
                  Services: (Optional)</font></strong></font></td>
        </tr>
        <tr bordercolor="#000000">
          <td colspan="2" align="center" valign="middle"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="checkbox22" type="checkbox" value="checkbox" checked>
            </font>
          <td height="18" colspan="2"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Enable
                My Member Account (Required)</strong></font></td>
          <td align="center" valign="middle" bgcolor="#FFCC33"><div align="justify"><font size="2" face="Arial, Helvetica, sans-serif"><strong>&nbsp;</strong></font></div>
          </td>
          <td align="center" valign="middle" bgcolor="#000000"><font size="2" face="Arial, Helvetica, sans-serif"><strong><font color="#00FFFF">NOTICE</font></strong></font></td>
        </tr>
        <tr bordercolor="#000000">
          <td colspan="2" align="center" valign="middle" bgcolor="#CCCCCC"> <font size="2" face="Arial, Helvetica, sans-serif">
            <input name="checkbox2" type="checkbox" value="checkbox">
          </font></td>
          <td height="16" colspan="2" bgcolor="#CCCCCC"><p><font size="2" face="Arial, Helvetica, sans-serif"><strong>Activate
                  My Personal Wishlist (available Fall/Winter 2003)</strong></font></p>
          </td>
          <td rowspan="6" align="center" valign="middle" bgcolor="#FFCC33"><font size="2" face="Arial, Helvetica, sans-serif">&nbsp;</font></td>
          <td rowspan="6" align="center" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">Shopping
              cart and Wishlist access require complete personal information
              to be provided. <br>
      Your personal information wil not be divulged to any third party without
      your expressed authorization.</font></td>
        </tr>
        <tr bordercolor="#000000">
          <td height="19" colspan="2" align="center" valign="middle"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="checkbox3" type="checkbox" value="checkbox" checked>
          </font></td>
          <td height="19" colspan="2"><font size="2" face="Arial, Helvetica, sans-serif"><strong>E-mail
                me with monthly special offers</strong></font></td>
        </tr>
        <tr bordercolor="#000000">
          <td height="19" colspan="2" align="center" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="checkbox4" type="checkbox" value="checkbox" checked>
          </font></td>
          <td height="19" colspan="2" bgcolor="#CCCCCC"><strong><font size="2" face="Arial, Helvetica, sans-serif">Allow
                Email from our trusted partners</font></strong></td>
        </tr>
        <tr bordercolor="#000000">
          <td height="19" colspan="2" align="center" valign="middle"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="checkbox5" type="checkbox" value="checkbox">
          </font></td>
          <td height="19" colspan="2"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Email
                me when an item on my Wishlist is on sale.</strong></font></td>
        </tr>
        <tr bordercolor="#000000">
          <td height="16" colspan="2" align="center" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="checkbox6" type="checkbox" value="checkbox" checked>
          </font></td>
          <td height="16" colspan="2" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Enable
                Forum Access: <font color="#FF0000">(available Summer 2004)</font></strong></font></td>
        </tr>
        <tr bordercolor="#000000">
          <td height="15" colspan="2" align="center" valign="middle"><font size="2" face="Arial, Helvetica, sans-serif">
            <input name="checkbox7" type="checkbox" value="checkbox" checked>
          </font></td>
          <td height="15" colspan="2"><font size="2" face="Arial, Helvetica, sans-serif"><strong>Enable "Custom
                Cruzer" Access: <font color="#FF0000">(available Spring
                2004)</font></strong></font></td>
        </tr>
        <TR bgcolor="#FFCC33">
          <td height="27" colspan="6"><div align="left"><font color="#000000" size="2" face="Arial, Helvetica, sans-serif"><strong>&nbsp;<font size="4">&nbsp;&nbsp;&nbsp;Your
                    Public Profile:</font></strong></font></div>
          </td>
        </TR>
        <TR>
          <td height="21" colspan="4" bgcolor="#FFFFFF"><center>
              <strong><font size="3" face="Arial, Helvetica, sans-serif">Tell
              us a little bit about your ride. </font></strong>
            </center>
          </td>
          <TD bgcolor="#FFCC00">&nbsp;</TD>
          <TD bgcolor="#000000"><center>
              <font color="#00FFFF" size="2" face="Arial, Helvetica, sans-serif"><strong>Public
              Information</strong></font><strong> </strong>
            </center>
          </TD>
        </TR>
        <TR>
          <td height="16" colspan="2" align="right" valign="middle" bgcolor="#FFFFFF"><strong>Year:</strong></td>
          <TD bgcolor="#FFFFFF"><select name="member_year" id="select">
              <option value="1990">1990</option>
              <option value="1991">1991</option>
              <option value="1992">1992</option>
              <option value="1993">1993</option>
              <option value="1994">1994</option>
              <option value="1995">1995</option>
              <option value="1996">1996</option>
              <option value="1997">1997</option>
              <option value="1998">1998</option>
              <option value="1999">1999</option>
              <option value="2000">2000</option>
              <option value="2001">2001</option>
              <option value="2002">2002</option>
              <option value="2003">2003</option>
              <option value="2004">2004</option>
            </select>
          </TD>
          <TD bgcolor="#FFFFFF">          <strong>
          </strong></TD>
          <TD bgcolor="#FFCC00">&nbsp;</TD>
          <TD rowspan="7" align="center" valign="middle" bgcolor="#CCCCCC"><font size="2" face="Arial, Helvetica, sans-serif">In
              addition to your UserID, the information in your public profile
              will be visible to other members in the forums and "Custom
              Cruzer" areas when they become available to the public.</font></TD>
        </TR>
        <TR>
          <td height="16" colspan="2" align="right" valign="middle" bgcolor="#FFFFFF"><strong>Make:</strong></td>
          <TD bgcolor="#FFFFFF"><select name="member_make" size="1" id="member_make">
            <?php
do {  
?>
            <option value="<?php echo $row_rs_make['make_id']?>"><?php echo $row_rs_make['make_name']?></option>
            <?php
} while ($row_rs_make = mysql_fetch_assoc($rs_make));
  $rows = mysql_num_rows($rs_make);
  if($rows > 0) {
      mysql_data_seek($rs_make, 0);
	  $row_rs_make = mysql_fetch_assoc($rs_make);
  }
  // WHY THE HELL DOESN'T THIS SELECT PICK UP THE VALUES FROM [rs_make] ???!!!
?>
                    </select></TD>
          <TD bgcolor="#FFFFFF">&nbsp;</TD>
          <TD bgcolor="#FFCC00">&nbsp;</TD>
        </TR>
        <TR>
          <td height="16" colspan="2" align="right" valign="middle" bgcolor="#FFFFFF"><strong>Model: </strong></td>
          <TD bgcolor="#FFFFFF"><strong>
            <input name="member_model" type="text" id="member_model4">
          </strong></TD>
          <TD align="center" valign="middle" bgcolor="#FFFFFF"> <font size="2" face="Arial, Helvetica, sans-serif">examples; VT-600C, NV-400C, SteedVLX etc.</font></TD>
          <TD bgcolor="#FFCC00">&nbsp;</TD>
        </TR>
        <TR>
          <td colspan="2" rowspan="4" align="right" valign="middle" bgcolor="#FFFFFF"><font size="3" face="Arial, Helvetica, sans-serif"><strong>Comment:</strong></font></td>
          <TD colspan="2" rowspan="4" bgcolor="#FFFFFF"><font size="3" face="Arial, Helvetica, sans-serif">
            <textarea 
                                name="user_comment" cols="50" rows="3" wrap="VIRTUAL" id="textarea2"></textarea>
</font></TD>
          <TD bgcolor="#FFCC00">&nbsp;</TD>
        </TR>
        <TR>
          <TD bgcolor="#FFCC00">&nbsp;</TD>
        </TR>
        <TR>
          <TD bgcolor="#FFCC00">&nbsp;</TD>
        </TR>
        <TR>
          <TD height="48" bgcolor="#FFCC00">&nbsp;</TD>
        </TR>
        <TR>
          <TH colspan="2" NOWRAP bgcolor="#FFFFFF"><div align="right"></div>
          </TH>
          <TD colspan="4" bgcolor="#FFFFFF"><font size="3" face="Arial, Helvetica, sans-serif">&nbsp;          </font></TD>
        </TR>
        <TR bgcolor="#CCCCCC">
          <TH COLSPAN="6" NOWRAP>
            <div align="left"><font color="#FF0000" size="5" face="Arial, Helvetica, sans-serif"> *</font><font face="Arial, Helvetica, sans-serif"> =
                Indicates a Mandatory Field</font></div>
          </TH>
        </TR>
      </TABLE>
      <TABLE WIDTH="790" BORDER="0" align="center" cellpadding="0" cellspacing="0">
        <TR bgcolor="#FFFFFF"> 
          <TH width="66%" height="44" NOWRAP> <font size="3" face="Arial, Helvetica, sans-serif"> 
            <INPUT name="SUBMIT" TYPE="SUBMIT" VALUE="JOIN KokusaiBuhin Dot Com">
            <img src="../images/t_spacer.gif" width="118" height="20" border="0" align="absmiddle"> 
            <INPUT name="RESET" TYPE="RESET" VALUE="Erase This Form">
            </font></TH>
        </TR>
        <TR bgcolor="#FFFFFF"> 
          <TH NOWRAP>&nbsp;</TH>
        </TR>
      </TABLE>
      <font size="3" face="Arial, Helvetica, sans-serif">
      <input type="HIDDEN" name="action" value="register">
</font>
    </CENTER>
  </DIV>
</FORM>
</span> 
<?php
}

function create_account() {
   global $userid, $username, $userpassword, $userpassword2, 
          $usercountry, $useremail, $userprofile;
   global $default_dbname, $user_tablename;
   if(empty($userid)) error_message("Enter your desired ID!");
   if(empty($userpassword)) error_message("Enter your desired password!");
   if(strlen($userpassword) < 4 ) error_message("Password too short!");
   if(empty($userpassword2)) 
                  error_message("Retype your password for verification!");
   if(empty($username)) error_message("Enter your full name!");
   if(empty($useremail)) error_message("Enter your email address!");
   if(empty($userprofile)) $userprofile = "No Comment.";
   
   if($userpassword != $userpassword2)
      error_message("Your desired password and retyped password do not match!");
   
   $link_id = db_connect($default_dbname);
   
   if(in_use($userid))
         error_message("$userid is in use. Please choose a different ID.");
		 //These fields need to be completed and the form variables matched with valid DB row_names
   $query = "INSERT INTO user VALUES(NULL, '$userid', 
                                     password('$userpassword'), '$username',
                                    '$usercountry', '$useremail',
                                    '$userprofile', curdate(), NULL)";
   $result = mysql_query($query);
   if(!$result) error_message(sql_error());
   $usernumber = mysql_insert_id($link_id);
   html_header();
?>
<CENTER>
  <H3><span id="Layer3" style="position:absolute; width:691px; height:115px; z-index:3; left: 44px; top: 1538px;"> 
    <CENTER>
      <H3> <?php echo $username ?>, thank you for registering with us! </H3>
    </CENTER>
    <DIV ALIGN="CENTER">
      <CENTER>
        <TABLE WIDTH="90%" BORDER="1" align="center" cellpadding="0" cellspacing="0" bordercolor="#990000">
          <TR> 
            <TH WIDTH="30%" NOWRAP> <div align="right">User Number : </div></TH>
            <TD colspan="3"><?php echo $usernumber ?></TD>
          </TR>
          <TR> 
            <TH WIDTH="30%" NOWRAP> <div align="right">User ID : </div></TH>
            <TD colspan="3"><?php echo $userid ?></TD>
          </TR>
          <TR> 
            <TH WIDTH="30%" NOWRAP> <div align="right"> User Password : </div></TH>
            <TD colspan="3"><?php echo $userpassword ?></TD>
          </TR>
          <TR> 
            <TH WIDTH="30%" NOWRAP> <div align="right">Full Name : </div></TH>
            <TD colspan="3"><?php echo $username ?></TD>
          </TR>
          <TR> 
            <TH WIDTH="30%" NOWRAP> <div align="right">Country : </div></TH>
            <TD colspan="3"><?php echo $usercountry ?></TD>
          </TR>
          <TR> 
            <TH WIDTH="30%" NOWRAP> <div align="right">Email : </div></TH>
            <TD colspan="3"><?php echo $useremail ?></TD>
          </TR>
          <TR> 
            <TH WIDTH="30%" NOWRAP> <div align="right">Profile : </div></TH>
            <TD colspan="3"><?php echo htmlspecialchars($userprofile) ?></TD>
          </TR>
          <TR bgcolor="#FFFFFF"> 
            <TH height="51" colspan="4" NOWRAP><img src="../images/continue.gif" width="156" height="33" border="0" usemap="#MapMap"></TH>
          </TR>
        </TABLE>
      </CENTER>
    </DIV>
    <map name="MapMap">
      <area shape="rect" coords="2,0,155,32" href="../index.php">
    </map>
  </span></H3>
</CENTER>
<DIV ALIGN="CENTER"></DIV>
<?php
	html_footer();
}

switch($action) {
   case "register": 
      create_account();
   break;
   default:
      html_header();
      register_form();
      html_footer();
   break;
}
?>
<map name="Map">
  <area shape="rect" coords="2,0,155,32" href="../index.php">
</map>
<?php
mysql_free_result($rs_make);
?>
?>

Any advice offered is appreciated as always.

Thanks
---------------------------------------------
SteedVLX
User avatar
Kriek
Forum Contributor
Posts: 238
Joined: Wed May 29, 2002 3:46 am
Location: Florida
Contact:

Post by Kriek »

First and foremost get rid of the double ending tags and/or start tags.
Then condense the beginning portion of your code; that IS ridiculous.

Code: Select all

<?php
    require_once('../Connections/kb_conn.php');
    include '../includes/common_db.php';
    mysql_select_db($database_kb_conn, $kb_conn);
    $query_rs_make = "SELECT * FROM make_tbl ORDER BY make_name ASC";
    $rs_make = mysql_query($query_rs_make, $kb_conn) or die(mysql_error());
    $row_rs_make = mysql_fetch_assoc($rs_make);
    $totalRows_rs_make = mysql_num_rows($rs_make);
    function in_use($userid) {
        global $user_tablename;
        $query = "SELECT userid FROM $user_tablename WHERE userid = '$userid'";
        $result = mysql_query($query);
        if (!mysql_num_rows($result)) return 0;
        else return 1;
    }
    function register_form() {
        global $userid, $username, $usercountry, $useremail, $userprofile, $country_array;
        global $PHP_SELF;
?>
Now to address the chief quandary at hand; you are missing brackets.
It IS possible without them, but not only sloppy but hard to read also.

Code: Select all

<?php
}
while ($row_rs_make = mysql_fetch_assoc($rs_make)) {
    $rows = mysql_num_rows($rs_make);
    if ($rows > 0) {
        mysql_data_seek($rs_make, 0);
        $row_rs_make = mysql_fetch_assoc($rs_make);
    }
}
?>
User avatar
steedvlx
Forum Contributor
Posts: 122
Joined: Wed Jun 11, 2003 10:54 pm
Location: Osaka, Japan

Post by steedvlx »

Thanks for the reply. (Yes, I know the code is messy) But it is a work in progress, and the many open/close tags help me remember that each separate piece of code was added for a different reason. I strip them all out when I'm ready to close the job.

OK, I followed your suggestions anyway... I cleaned everything up, and then I took a look at the code fix you suggested. Actually, if I added that bracket, it would be one to many. But, anyway, I tried it out of desperation, and it choked the page.

The original code block for that was;

Code: Select all

<TD bgcolor="#FFFFFF"><select name="member_make" size="1" id="member_make">
            <?php
do {  
?>
<option value="<?php echo $row_rs_makes['make_name']?>"><?php echo $row_rs_makes['make_name']?></option>
<?php
} while ($row_rs_make = mysql_fetch_assoc($rs_make));
  $rows = mysql_num_rows($rs_make);
  if($rows > 0) {
      mysql_data_seek($rs_makes, 0);
	  $row_rs_make = mysql_fetch_assoc($rs_make);
  }
?>
                    </select></TD>
A lot of folks don't seem to like DO-WHILE logic. But, I'm not one of them. Especially when I want to DO a dynamic list box.

Thank you for your time and your suggestions. Unfortunately, we didn't score a hit. If you see anything else, I would love to know how to fix this.

Thanks,
----------------------------------
SteedVLX
Post Reply