Page 1 of 1

Newbie to PHP, I Really need help

Posted: Fri Jun 25, 2010 6:18 pm
by celenco
:banghead: So I just got this new script for making book covers, and I love it but if I try to upload a picture it gives me this error "Cannot modify header information - headers already sent by (output started at /home/celenco/public_html/ZOINKI.COM/ecc/includes/upload.processor.php:4) in /home/celenco/public_html/ZOINKI.COM/ecc/includes/upload.processor.php on line 95"

Here is the php code, can someone plzzz help me out, I have no idea what to do. Thanks



Code: Select all

<link href="../css/main.css" rel="stylesheet" type="text/css" />


<?php  

// filename: upload.processor.php

// first let's set some variables

// make a note of the current working directory, relative to root.
$directory_self = str_replace(basename($_SERVER['PHP_SELF']), '', $_SERVER['PHP_SELF']);

// make a note of the directory that will recieve the uploaded files
$uploadsDirectory = 'uploadedorg/';

// make a note of the location of the upload form in case we need it
$uploadForm = '../create3d.php';

// make a note of the location of the success page

// name of the fieldname used for the file in the HTML form
$fieldname = 'file';



// Now let's deal with the upload

// possible PHP upload errors
$errors = array(1 => 'php.ini max file size exceeded', 
                2 => 'html form max file size exceeded', 
                3 => 'file upload was only partial', 
                4 => 'no file was attached');

// check the upload form was actually submitted else print form
isset($_POST['submit'])
	or error('the upload form is neaded', $uploadForm);

// check for standard uploading errors
($_FILES[$fieldname]['error'] == 0)
	or error($errors[$_FILES[$fieldname]['error']], $uploadForm);
	
// check that the file we are working on really was an HTTP upload
@is_uploaded_file($_FILES[$fieldname]['tmp_name'])
	or error('not an HTTP upload', $uploadForm);
	
// validation... since this is an image upload script we 
// should run a check to make sure the upload is an image
@getimagesize($_FILES[$fieldname]['tmp_name'])
	or error('only image uploads are allowed', $uploadForm);
	
// make a unique filename for the uploaded file and check it is 
// not taken... if it is keep trying until we find a vacant one
$now = time();
while(file_exists($uploadFilename = $uploadsDirectory.$now.'-'.$_FILES[$fieldname]['name']))
{
	$now++;
}

$uploadFilename = str_replace(" ", "", $uploadFilename);

// now let's move the file to its final and allocate it with the new filename
@move_uploaded_file($_FILES[$fieldname]['tmp_name'], $uploadFilename)
	or error('receiving directory insuffiecient permission', $uploadForm);
	
// make an error handler which will be used if the upload fails
function error($error, $location, $seconds = 5)
{
	header("Refresh: $seconds; URL=\"$location\"");
	echo '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"'."\n".
	'"http://www.w3.org/TR/html4/strict.dtd">'."\n\n".
	'<html lang="en">'."\n".
	'	<head>'."\n".
	'		<meta http-equiv="content-type" content="text/html; charset=iso-8859-1">'."\n\n".
	'		<link rel="stylesheet" type="text/css" href="stylesheet.css">'."\n\n".
	'	<title>Upload error</title>'."\n\n".
	'	</head>'."\n\n".
	'	<body>'."\n\n".
	'	<div id="Upload">'."\n\n".
	'		<h1>Upload failure</h1>'."\n\n".
	'		<p>An error has occured: '."\n\n".
	'		<span class="red">' . $error . '...</span>'."\n\n".
	'	 	The upload form is reloading</p>'."\n\n".
	'	 </div>'."\n\n".
	'</html>';
	exit;
} // end error handler

// If you got this far, everything has worked and the file has been successfully saved.
// We are now going to redirect the client to the success page.



$uploadSuccess = 'http://' . $_SERVER['HTTP_HOST'] . $directory_self . 'createSizes2.php?n=' . $uploadFilename . '';

header('Location: ' . $uploadSuccess);



?>

Re: Newbie to PHP, I Really need help

Posted: Fri Jun 25, 2010 7:27 pm
by mikosiko
celenco wrote:<link href="../css/main.css" rel="stylesheet" type="text/css" />


<?php  
delete the spaces between this 2 lines and try... also look for extra spaces in this lines
celenco wrote:$uploadSuccess = 'http://' . $_SERVER['HTTP_HOST'] . $directory_self . 'createSizes2.php?n=' . $uploadFilename . '';

header('Location: ' . $uploadSuccess);

Re: Newbie to PHP, I Really need help

Posted: Fri Jun 25, 2010 7:33 pm
by celenco
mikosiko wrote:
celenco wrote:<link href="../css/main.css" rel="stylesheet" type="text/css" />


<?php  
delete the spaces between this 2 lines and try... also look for extra spaces in this lines
celenco wrote:$uploadSuccess = 'http://' . $_SERVER['HTTP_HOST'] . $directory_self . 'createSizes2.php?n=' . $uploadFilename . '';

header('Location: ' . $uploadSuccess);
After taking away the spaces not it says "Warning: Cannot modify header information - headers already sent by (output started at /home/celenco/public_html/ZOINKI.COM/ecc/includes/upload.processor.php:2) in /home/celenco/public_html/ZOINKI.COM/ecc/includes/upload.processor.php on line 92"

Re: Newbie to PHP, I Really need help

Posted: Fri Jun 25, 2010 7:48 pm
by mikosiko
The "headers already sent" error is usually caused by having white space before or after the opening and closing PHP tags (<?php . . . ?>), therefore check for extra spaces

Re: Newbie to PHP, I Really need help

Posted: Fri Jun 25, 2010 7:52 pm
by celenco
mikosiko wrote:The "headers already sent" error is usually caused by having white space before or after the opening and closing PHP tags (<?php . . . ?>), therefore check for extra spaces
Yeah, I tried to find a space but there was nothing...I am editing with dreamweaver.

Re: Newbie to PHP, I Really need help

Posted: Sat Jun 26, 2010 3:20 am
by internet-solution
You have the following line bfeore <?php

Code: Select all

<link href="../css/main.css" rel="stylesheet" type="text/css" />
move this inside <?php and use echo.

Code: Select all

<?php 

echo'<link href="../css/main.css" rel="stylesheet" type="text/css" />';

(Solved)Newbie to PHP, I Really need help

Posted: Sat Jun 26, 2010 10:00 pm
by celenco
internet-solution wrote:You have the following line bfeore <?php

Code: Select all

<link href="../css/main.css" rel="stylesheet" type="text/css" />
move this inside <?php and use echo.

Code: Select all

<?php 

echo'<link href="../css/main.css" rel="stylesheet" type="text/css" />';
Wow. thank you, this worked...After following your advise, I kept getting errors, so I decided to edit with wordpad instead of dreamweaver and It fixed it. I have been trying to figure out what was wrong and you really helped me out. Thanks! I really need to learn Php but it seems so daunting.

Re: (Solved)Newbie to PHP, I Really need help

Posted: Sun Jun 27, 2010 4:08 am
by internet-solution
celenco wrote: I really need to learn Php but it seems so daunting.
Not really. Among the languages learnt, I have found PHP to be the easiest. I would recommend you start with w3schools.com. On top of that, the number of web resources available on PHP is staggering - remember Google is your friend :wink: .