Uploads?

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
ScottCFR
Forum Commoner
Posts: 33
Joined: Sat Jun 19, 2010 7:36 pm

Uploads?

Post by ScottCFR »

The title describes it. I am trying to make a music upload. I got some picture upload from w3 I think it was, but I can't get it modified to allow music. Also, how would I add a loading bar?

EDIT:

Code: Select all

<?php
if(isset($_POST['submit'])) {
if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/pjpeg"))
&& ($_FILES["file"]["size"] < 20000))
  {
  if ($_FILES["file"]["error"] > 0)
    {
    echo "Return Code: " . $_FILES["file"]["error"] . "<br />";
    }
  else
    {
    echo "Upload: " . $_FILES["file"]["name"] . "<br />";
    echo "Type: " . $_FILES["file"]["type"] . "<br />";
    echo "Size: " . ($_FILES["file"]["size"] / 1024) . " Kb<br />";
    echo "Temp file: " . $_FILES["file"]["tmp_name"] . "<br />";

    if (file_exists("upload/" . $_FILES["file"]["name"]))
      {
      echo $_FILES["file"]["name"] . " already exists. ";
      }
    else
      {
      move_uploaded_file($_FILES["file"]["tmp_name"],
      "upload/" . $_FILES["file"]["name"]);
      echo "Code to place: " . "" 
      }
    }
  }
else
  {
  echo "Invalid file";
  }
  }
?>
User avatar
yacahuma
Forum Regular
Posts: 870
Joined: Sun Jul 01, 2007 7:11 am

Re: Uploads?

Post by yacahuma »

print this information $_FILES["file"]["type"] to see what you are uploading. In your code your are only allowing images: image/gif,image/jpeg,image/pjpeg.

Just remove those checks. But be careful when uploading files. You could actually upload a php file that could be executed by a remote attack.
ScottCFR
Forum Commoner
Posts: 33
Joined: Sat Jun 19, 2010 7:36 pm

Re: Uploads?

Post by ScottCFR »

Yeah, I've heard. Is there a way where I can only allow MP3's?
User avatar
yacahuma
Forum Regular
Posts: 870
Joined: Sun Jul 01, 2007 7:11 am

Re: Uploads?

Post by yacahuma »

you can upload anything. All that is limiting you are this lines of code. If you remove them , you will not be checking for any types.

Code: Select all

if ((($_FILES["file"]["type"] == "image/gif")
|| ($_FILES["file"]["type"] == "image/jpeg")
|| ($_FILES["file"]["type"] == "image/pjpeg"))
ScottCFR
Forum Commoner
Posts: 33
Joined: Sat Jun 19, 2010 7:36 pm

Re: Uploads?

Post by ScottCFR »

I mean, what would I change the code to, so I can only upload MP3's. I don't need an image uploader.
User avatar
Jonah Bron
DevNet Master
Posts: 2764
Joined: Thu Mar 15, 2007 6:28 pm
Location: Redding, California

Re: Uploads?

Post by Jonah Bron »

That's why he said tell us the value of $_FILES['files']['type'].
Post Reply