Register user script won't work

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
drayarms
Forum Contributor
Posts: 134
Joined: Fri Dec 31, 2010 5:11 pm

Register user script won't work

Post by drayarms »

I had used this simple script below to register users on a site which i was building and it worked. After several updates of the database, the same script won't work again. The error message is displayed directly below the script. Apparently, the problem is on line 29 : echo "Welcome $_POST[username]! You've been successfully reigstered! <br /><br /> Can anyone pinpoint the trouble maker?


Code: Select all

<?php

//address error handling

ini_set ('display_errors', 1);
error_reporting (E_ALL & ~E_NOTICE);



// Check if he wants to register:
if (!empty($_POST[username]))
{
	// Check if passwords match.
	if ($_POST[password] != $_POST[password2])
		exit("Error - Passwords don't match. Please go back and try again.");

	// Assign some variables.
	$date = mktime(0,0,0,date("m"),date("d"),date("Y"));
	$ip = $_SERVER[REMOTE_ADDR];

	require_once("config.php");

	// Register him.
	$query = mysql_query("INSERT INTO members 
	(member_id, username, firstname, lastname, password, register_date, ip)
	VALUES	(0, '$_POST[username]','$_POST[firstname]','$_POST[lastname]','$_POST[password]','$date','$ip')")
	or die ('<p>Could not register user becasue: <b>' .mysql_error().'</b>.</p>);
	
	echo "Welcome $_POST[username]! You've been successfully reigstered! <br /><br />
		Please login <a href='login.php'><b>here</b></a>.";
	exit();
}

?>

<html>
	<head>
		<title>Register</title>
	</head>


	<body>

                <?php require('header.html'); ?>






 <div id="main" style="background-color: #FFFFFF; height:71%; width:101%; border:0px none none; margin:auto; "> <!--opens the white content area--> 
 
 
 
 
 
 
 
               <div id="main_left" style="float:left; height:100%; width:20%; border:0px none none;"> <!--opens main left--> 
 
 
  
 
                     <div id="main_left_top" style="float:left; position:relative;bottom:5px;right:5px; height:31.25%; width:93.8%; border:5px solid #c0c0c0; margin:5px;"> <!--opens main left top--> 
 
  
                               
 
                     </div> <!-- closes main left top--> 
 
 
 
 
                     <div id="main_left_center" style="float:left; background-color: #FFFFFF; height:33%; width:100%; border-color:#a0a0a0;border-style:outset;border-width:1px; margin:auto; "> <!--opens the white content area--> 
 
  
 
 
                     </div> <!-- closes main left center--> 
 
 
 
 
                     <div id="main_left_bottom" style="float:left; background-color: #FFFFFF; height:33%; width:100%; border-color:#a0a0a0;border-style:outset;border-width:1px; margin:auto; "> <!--opens the white content area--> 
 
  
 
 
                     </div> <!-- closes main left bottom--> 
 
 
 
 
 
               </div> <!-- closes main left--> 
 
 
 
 
 
 
 
              <div id="main_center" class="content_text" style="float:left;  height:98%; width:57%; border:5px solid #c0c0c0;"> <!--opens main center--> 
 
  
 
                     
                  
                     	    
                   <div style=" width:76%; height:40%; position:relative;top:100px; left:50px; ">
           


                      <form action="register.php" method="post">
			<table width="75%" border="1" align="center" cellpadding="3" cellspacing="1">
				<tr>
					<td width="100%"><h5>Registration</h5></td>
				</tr>
				<tr>
					<td width="100%"><label>Desired Username: <input type="text" name="username" size="25" value="<? echo $_POST[username]; ?>"></label></td>
				</tr>
				<tr>
					<td width="100%"><label>First Name: &nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <input type="text" name="firstname" size="25" value="<? echo $_POST[firstname]; ?>"></label></td>
				</tr>
				<tr>
					<td width="100%"><label>Last Name:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <input type="text" name="lastname" size="25" value="<? echo $_POST[lastname]; ?>"></label></td>
				</tr>
				<tr>
					<td width="100%"><label>Password:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; <input type="password" name="password" size="25" value="<? echo $_POST[password]; ?>"></label></td>
				</tr>
				<tr>
					<td width="100%"><label>Verify Password:&nbsp;&nbsp;&nbsp;&nbsp; <input type="password" name="password2" size="25" value=""></label></td>
				</tr>
				<tr>
					<td width="100%"><input type="submit" value="Register!"></td>
				</tr>
			</table>
		      </form>



                    </div>





              </div> <!-- closes main center--> 
 
 
 
 
 
 
              <div id="main_right" style="float:left; background-color: #FFFFFF; height:100%; width:20%; border-color:#a0a0a0;border-style:outset;border-width:1px; margin:auto; "> <!--opens the white content area--> 
 
 
 
                     <div id="main_right_top" style="float:left; background-color: #FFFFFF; height:33%; width:100%; border-color:#a0a0a0;border-style:outset;border-width:1px; margin:auto; "> <!--opens the white content area--> 
 
  
 
 
                     </div> <!-- closes main left top--> 
 
 
 
 
                     <div id="main_right_center" style="float:left; background-color: #FFFFFF; height:33%; width:100%; border-color:#a0a0a0;border-style:outset;border-width:1px; margin:auto; "> <!--opens the white content area--> 
 
  
 
 
                     </div> <!-- closes main left center--> 
 
 
 
 
                     <div id="main_right_bottom" style="float:left; background-color: #FFFFFF; height:33%; width:100%; border-color:#a0a0a0;border-style:outset;border-width:1px; margin:auto; "> <!--opens the white content area--> 
 
  
 
 
                     </div> <!-- closes main left bottom--> 
 
 
 
               </div> <!-- closes main right--> 
 
 
 
 
 
 
 
 
        </div> <!-- closes main--> 
 
 
 
 
 
  <?php require('footer.html'); ?>

 



           


	</body>
</html>






Parse error: syntax error, unexpected T_STRING in /home/a7522929/public_html/register.php on line 29
Last edited by Benjamin on Thu Jan 06, 2011 6:13 pm, edited 1 time in total.
Reason: Added [syntax=php] tags.
anantha
Forum Commoner
Posts: 59
Joined: Thu Dec 23, 2010 7:38 pm

Re: Register user script won't work

Post by anantha »

when you are inserting i.e registering...why are u giving member_id value as 0?

Code: Select all

die ('<p>Could not register user becasue: <b>' .mysql_error().'</b>.</p>);
it should be

Code: Select all

die ('<p>Could not register user becasue: <b>' .mysql_error().'</b>.</p>');
you missed single quotes thats why it is showing the error.
User avatar
social_experiment
DevNet Master
Posts: 2793
Joined: Sun Feb 15, 2009 11:08 am
Location: .za

Re: Register user script won't work

Post by social_experiment »

Once you have fixed that error you are likely to encounter another syntax error.

Code: Select all

<?php
echo "Welcome ". $_POST[username] ."! You've been successfully reigstered! <br /><br />
                Please login <a href='login.php'><b>here</b></a>.";
?>
“Don’t worry if it doesn’t work right. If everything did, you’d be out of a job.” - Mosher’s Law of Software Engineering
Post Reply