Wondering if you can review this code
Posted: Thu Jan 20, 2011 9:07 pm
***** PLEASE USE PHP CODE TAG *****
I wondering if you guys can make sure that I got all the brackets and such in. I looked many times but found nothing wrong. Also my html forum is not even submitting so there is no way for me to test to see if I have got all the code in right.
Thanks in advance
Code: Select all
<?php
$submit = $_POST['submit'];
$first_name = strip_tags($_POST['first_name']);
$last_name = strip_tags($_POST['last_name']);
$email = strip_tags($_POST['first_name']);
$retype_email = strip_tags($_POST['retype_email']);
$password = strip_tags($_POST['password']);
$retype_password = strip_tags($_POST['retype_password']);
if ($submit)
{
if {
($first_name&&$last_name&&$email&&$retype_email&&$password&&$retype_password)
$password = md5($password);
$retype_password = md5($retype_password);
if {
($password == $retype_password)
if (strlen($username)>25||strlen($first_name)>25||strlen($last_name)>25)
{
addError "Your username or first or last name must be between 6 and 25 characters!";
}
else
{
if (strlen($password)<6||($password)>25)
{
addError "Your password must be between 6 and 25 characters!";
}
else{
$check = mysql_query("SELECT * FROM users WHERE username='$username'");
if (mysql_num_rows($check)>=1)
addError "That username is already taken";
else {
//generate random code
$code = rand(1111111,9999999);
//send activation email
$to = $email;
$subject = "Activate your account";
$headers = "From:"
$body = "";
if (!mail($to,$subject,$body,$headers))
echo "We couldn't sign you up at this time. Please try again later.";
else{
//register into database
$register = mysql_query("INSERT INTO users VALUE ('','$username','$password','$email','$code','0')");
echo "You have been registered successfully! Please check your ($email) to activate your account";
}
}
}
}
else {
addError "Your passwords do not match!";
}
else {
addError "Please fill in ALL fields!";
}
}
}
?>
Thanks in advance