Empty Query Error Assistance

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
lsecrease
Forum Newbie
Posts: 3
Joined: Sun Oct 30, 2011 9:40 pm

Empty Query Error Assistance

Post by lsecrease »

Wrote some functions and received the following error:

Notice: Undefined variable: _SESSION in /home/pichurz/public_html/func/album.func.php on line 19
error in function_name:
query:
Query was empty



I dont see any issues with it unless its syntax. And I queried it in PHPmyadmin and it returned something unless its how I typed in "$_SESSION." Please help! Here's the script:

album.func.php

Code: Select all

<?php
include 'connect.php';

function album_data($album_id) {
  $album_id = (int)$album_id;
  $args = func_get_args();
  $fields = '`'.implode('`, `', $args).'`';
  unset($args[0]);
  $fields = '`' .implode('`,`', $args).'`';
  $query = mysql_query("SELECT $fields FROM `albums` WHERE `album_id`=$album_id AND 'user_id'=".$_SESSION['user_id']);
  foreach ($args as $field) {
   $args[$field] = $query_result[$field];
  }
  return $args;

}
function album_check($album_id) {
  $album_id = (int)$album_id;
  $query = mysql_query("SELECT COUNT(album_id) FROM `album` WHERE `album_id`=$album_id AND `user_id`=".$_SESSION['user_id'] or die(mysql_error()));
  mysql_query ($query) or die("error in function_name: <br>query: ".$query."<br>".mysql_error());
  return (mysql_result($query, 0) == 1) ? true : false;
}
function get_albums() {
  $albums = array();
  
  $albums_query = mysql_query("
  SELECT albums.album_id, albums.timestamp, albums.name, LEFT( albums.description, 50 ) AS description, COUNT( images.image_id ) AS image_count
  FROM albums
  LEFT JOIN images 
  ON albums.album_id = images.album_id
  WHERE albums.user_id ='$_SESSION[user_id]'
  GROUP BY albums.album_id
  ");
  
  while ($albums_row = mysql_fetch_assoc($albums_query)) {
    $albums[] = array(
    			'id' => $albums_row['album_id'],
    			'timestamp' => $albums_row['timestamp'],
    			'name' => $albums_row['name'],
    			'description' => $albums_row['description'],
    			'count' => $albums_row['image_count']
    			);
    		}
    		
    		return $albums;
}

function create_album($album_name, $album_description) {
include 'connect.php';
 $album_name = mysql_real_escape_string(htmlentities($album_name));
 $album_description = mysql_real_escape_string(htmlentities($album_description));
 
 mysql_query("INSERT INTO albums VALUES ('', '".$_SESSION['user_id']."', UNIX_TIMESTAMP(), '$album_name', '$album_description')");
 mkdir('uploads/'.mysql_insert_id(), 0744);
 mkdir('uploads/thumbs/'.mysql_insert_id(), 0744);

}

function edit_album($album_id, $album_name, $album_description) {
	$album_id = (int)$album_id;
	$album_name = mysql_real_escape_string($album_name);
	$album_description = mysql_real_escape_string($album_description);

	mysql_query("UPDATE albums SET 'name'=$album_name, 'description'='$album_description' WHERE 'album_id'=$album_id AND 'user_id'=".$_SESSION['user_id']);

}

function delete_album($album_id) {
	$album_id = (int)$album_id;

                //remove dir content and dir;
                $ph  = opendir("uploads/".$album_id);
                while($photos = readdir($ph)){
                        $photoArray[] = $photos;
                }
                closedir($ph);
                foreach($photoArray as $photo){
                        unlink($photo) or die ("Some files could not be deleted!");
                }
                rmdir('uploads/'.$album_id) or die ("Directory ". $album_id ." not removed!");
               
                //remove thumb dir content and thumb dir;
                $th  = opendir("uploads/thumbs/".$album_id);
                while($thumbs = readdir($th)){
                        $thumbArray[] = $thumbs;
                }
                closedir($th);
                foreach($thumbArray as $thumb){
                        unlink($thumb) or die ("Error : some files could not be deleted!");
                }
                rmdir('uploads/thumbs/'.$album_id) or die ("Thumbs directory ". $album_id ." not removed!");
               
                //remove entries form database;
                mysql_query("DELETE FROM `albums` WHERE `album_id`=$album_id AND `user_id`=".$_SESSION['user_id']);
                mysql_query("DELETE FROM `images` WHERE `album_id`=$album_id AND `user_id`=".$_SESSION['user_id']);
        
}

?>
User avatar
Celauran
Moderator
Posts: 6427
Joined: Tue Nov 09, 2010 2:39 pm
Location: Montreal, Canada

Re: Empty Query Error Assistance

Post by Celauran »

The lines in question:

Code: Select all

$query = mysql_query("SELECT COUNT(album_id) FROM `album` WHERE `album_id`=$album_id AND `user_id`=".$_SESSION['user_id'] or die(mysql_error()));
  mysql_query ($query) or die("error in function_name: <br>query: ".$query."<br>".mysql_error());
You're assigning a query result to $query on one line, then trying to pass that result as a query string to mysql_query on the next line. You also didn't properly close your query; the or die() should come after the closing parenthesis.
Post Reply