IMG UPLOAD DRIVING ME CRAZY

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
nbasso713
Forum Commoner
Posts: 29
Joined: Fri Nov 04, 2011 7:51 am

IMG UPLOAD DRIVING ME CRAZY

Post by nbasso713 »

I've been pulling my hair out trying to figure out why this won't work. I'm not receiving any errors, and my images are not being moved to the specified directory on my webserver. Folder permissions are set to 777. I've scoured the internet all day for a solution and contacted my webhost to make sure i was using the correct temporary directory, and after all that i'm still not having any luck. Any help would be greatly appreciated, before i pull all of my hair out. 8O

Note: I ************* out my username

Code: Select all

<?php
$upload_dir = "/home/****/public_html/roflsearch.com/rofl/";
if (file_exists($upload_dir) && is_writable($upload_dir)) {
    // do upload logic here


//define a maxim size for the uploaded images in Kb
define ("MAX_SIZE","100");

//This function reads the extension of the file. It is used to determine if the file is an image by checking the extension.
function getExtension($str) {
$i = strrpos($str,".");
if (!$i) { return ""; }
$l = strlen($str) - $i;
$ext = substr($str,$i+1,$l);
return $ext;
}

//This variable is used as a flag. The value is initialized with 0 (meaning no error found) and it will be changed to 1 if an errro occures. If the error occures the file will not be uploaded.
$errors=0;
//checks if the form has been submitted
if(isset($_POST['Submit']))
{
//reads the name of the file the user submitted for uploading
$image=$_FILES['image']['name'];
//if it is not empty
if ($image)
{
//get the original name of the file from the clients machine
$filename = stripslashes($_FILES['image']['name']);
//get the extension of the file in a lower case format
$extension = getExtension($filename);
$extension = strtolower($extension);
//if it is not a known extension, we will suppose it is an error and will not upload the file, otherwize we will do more tests
if (($extension != "jpg") && ($extension != "jpeg") && ($extension != "png") && ($extension != "gif"))
{
//print error message
echo '<h1>Unknown extension!</h1>';
$errors=1;
}
else
{
//get the size of the image in bytes
//$_FILES['image']['tmp_name'] is the temporary filename of the file in which the uploaded file was stored on the server
$size=filesize($_FILES['image']['/home/****/tmp/']);

//compare the size with the maxim size we defined and print error if bigger
if ($size > MAX_SIZE*1024)
{
echo '<h1>You have exceeded the size limit!</h1>';
$errors=1;
}

//we will give an unique name, for example the time in unix time format
$image_name=time().'.'.$extension;
//the new name will be containing the full path where will be stored (images folder)
$newname="/home/****/public_html/roflsearch.com/rofl/".$image_name;
//we verify if the image has been uploaded, and print error instead
$moved = move_uploaded_file($_FILES['image']['/home/****/tmp/'], $newname);
if (!$moved)
{
echo '<h1>Move unsuccessfull!</h1>';
$errors=1;
}}}}

//If no errors registred, print the success message
if(isset($_POST['Submit']) && !$errors)
{
echo "<h1>File Uploaded Successfully! Try again!</h1>";
}
}else{
	echo 'Upload directory is not writable, or does not exist.';
}

?>
User avatar
Celauran
Moderator
Posts: 6427
Joined: Tue Nov 09, 2010 2:39 pm
Location: Montreal, Canada

Re: IMG UPLOAD DRIVING ME CRAZY

Post by Celauran »

Pretty sure this is wrong:

Code: Select all

$size=filesize($_FILES['image']['/home/****/tmp/']);
It should be

Code: Select all

$size=filesize($_FILES['image']['tmp_name']);
Also, an easier way to get file extension
nbasso713
Forum Commoner
Posts: 29
Joined: Fri Nov 04, 2011 7:51 am

Re: IMG UPLOAD DRIVING ME CRAZY

Post by nbasso713 »

Thanks for replying, i've tried many variations of tmp_name and tmp all day, but nothing worked. If i was testing this script locally i believe tmp_name would work, but i'm running the script remotely on my file server. I spoke with my webhost earlier today to confirm that the path to my server's temporary folder was /home/****/tmp/.

I'm relatively new to PHP so i may be mistaken, but i thought when you uploaded a file it is first placed into a temporary folder where it can either be moved or copied.
User avatar
Celauran
Moderator
Posts: 6427
Joined: Tue Nov 09, 2010 2:39 pm
Location: Montreal, Canada

Re: IMG UPLOAD DRIVING ME CRAZY

Post by Celauran »

nbasso713 wrote:I'm relatively new to PHP so i may be mistaken, but i thought when you uploaded a file it is first placed into a temporary folder where it can either be moved or copied.
You're right -- it's usually /tmp -- but that doesn't change the array key.
nbasso713
Forum Commoner
Posts: 29
Joined: Fri Nov 04, 2011 7:51 am

Re: IMG UPLOAD DRIVING ME CRAZY

Post by nbasso713 »

What if I tried creating my own temp folder for a specific domain? I really think this is the root of my problems. I'm currently trying to read up how to do this if anyone knows an easy way of do this please let me know.
nbasso713
Forum Commoner
Posts: 29
Joined: Fri Nov 04, 2011 7:51 am

Re: IMG UPLOAD DRIVING ME CRAZY

Post by nbasso713 »

GOT IT! I was being retarded apparently, and didn't realize that the temp files were being sent to the script's directory not the host's.
Post Reply