Page 1 of 1

Please Help me with this code...

Posted: Wed Jan 18, 2012 8:59 am
by bharadwaj91
Please Help me with this code...

it always shows "error updating database"

thanks in advance

<?php
$SNAME = isset($_POST['fldSwimmerName']) ? $_POST['fldSwimmerName'] : "";;
$AGE = isset($_POST['fldAge']) ? $_POST['fldAge'] : "";;
$DOB = isset($_POST['fldDateOfBirth']) ? $_POST['fldDateOfBirth'] : "";;
$PRES1 =isset($_POST['fldPresentAddressLine1']) ? $_POST['fldPresentAddressLine1'] : "";;
$PRES2 = isset($_POST['fldPresentAddressLine2']) ? $_POST['fldPresentAddressLine2'] : "";;
$PRES3 = isset($_POST['fldPresentAddressLine3']) ? $_POST['fldPresentAddressLine3'] : "";;
$PERM1 = isset($_POST['fldPermanantAddressLine1']) ? $_POST['fldPermanantAddressLine1'] : "";;
$PERM2 = isset($_POST['fldPermanantAddressLine2']) ? $_POST['fldPermanantAddressLine2'] : "";;
$PERM3 = isset($_POST['fldPermanantAddressLine3']) ? $_POST['fldPermanantAddressLine3'] : "";;
$INS1 = isset($_POST['fldInstitutionAddressLine1']) ? $_POST['fldInstitutionAddressLine1'] : "";;
$INS2 = isset($_POST['fldInstitutionAddressLine2']) ? $_POST['fldInstitutionAddressLine2'] : "";;
$INS3 = isset($_POST['fldInstitutionAddressLine3']) ? $_POST['fldInstitutionAddressLine3'] : "";;
$NAT = isset($_POST['fldNationality']) ? $_POST['fldNationality'] : "";;
$FATH = isset($_POST['fldFatherName']) ? $_POST['fldFatherName'] : "";;
$MOTH = isset($_POST['fldMotherName']) ? $_POST['fldMotherName'] : "";;
$SPO = isset($_POST['fldSpouseName']) ? $_POST['fldSpouseName'] : "";;
$RES = isset($_POST['fldResidenceNumber']) ? $_POST['fldResidenceNumber'] : "";;
$MOB = isset($_POST['fldMobileNumber']) ? $_POST['fldMobileNumber'] : "";;
$HGT = isset($_POST['fldHeight']) ? $_POST['fldHeight'] : "";;
$WGT = isset($_POST['fldWeight']) ? $_POST['fldWeight'] : "";;
$EMCN = isset($_POST['fldEmergencyContactName']) ? $_POST['fldEmergencyContactName'] : "";;
$EMCR = isset($_POST['fldEmergencyContactRelationship']) ? $_POST['fldemergencyContactRelationship'] : "";;
$EMC1 = isset($_POST['fldEmergencyContactAddressLine1']) ? $_POST['fldEmergencyContactAddressLine1'] : "";;
$EMC2 = isset($_POST['fldEmergencyContactAddressLine2']) ? $_POST['fldEmergencyContactAddressLine2'] : "";;
$EMC3 = isset($_POST['fldEmergencyContactAddressLine3']) ? $_POST['fldEmergencyContactAddressLine3'] : "";;
$DOC1 = isset($_POST['fldDoctorAddressLine1']) ? $_POST['fldDoctorAddressLine1'] : "";;
$DOC2 = isset($_POST['fldDoctorAddressLine2']) ? $_POST['fldDoctorAddressLine2'] : "";;
$DOC3 = isset($_POST['fldDoctorAddressLine3']) ? $_POST['fldDoctorAddressLine3'] : "";;
$MED1 = isset($_POST['fldMedicalFitness1']) ? $_POST['fldMedicalFitness1'] : "";;
$MED2 = isset($_POST['fldMedicalFitness2']) ? $_POST['fldMedicalFitness2'] : "";;
$MED3 = isset($_POST['fldMedicalFitness3']) ? $_POST['fldMedicalFitness3'] : "";;
$COMP = isset($_POST['fldCompetitions']) ? $_POST['fldCompetitions'] : "";;


mysql_connect("localhost", "root", "rama1991") or die('Error:' .mysql_error());
mysql_select_db("serp");

$query="INSERT INTO tblSwimmer (fldSwimmerName,fldAge,fldDateOfBirth,fldPresentAddressLine1,fldPresentAddressLine2,fldPresentAddressLine3,fldPermanentAddressLine1,fldPermanentAddressLine2,fldPermanentAddressLine3,fldInstitutionAddressLine1,fldInstitutionAddressLine2,fldInstitutionAddressLine3,fldNationality,fldFatherName,fldMotherName,fldSpouseName,fldResidenceNumber,fldMobileNumber,fldHeight,fldWeight,fldEmergencyContactName,fldEmergencyContactRelationship,fldEmergencyContactAddressLine1,fldEmergencyContactAddressLine2,fldEmergencyContactAddressLine3,fldDoctorAddressLine1,fldDoctorAddressLine2,fldDoctorAddressLine3,fldMedicalFitness1,fldMedicalFitness2,fldMedicalFitness3,fldCompetitions)VALUES ('".$SNAME."', '".$AGE."','".$DOB."','".$PRES1."','".$PRES2."','".$PRES3."','".$PERM1."','".$PERM2."','".$PERM3."','".$INS1."','".$INS2."','".$INS3."','".$NAT."','".$FATH."','".$MOTH."','".$SPO."','".$RES."','".$MOB."','".$HGT."','".$WGT."','".$EMCN."','".$EMCR."','".$EMC1."','".$EMC2."','".$EMC3."','".$DOC1."','".$DOC2."','".$DOC3."','".$MED1."','".$MED2."','".$MED3."','".$COMP."')";
mysql_query($query) or die('Error updating database');


echo "Database updated succesfully...";

?>

Re: Please Help me with this code...

Posted: Wed Jan 18, 2012 9:04 am
by Celauran
Please wrap your code in syntax tags as it's currently an unreadable mess. At least while you're in the development stage, I'd replace die('Error updating database') with something more meaningful.

Code: Select all

$result = mysql_query($query) or die("Error: " . mysql_error());

Re: Please Help me with this code...

Posted: Wed Jan 18, 2012 11:32 am
by twinedev
Well, could be that you are submitting something with a quote, and since you are not protecting against SQL injection it was crashing it out.

Try the following:

Code: Select all

<?php

if (count($_POST)>0) {
	$aryData = array(
		'fldSwimmerName'=>'',
		'fldAge'=>'',
		'fldDateOfBirth'=>'',
		'fldPresentAddressLine1'=>'',
		'fldPresentAddressLine2'=>'',
		'fldPresentAddressLine3'=>'',
		'fldPermanentAddressLine1'=>'',
		'fldPermanentAddressLine2'=>'',
		'fldPermanentAddressLine3'=>'',
		'fldInstitutionAddressLine1'=>'',
		'fldInstitutionAddressLine2'=>'',
		'fldInstitutionAddressLine3'=>'',
		'fldNationality'=>'',
		'fldFatherName'=>'',
		'fldMotherName'=>'',
		'fldSpouseName'=>'',
		'fldResidenceNumber'=>'',
		'fldMobileNumber'=>'',
		'fldHeight'=>'',
		'fldWeight'=>'',
		'fldEmergencyContactName'=>'',
		'fldEmergencyContactRelationship'=>'',
		'fldEmergencyContactAddressLine1'=>'',
		'fldEmergencyContactAddressLine2'=>'',
		'fldEmergencyContactAddressLine3'=>'',
		'fldDoctorAddressLine1'=>'',
		'fldDoctorAddressLine2'=>'',
		'fldDoctorAddressLine3'=>'',
		'fldMedicalFitness1'=>'',
		'fldMedicalFitness2'=>'',
		'fldMedicalFitness3'=>'',
		'fldCompetitions'=>''
	);
	$aryErr = array();

	foreach($aryData as $key=>$val) {
		if (isset($_POST[$key])) {
			$aryData[$key] = trim($_POST[$key]);
		}
	}

	// DO ANY VALIDATION HERE.....

	if ((int)$aryData['fldAge'] < 1 || (int)$aryData['fldAge']  > 140) {
		$aryErr['fldAge'] = 'Invlaid age entered';
	}

	if (count($aryErr)==0) {
		// All validation passed

		mysql_connect("localhost", "root", "rama1991")
			or die('Could not connect to database server');

		mysql_select_db("serp")
			or die('Could not use the specified database');

		$SQL1 = 'INSERT INTO `tblSwimmer` (';
		$SQL2 = ') VALUES (';

		foreach($aryData as $key=>$val) {
			$SQL1 .= '`'.$key.'`,';
			$SQL2 .= '"'.mysql_real_escape_string($val).'",';
		}

		mysql_query(substr($SQL1,0,-1).substr($SQL2,0,-1).')')
			or die ('Error running query: '.mysql_errno());

		echo 'Updated Database';
	}
	else {
		echo "There was an error with the data submited:<br>\n";
		echo implode("<br>\n",$aryErr);
	}
}
else {
	echo "You didn't submit anything...";
}

?>