Code efficiency review

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
User avatar
nigma
DevNet Resident
Posts: 1094
Joined: Sat Jan 25, 2003 1:49 am

Code efficiency review

Post by nigma »

Hey,

I have a few scripts that I am working on, obviously they have been written in PHP, but I am looking for some feedback on how some of the tasks that are performed inside these scripts can be re-written more efficiently.

One of the pages I would like some feedback on is an index page that basically includes another page based on the URL.
Example URL: index.php?p=contact
Example Action: include the page that corresponds with the key of an array with the value "contact"

I won't post any of the code until I get the feeling some people would check it out.

To any moderators / admins who may come accross this post I did have trouble deciding whether this should go in the Project Help forum or this one, but since others might benefit from the reviews I thought it be best if it goes here.
User avatar
Derfel Cadarn
Forum Contributor
Posts: 193
Joined: Thu Jul 17, 2003 12:02 pm
Location: Berlin, Germany

Post by Derfel Cadarn »

One of the pages I would like some feedback on is an index page that basically includes another page based on the URL.
Example URL: index.php?p=contact
Example Action: include the page that corresponds with the key of an array with the value "contact"

I won't post any of the code until I get the feeling some people would check it out.
So, what DO you want? You didn't give an url to check out and you don't want to give some code untill we 'promise' to rewrite your code for you?
:evil:
That isn't how it works around here, you should have known that by now :twisted:
Post Reply