[SOLVED] Form error in code

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
RainbowDesign
Forum Newbie
Posts: 3
Joined: Fri Oct 01, 2004 9:37 pm

[SOLVED] Form error in code

Post by RainbowDesign »

Warning: mail() expects at most 5 parameters, 8 given in /home/rainmcom/public_html/sendmail.php on line 10

Warning: Cannot modify header information - headers already sent by (output started at /home/rainmcom/public_html/sendmail.php:10) in /home/rainmcom/public_html/sendmail.php on line 11


I have made a form on my site using php.

I used this tutorial: http://www.thesitewizard.com/archive/feedbackphp.shtml

it worked wonders until I edited it: now I get the above error. this is my php code:

Code: Select all

<?php
PHP Code:
<? 
  $email = $_REQUEST['visitor_email_address1'] ; 
  $name = $_REQUEST['visitor_name1'] ; 
  $url = $_REQUEST['visitor_web_address'] ; 
  $priority = $_REQUEST['priority'] ; 
  $answer = $_REQUEST['answer'] ; 
  $Comment = $_REQUEST['Comment'] ; 

mail( "webmaster@rainbowsitedesi  gn.com", "FAQ form", 
    $name, $url, $priority, $answer, $Comment, "From: $email" ); 
  header( "Location: http://www.rainbowsitedesign.com  /thankyou.htm" ); 
?> 
?>
the actual form code is:


Code:

Code: Select all

&lt;form method="post" action="sendmail.php"&gt;
                  
&lt;P&gt;&lt;TABLE BORDER=0 CELLSPACING=0&gt; 

&lt;TR&gt;

&lt;TD WIDTH=116&gt;

&lt;p&gt;Your name:&lt;/p&gt;

&lt;/TD&gt;&lt;TD&gt;

&lt;INPUT TYPE="text" NAME="visitor_name1" VALUE="" SIZE=50&gt;

&lt;/TD&gt;&lt;/TR&gt;

&lt;TR&gt;

&lt;TD WIDTH=116&gt;
&lt;br&gt;
&lt;p&gt;Email address:&lt;p&gt;

&lt;/TD&gt;&lt;TD&gt;
&lt;br&gt;
&lt;INPUT TYPE="text" NAME="visitor_email_address1" VALUE=""

SIZE=50&gt;&lt;/H4&gt;

&lt;/TD&gt;&lt;/TR&gt;

&lt;tr&gt;

&lt;TD WIDTH=116&gt;

Your url:

&lt;/TD&gt;&lt;TD&gt;

&lt;br&gt;&lt;INPUT TYPE="text" NAME="visitor_web_address" VALUE=""

SIZE=50&gt;

&lt;/TD&gt;
&lt;/tr&gt;

&lt;/TABLE&gt;
&lt;br&gt;&lt;br&gt;
&lt;p&gt;How high of a priority is your question?&lt;/p&gt;

&lt;P&gt;&lt;INPUT TYPE="radio" NAME="priority" VALUE="low"&gt;low&lt;BR&gt;

&lt;INPUT TYPE="radio" NAME="priority?"

VALUE="medium"&gt;medium&lt;BR&gt;

&lt;INPUT TYPE="radio" NAME="priority" VALUE="high" 

CHECKED&gt;high&lt;BR&gt;

&lt;INPUT TYPE="radio" NAME="priority" VALUE="urgent"&gt;urgent

&lt;/P&gt;

&lt;br&gt;&lt;br&gt;

&lt;p&gt;How would you like us to answer your question?&lt;/p&gt;

&lt;P&gt;&lt;INPUT TYPE="checkbox" NAME="answer"

VALUE="email"&gt;Email&lt;BR&gt;

&lt;INPUT TYPE="checkbox" NAME="answer"

VALUE="faqpage"&gt;On the FAQ page&lt;BR&gt;

&lt;/P&gt;&lt;br&gt;&lt;br&gt;


&lt;p&gt;What is your question?&lt;/p&gt;

&lt;P&gt;&lt;TEXTAREA NAME="Comment" ROWS=5 COLS=50&gt;&lt;/TEXTAREA&gt;&lt;/P&gt;

&lt;br&gt;

&lt;P&gt;&lt;INPUT TYPE="submit" NAME="Submit" 

VALUE="Submit"&gt; &lt;INPUT TYPE="reset" VALUE="Reset"&gt; 

&lt;/FORM&gt;
the site it is on is http://www.rainbowsitedesign.com/faq.htm

what have I done wrong?
User avatar
nigma
DevNet Resident
Posts: 1094
Joined: Sat Jan 25, 2003 1:49 am

Post by nigma »

You passed too many arguments to the mail() function.
bool mail ( string to, string subject, string message [, string additional_headers [, string additional_parameters]])
What you probably want to do is put the variables $name, $url, $priority, $answer, and $Comment in the email message. You could put all of those variables into one $message var and then pass mail the $message variable:

Code: Select all

$message = "$name, $url, $priority, $answer, $Comment";
mail( "webmaster@rainbowsitedesi  gn.com", "FAQ form", $message,"From: $email" );
As for your headers already sent error, check out jasons tutorial on headers.
RainbowDesign
Forum Newbie
Posts: 3
Joined: Fri Oct 01, 2004 9:37 pm

Post by RainbowDesign »

Thankyou! That actually fixed everything! It all works perfectly.
User avatar
nigma
DevNet Resident
Posts: 1094
Joined: Sat Jan 25, 2003 1:49 am

Post by nigma »

You going to tell me what it was ?
RainbowDesign
Forum Newbie
Posts: 3
Joined: Fri Oct 01, 2004 9:37 pm

Post by RainbowDesign »

??
User avatar
nigma
DevNet Resident
Posts: 1094
Joined: Sat Jan 25, 2003 1:49 am

Post by nigma »

Ooops, sorry. After closely examining your post I understand what you did :oops:
Post Reply