Can someone please help me with this php code. Im new to php

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

Post Reply
tina
Forum Newbie
Posts: 4
Joined: Sat Nov 27, 2004 6:09 pm

Can someone please help me with this php code. Im new to php

Post by tina »

I keep getting an error saying. Parse error: parse error, unexpected $ in /home/singlesp/public_html/edit_profile.php on line 721 (last line)
A couple tags were uncomplete but I fixed them.
Ive tried everything I could think of. Here is the code.
<?
include ("sesiuni.php");
include ("config.php");
include ("functii_mail.php");
db_connect($dbserver,$dbuser,$dbpass,$dbname);

//variabile lang

include ($lang);
global $edit_profile_title;
if (is_banned($REMOTE_ADDR))
{
echo "IP banned!";
exit();
}
global $country_array,$zodia_array,$marital_status_array,$zile_array,$luna_array,$anul_array,$sex_array;
include ("sesiuni.php");

function setare ($id,$password,$email,$sex,$sexuality,$personal_ad,$location,$country,
$age ,$birth_date,$zodia,$marital_status,$eyes_colour,$hair_colour,$weight,
$music,$partner ,$question,$age_min,$age_max,$height )
{
$sql="update users set password='$password',email='$email',sex='$sex',sexuality='$sexuality',personal_ad='$personal_ad',
location='$location',country='$country',
age=$age ,birth_date='$birth_date',zodia='$zodia',marital_status='$marital_status',eyes_colour='$eyes_colour',hair_colour='$hair_colour',weight='$weight',
music='$music',partner='$partner' ,question='$question',height='$height' where id=$id ";
$res_logger = mysql_query ($sql);

if (!$res_logger)

{
echo "An error occured in the logger.: \n";
echo mysql_error();
return FALSE;
}
else
{
$sql="update match_finder set age_min=$age_min,age_max=$age_max where user_id=$id";
$res_logger = mysql_query ($sql);
if (!$res_logger)
{
echo "An error occured in the logger.: \n";
echo mysql_error();
return FALSE;
}
return true;

}

}
function password_check($password1,$password2)
{
if ($password1==$password2 )
{
return TRUE;
}
ELSE
{
return FALSE;
}

}
function email_check($email)
{
return TRUE;
}
if (isset($Submit))
{
if (password_check($password,$password1) &&email_check($email))
{
$birth_date=$ziua.'/'.$luna.'/'.$anul;
if (setare($usernick,$password,$email,$sex,$sexuality,$personal_ad,$location,$country,
$age ,$birth_date,$zodia,$marital_status,$eyes_colour,$hair_colour,$weight,
$music,$partner ,$question,$age_min,$age_max,$height ))
{
echo $edit_success;
//?><script>window.location="my_account.php"</script><?
}
}
}
$sql="SELECT * FROM users where id=$usernick order by data desc ";
$result=mysql_query($sql);
$num=mysql_numrows($result);
if ($num<>0)
{
$password=mysql_result($result,0,"password");
$nick=mysql_result($result,0,"nick");
$data=mysql_result($result,0,"data");
$email=mysql_result($result,0,"email");
$sex=mysql_result($result,0,"sex");
$sexuality=mysql_result($result,0,"sexuality");
$personal_ad=mysql_result($result,0,"personal_ad");
$location=mysql_result($result,0,"location");
$country=mysql_result($result,0,"country");
$age=mysql_result($result,0,"age");
$birth_date=mysql_result($result,0,"birth_date");
$zodia=mysql_result($result,0,"zodia");
$marital_status=mysql_result($result,0,"marital_status");
$eyes_colour=mysql_result($result,0,"eyes_colour");
$hair_colour=mysql_result($result,0,"hair_colour");
$weight=mysql_result($result,0,"weight");
$music=mysql_result($result,0,"music");
$partner=mysql_result($result,0,"partner");
$question=mysql_result($result,0,"question");
$data_nast=explode("/",$birth_date);
$ziua=$data_nast[0];
$luna=$data_nast[1];
$anul=$data_nast[2];

}
$sql="SELECT age_min,age_max FROM match_finder where user_id=$usernick ";
$result=mysql_query($sql);
$num=mysql_numrows($result);
if ($num<>0)
{
$age_min=mysql_result($result,0,"age_min");
$age_max=mysql_result($result,0,"age_max");
}
else
$age_min=$age_array[0];
$age_max=$age_array[0];


?>

<?php include("header.php"); ?>
<br>
<font size="5" face="Verdana, Arial, Helvetica, sans-serif"><strong>Edit Profile </strong></font><br>



<form name="form1" method="post" action="edit_profile.php">
<p> <br>
<br>
<br>
</p>
<?echo $nume_users.":".$nick?>
<form action="edit_profile.php" onSubmit="MM_validateForm('email','','NisEmail','password','','R','password1','','R');return document.MM_returnValue">
<table width="450" border="0" cellspacing="0" cellpadding="1">
<tr>
<td><?echo $password_text?></td>
<td><input name="password" type="password" id="password" value="<?=$password?>"></td>
</tr>
<tr>
<td><?echo $password_text?></td>
<td><input name="password1" type="password" id="password1" ></td>
</tr>
<tr>
<td><?echo $email_text?></td>
<td><input name="email" type="text" id="email" value="<?=$email?>"?></td>
</tr><tr>
<td><?echo $sex_text?></td><td><select name="sex" id="sex">
<?
for ($i=0;$i<count($sex_array);$i++)
{
?>
<option value="<?echo $sex_array[$i];
if ($sex_array[$i]==$sex)
{
echo '"selected>'.$sex_array[$i].'</option> ';
}
else
{
echo '">'.$sex_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $sexuality_text?></td>
<td><select name=" sexuality" id="sexuality">'.$sex_array[$i].'</option> ';
}
else
{
echo '">'.$sex_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $sexuality_text?></td>
<td><select name="sexuality" id="sexuality"></td>
<?
for ($i=0;$i<count($sexuality_array);$i++)
{
?>
<option value="<?echo $sexuality_array[$i];
if ($sexuality_array[$i]==$sexuality)
{
echo '"selected>'.$sexuality_array[$i].'</option> ';
}
else
{
echo '">'.$sexuality_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $personal_ad_text?></td>
<td><textarea name=" personal_ad" id="personal_ad">'.$sexuality_array[$i].'</option> ';
}
else
{
echo '">'.$sexuality_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $personal_ad_text?></td>
<td><textarea name="personal_ad" id="personal_ad">
<?=$personal_ad?></textarea></td></tr><tr><td>
<?echo $location_text?></td> <td>
<input name="location" type="text" id="location"value="<?=$location?>"?></td> </tr><tr><td>
<?echo $country_text?></td> <td><select name="country" size="1" id="country">
<?
for ($i=0;$i<count($country_array);$i++)
{
?>
<option value="<?echo $country_array[$i];
if ($country_array[$i]==$country)
{
echo '"selected>'.$country_array[$i].'</option> ';
}
else
{
echo '">'.$country_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $age_text?></td>
<td><select name=" age" id="age">'.$country_array[$i].'</option> ';
}
else
{
echo '">'.$country_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $age_text?></td>
<td><select name="age" id="age">
<?
for ($i=0;$i<count($age_array);$i++)
{
?>
<option value="<?echo $age_array[$i];
if ($age_array[$i]==$age)
{
echo '"selected>'.$age_array[$i].'</option> ';
}
else
{
echo '">'.$age_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $birth_date_text?></td>
<td><select name=" ziua" id="ziua">'.$age_array[$i].'</option> ';
}
else
{
echo '">'.$age_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $birth_date_text?></td>
<td><select name="ziua" id="ziua">
<?
for ($i=0;$i<count($zile_array);$i++)
{
?>
<option value="<?echo $zile_array[$i];
if ($zile_array[$i]==$ziua)
{
echo '"selected>'.$zile_array[$i].'</option> ';
}
else
{
echo '">'.$zile_array[$i].'</option> ';
}
}
?>
</select>

<select name=" luna" id="luna">'.$zile_array[$i].'</option> ';
}
else
{
echo '">'.$zile_array[$i].'</option> ';
}
}
?>
</select>

<select name="luna" id="luna">
<?
for ($i=0;$i<count($luna_array);$i++)
{
?>
<option value="<?echo $luna_array[$i];
if ($luna_array[$i]==$luna)
{
echo '"selected>'.$luna_array[$i].'</option> ';
}
else
{
echo '">'.$luna_array[$i].'</option> ';
}
}
?>
</select>
<select name=" anul" id="anul">'.$luna_array[$i].'</option> ';
}
else
{
echo '">'.$luna_array[$i].'</option> ';
}
}
?>
</select>
<select name="anul" id="anul">
<?
for ($i=0;$i<count($anul_array);$i++)
{
?>
<option value="<?echo $anul_array[$i];
if ($anul_array[$i]==$anul)
{
echo '"selected>'.$anul_array[$i].'</option> ';
}
else
{
echo '">'.$anul_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>
<td><?echo $zodia_text?></td>
<td><select name=" zodia" id="zodia">'.$anul_array[$i].'</option> ';
}
else
{
echo '">'.$anul_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>
<td><?echo $zodia_text?></td>
<td><select name="zodia" id="zodia">
<?

for ($i=0;$i<count($zodia_array);$i++)
{
?>
<option value="<?echo $zodia_array[$i];
if ($zodia_array[$i]==$zodia)
{
echo '"selected>'.$zodia_array[$i].'</option> ';
}
else
{
echo '">'.$zodia_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $marital_status_text?></td>
<td><select name=" marital_status" id="marital_status">'.$zodia_array[$i].'</option> ';
}
else
{
echo '">'.$zodia_array[$i].'</option> ';
}
}
?>
</select>

</td>
</tr>
<tr>
<td><?echo $marital_status_text?></td>
<td><select name="marital_status" id="marital_status">
<?
for ($i=0;$i<count($marital_status_array);$i++)
{
?>
<option value="<?echo $marital_status_array[$i];
if ($marital_status_array[$i]==$marital_status)
{
echo '"selected>'.$marital_status_array[$i].'</option> ';
}
else
{
echo '">'.$marital_status_array[$i].'</option> ';
}
}
?>
</select>



</td>
</tr>
<tr>

<?echo $eyes_colour_text?></td> <td><select name=" eyes_colour" id="eyes_colour">'.$marital_status_array[$i].'</option> ';
}
else
{
echo '">'.$marital_status_array[$i].'</option> ';
}
}
?>
</select>



</td>
</tr>
<tr>

<td><?echo $eyes_colour_text?></td> <td><select name="eyes_colour" id="eyes_colour"></td>
<?
for ($i=0;$i<count($eyes_colour_array);$i++)
{
?>
<option value="<?echo $eyes_colour_array[$i];
if ($eyes_colour_array[$i]==$eyes_colour)
{
echo '"selected>'.$eyes_colour_array[$i].'</option> ';
}
else
{
echo '">'.$eyes_colour_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>

<td><?echo $hair_colour_text?></td>


<td><select name=" hair_colour" id="hair_colour">'.$eyes_colour_array[$i].'</option> ';
}
else
{
echo '">'.$eyes_colour_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>

<td><?echo $hair_colour_text?></td>


<td><select name="hair_colour" id="hair_colour"></select> </td>
<?
for ($i=0;$i<count($hair_colour_array);$i++)
{
?>
<option value="<?echo $hair_colour_array[$i];
if ($hair_colour_array[$i]==$hair_colour)
{
echo '"selected>'.$hair_colour_array[$i].'</option> ';
}
else
{
echo '">'.$hair_colour_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>
<td><?echo $weight_text?></td>
<td><select name=" weight" id="weight">'.$hair_colour_array[$i].'</option> ';
}
else
{
echo '">'.$hair_colour_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>
<td><?echo $weight_text?></td>
<td><select name="weight" id="weight">
<?
for ($i=0;$i<count($weight_array);$i++)
{
?>
<option value="<?echo $weight_array[$i];
if ($weight_array[$i]==$weight)
{
echo '"selected>'.$weight_array[$i].'</option> ';
}
else
{
echo '">'.$weight_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>
<td><?echo $height_text?></td>
<td><select name=" height" id="height">'.$weight_array[$i].'</option> ';
}
else
{
echo '">'.$weight_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>
<td><?echo $height_text?></td>
<td><select name="height" id="height">
<?
for ($i=0;$i<count($height_array);$i++)
{
?>
<option value="<?echo $height_array[$i];
if ($height_array[$i]==$height)
{
echo '"selected>'.$height_array[$i].'</option> ';
}
else
{
echo '">'.$height_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>

<tr>
<td><?echo $music_text?></td>
<td><select name=" music" id="music">'.$height_array[$i].'</option> ';
}
else
{
echo '">'.$height_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>

<tr>
<td><?echo $music_text?></td>
<td><select name="music" id="music">
<?
for ($i=0;$i<count($music_array);$i++)
{
?>
<option value="<?echo $music_array[$i];
if ($music_array[$i]==$music)
{
echo '"selected>'.$music_array[$i].'</option> ';
}
else
{
echo '">'.$music_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>
<td><?echo $partner_text?></td>
<td><textarea name=" partner" cols="40" id="partner">'.$music_array[$i].'</option> ';
}
else
{
echo '">'.$music_array[$i].'</option> ';
}
}
?>
</select>
</td>
</tr>
<tr>
<td><?echo $partner_text?></td>
<td><textarea name="partner" cols="40" id="partner">
<?=$partner?></textarea></td></tr><tr><td>
<?echo $question_text?></td> <td>
<textarea name="question" cols="40" id="question"><?=$question?></textarea></td></tr><tr><td>
<?echo $age_min_text?> </td> <td> <select name="age_min" id="age_min">
<?
for ($i=0;$i<count($age_array);$i++)
{
?>
<option value="<?echo $age_array[$i];
if ($age_array[$i]==$age_min)
{
echo '"selected>'.$age_array[$i].'</option> ';
}
else
{
echo '">'.$age_array[$i].'</option> ';
}
}
?>
</select>

<?echo $age_max_text?>
<select name=" age_max" id="age_max">'.$age_array[$i].'</option> ';
}
else
{
echo '">'.$age_array[$i].'</option> ';
}
}
?>
</select>

<?echo $age_max_text?>
<select name="age_max" id="age_max">
<?
for ($i=0;$i<count($age_array);$i++)
{
?>
<option value="<?echo $age_array[$i];
if ($age_array[$i]==$age_max)
{
echo '"selected>'.$age_array[$i].'</option> ';
}
else
{
echo '">'.$age_array[$i].'</option> ';
}
}
echo "<br>".$age_min_text .$age_min.$age_max_text.$age_max;
?>
</select>

</td>
</tr>
<tr>
<td colspan=" 2">'.$age_array[$i].'</option> ';
}
else
{
echo '">'.$age_array[$i].'</option> ';
}
}
echo "<br>".$age_min_text .$age_min.$age_max_text.$age_max;
?>
</select>

</td>
</tr>
<tr>
<td colspan="2"><div align="center"><input type="submit" name="Submit" value="Submit" ></div></td></tr><tr><td>&nbsp;</td><td>&nbsp;</td></tr>
</table>
</form>

<?php include("footer.php");?>

<?
mysql_close();
?>
User avatar
hawleyjr
BeerMod
Posts: 2170
Joined: Tue Jan 13, 2004 4:58 pm
Location: Jax FL & Spokane WA USA

Post by hawleyjr »

Please use the PHP Tags when posting code.

I did a quick check you have 78 open brackets { and 110 closed brackets } I'd start there and make sure every open bracket has a closed one.
kettle_drum
DevNet Resident
Posts: 1150
Joined: Sun Jul 20, 2003 9:25 pm
Location: West Yorkshire, England

Post by kettle_drum »

Is there any php code in footer.php?

And use the [ code ] and [ php ] tags next time so the moderators dont give you a telling off.
rehfeld
Forum Regular
Posts: 741
Joined: Mon Oct 18, 2004 8:14 pm

Post by rehfeld »

did this ever work?

if so, go back to how it was before you modified it and make changes 1 step a a time.

the error you described means somewhere in that code you prob forgot to close quote, but it could be other things too.

i dont have time to look through 700 lines of code, and to be honest, youd be lucky if someone on this board is willing to....sorry.

you have a better chance of getting help if you post your code inside

Code: Select all

tags so that it is formatted and highlighted like most other posts on this board(its easier to read). in fact, when the code is highlighted this problem might be easy to spot.
tina
Forum Newbie
Posts: 4
Joined: Sat Nov 27, 2004 6:09 pm

thanks for the quick responce....

Post by tina »

How do i post it in php tags?
I did change one thing and that fixed how its suppose to look. Half of it was missing till I closed one of the tags. Its an edit profile page.
[/php_man]
rehfeld
Forum Regular
Posts: 741
Joined: Mon Oct 18, 2004 8:14 pm

Post by rehfeld »

tina
Forum Newbie
Posts: 4
Joined: Sat Nov 27, 2004 6:09 pm

I hope I did this right, thanks....

Post by tina »

Code: Select all

<?php

</script>
<body> 
<?
include ("sesiuni.php");
include ("config.php");
include ("functii_mail.php");
 db_connect($dbserver,$dbuser,$dbpass,$dbname);

//variabile lang

 include ($lang);
 global $edit_profile_title;
 if (is_banned($REMOTE_ADDR))
{
echo "IP banned!";
exit();
}
 global $country_array,$zodia_array,$marital_status_array,$zile_array,$luna_array,$anul_array,$sex_array;
include ("sesiuni.php");

function   setare ($id,$password,$email,$sex,$sexuality,$personal_ad,$location,$country,
$age ,$birth_date,$zodia,$marital_status,$eyes_colour,$hair_colour,$weight,
$music,$partner ,$question,$age_min,$age_max,$height )
{
$sql="update users set password='$password',email='$email',sex='$sex',sexuality='$sexuality',personal_ad='$personal_ad',
location='$location',country='$country',
age=$age ,birth_date='$birth_date',zodia='$zodia',marital_status='$marital_status',eyes_colour='$eyes_colour',hair_colour='$hair_colour',weight='$weight',
music='$music',partner='$partner' ,question='$question',height='$height' where id=$id ";
$res_logger = mysql_query ($sql);

if (!$res_logger)

{
 echo "An error occured in the logger.: \n";
 echo  mysql_error();
 return FALSE;
}
 else
{
 $sql="update match_finder set age_min=$age_min,age_max=$age_max where user_id=$id";
 $res_logger = mysql_query ($sql);
 if (!$res_logger)
 {
 echo "An error occured in the logger.: \n";
 echo  mysql_error();
 return FALSE;
 }
 return true;

}

}
function password_check($password1,$password2)
{
 if ($password1==$password2 )
  {
  return TRUE;
  }
  ELSE
  {
  return FALSE;
  }

}
function email_check($email)
{
return TRUE;
}
if (isset($Submit))
{
 if (password_check($password,$password1) &&email_check($email))
 {
 $birth_date=$ziua.'/'.$luna.'/'.$anul;
 if (setare($usernick,$password,$email,$sex,$sexuality,$personal_ad,$location,$country,
 $age ,$birth_date,$zodia,$marital_status,$eyes_colour,$hair_colour,$weight,
 $music,$partner ,$question,$age_min,$age_max,$height ))
  {
     echo $edit_success;
//?><script>window.location="my_account.php"</script><?
  }
 }
}
 $sql="SELECT * FROM users where id=$usernick order by data desc ";
 $result=mysql_query($sql);
 $num=mysql_numrows($result);
 if ($num<>0)
 {
    $password=mysql_result($result,0,"password");
    $nick=mysql_result($result,0,"nick");
    $data=mysql_result($result,0,"data");
    $email=mysql_result($result,0,"email");
    $sex=mysql_result($result,0,"sex");
    $sexuality=mysql_result($result,0,"sexuality");
    $personal_ad=mysql_result($result,0,"personal_ad");
    $location=mysql_result($result,0,"location");
    $country=mysql_result($result,0,"country");
    $age=mysql_result($result,0,"age");
    $birth_date=mysql_result($result,0,"birth_date");
    $zodia=mysql_result($result,0,"zodia");
    $marital_status=mysql_result($result,0,"marital_status");
    $eyes_colour=mysql_result($result,0,"eyes_colour");
    $hair_colour=mysql_result($result,0,"hair_colour");
    $weight=mysql_result($result,0,"weight");
    $music=mysql_result($result,0,"music");
    $partner=mysql_result($result,0,"partner");
    $question=mysql_result($result,0,"question");
    $data_nast=explode("/",$birth_date);
    $ziua=$data_nast[0];
    $luna=$data_nast[1];
    $anul=$data_nast[2];

  }
 $sql="SELECT age_min,age_max FROM match_finder where user_id=$usernick  ";
 $result=mysql_query($sql);
 $num=mysql_numrows($result);
 if ($num<>0)
 {
    $age_min=mysql_result($result,0,"age_min");
    $age_max=mysql_result($result,0,"age_max");
 }
 else
 $age_min=$age_array[0];
 $age_max=$age_array[0];


?>

<?php include("header.php"); ?>
<br>
<font size= 5></font> <font face="Verdana, Arial, Helvetica, sans-serif"><strong>Edit Profile </strong></font>



<form> <name="form1" method="post" action="edit_profile.php"></form> 
    <p> <br>
      <br>
      <br>
    </p>
    <?echo $nume_users.":".$nick?> 
    <form> <action="edit_profile.php" onSubmit="MM_validateForm('email','','NisEmail','password','','R','password1','','R');return document.MM_returnValue">
      <table width="450" border="0" cellspacing="0" cellpadding="1">
        <tr> 
          <td><?echo $password_text?></td>
          <td><input name="password" type="password" id="password" value="<?=$password?>"></td>
        </tr>
        <tr> 
          <td><?echo $password_text?></td>
          <td><input name="password1" type="password" id="password1" ></td>
        </tr>
        <tr> 
          <td><?echo $email_text?></td>
          <td><input name="email" type="text" id="email" value="<?=$email?>"?></td>
        </tr><tr>
        <td><?echo $sex_text?></td><td><select name="sex" id="sex">
        <?
          for ($i=0;$i<count($sex_array);$i++)
          {
          ?>
        <option value="<?echo $sex_array[$i];
          if ($sex_array[$i]==$sex)
          {
          echo '"selected>'.$sex_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$sex_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $sexuality_text?></td>
      <td><select name=" sexuality" id="sexuality">'.$sex_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$sex_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $sexuality_text?></td>
      <td><select name="sexuality" id="sexuality"></td> 
        <?
          for ($i=0;$i<count($sexuality_array);$i++)
          {
          ?>
        <option value="<?echo $sexuality_array[$i];
          if ($sexuality_array[$i]==$sexuality)
          {
          echo '"selected>'.$sexuality_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$sexuality_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $personal_ad_text?></td>
      <td><textarea name=" personal_ad" id="personal_ad">'.$sexuality_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$sexuality_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $personal_ad_text?></td>
      <td><textarea name="personal_ad" id="personal_ad"> 
        <?=$personal_ad?></textarea></td></tr><tr><td>
        <?echo $location_text?></td> <td>
			<input name="location" type="text" id="location"value="<?=$location?>"?></td> </tr><tr><td>
        <?echo $country_text?></td> <td><select name="country" size="1" id="country"> 
        <?
          for ($i=0;$i<count($country_array);$i++)
          {
          ?>
        <option value="<?echo $country_array[$i];
          if ($country_array[$i]==$country)
          {
          echo '"selected>'.$country_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$country_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $age_text?></td>
      <td><select name=" age" id="age">'.$country_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$country_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $age_text?></td>
      <td><select name="age" id="age"> 
        <?
          for ($i=0;$i<count($age_array);$i++)
          {
          ?>
        <option value="<?echo $age_array[$i];
          if ($age_array[$i]==$age)
          {
          echo '"selected>'.$age_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$age_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $birth_date_text?></td>
      <td><select name=" ziua" id="ziua">'.$age_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$age_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $birth_date_text?></td>
      <td><select name="ziua" id="ziua"> 
        <?
          for ($i=0;$i<count($zile_array);$i++)
          {
          ?>
        <option value="<?echo $zile_array[$i];
          if ($zile_array[$i]==$ziua)
          {
          echo '"selected>'.$zile_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$zile_array[$i].'</option> ';
          }
          }
          ?>
      </select>

 <select name=" luna" id="luna">'.$zile_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$zile_array[$i].'</option> ';
          }
          }
          ?>
      </select>

 <select name="luna" id="luna"> 
        <?
          for ($i=0;$i<count($luna_array);$i++)
          {
          ?>
        <option value="<?echo $luna_array[$i];
          if ($luna_array[$i]==$luna)
          {
          echo '"selected>'.$luna_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$luna_array[$i].'</option> ';
          }
          }
          ?>
      </select>
 <select name=" anul" id="anul">'.$luna_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$luna_array[$i].'</option> ';
          }
          }
          ?>
      </select>
 <select name="anul" id="anul"> 
        <?
          for ($i=0;$i<count($anul_array);$i++)
          {
          ?>
        <option value="<?echo $anul_array[$i];
          if ($anul_array[$i]==$anul)
          {
          echo '"selected>'.$anul_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$anul_array[$i].'</option> ';
          }
          }
          ?>
      </select>
 </td>
    </tr>
    <tr>
      <td><?echo $zodia_text?></td>
      <td><select name=" zodia" id="zodia">'.$anul_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$anul_array[$i].'</option> ';
          }
          }
          ?>
      </select>
 </td>
    </tr>
    <tr>
      <td><?echo $zodia_text?></td>
      <td><select name="zodia" id="zodia"> 
        <?

          for ($i=0;$i<count($zodia_array);$i++)
          {
          ?>
        <option value="<?echo $zodia_array[$i];
          if ($zodia_array[$i]==$zodia)
          {
          echo '"selected>'.$zodia_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$zodia_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $marital_status_text?></td>
      <td><select name=" marital_status" id="marital_status">'.$zodia_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$zodia_array[$i].'</option> ';
          }
          }
          ?>
      </select>

      </td>
    </tr>
    <tr>
      <td><?echo $marital_status_text?></td>
      <td><select name="marital_status" id="marital_status"> 
        <?
          for ($i=0;$i<count($marital_status_array);$i++)
          {
          ?>
		<option value="<?echo $marital_status_array[$i];
          if ($marital_status_array[$i]==$marital_status)
          {
          echo '"selected>'.$marital_status_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$marital_status_array[$i].'</option> ';
          }
          }
          ?>
      </select>



      </td>
    </tr>
    <tr>
      
        <?echo $eyes_colour_text?></td> <td><select name=" eyes_colour" id="eyes_colour">'.$marital_status_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$marital_status_array[$i].'</option> ';
          }
          }
          ?>
      </select>



      </td>
    </tr>
    <tr>
      
        <td><?echo $eyes_colour_text?></td> <td><select name="eyes_colour" id="eyes_colour"></td> 
        <?
          for ($i=0;$i<count($eyes_colour_array);$i++)
          {
          ?>
        <option value="<?echo $eyes_colour_array[$i];
          if ($eyes_colour_array[$i]==$eyes_colour)
          {
          echo '"selected>'.$eyes_colour_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$eyes_colour_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>
    <tr>

      <td><?echo $hair_colour_text?></td>


      <td><select name=" hair_colour" id="hair_colour">'.$eyes_colour_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$eyes_colour_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>
    <tr>

      <td><?echo $hair_colour_text?></td>


      <td><select name="hair_colour" id="hair_colour"></select> </td> 
        <?
          for ($i=0;$i<count($hair_colour_array);$i++)
          {
          ?>
        <option value="<?echo $hair_colour_array[$i];
          if ($hair_colour_array[$i]==$hair_colour)
          {
          echo '"selected>'.$hair_colour_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$hair_colour_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>
    <tr>
      <td><?echo $weight_text?></td>
      <td><select name=" weight" id="weight">'.$hair_colour_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$hair_colour_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>
    <tr>
      <td><?echo $weight_text?></td>
      <td><select name="weight" id="weight"> 
        <?
          for ($i=0;$i<count($weight_array);$i++)
          {
          ?>
        <option value="<?echo $weight_array[$i];
          if ($weight_array[$i]==$weight)
          {
          echo '"selected>'.$weight_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$weight_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>
    <tr>
      <td><?echo $height_text?></td>
      <td><select name=" height" id="height">'.$weight_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$weight_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>
    <tr>
      <td><?echo $height_text?></td>
      <td><select name="height" id="height"> 
        <?
          for ($i=0;$i<count($height_array);$i++)
          {
          ?>
        <option value="<?echo $height_array[$i];
          if ($height_array[$i]==$height)
          {
          echo '"selected>'.$height_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$height_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>

    <tr>
      <td><?echo $music_text?></td>
      <td><select name=" music" id="music">'.$height_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$height_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>

    <tr>
      <td><?echo $music_text?></td>
      <td><select name="music" id="music"> 
        <?
          for ($i=0;$i<count($music_array);$i++)
          {
          ?>
        <option value="<?echo $music_array[$i];
          if ($music_array[$i]==$music)
          {
          echo '"selected>'.$music_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$music_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>
    <tr>
      <td><?echo $partner_text?></td>
      <td><textarea name=" partner" cols="40" id="partner">'.$music_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$music_array[$i].'</option> ';
          }
          }
          ?>
      </select>
      </td>
    </tr>
    <tr>
      <td><?echo $partner_text?></td>
      <td><textarea name="partner" cols="40" id="partner"> 
        <?=$partner?></textarea></td></tr><tr><td>
        <?echo $question_text?></td> <td> 
        <textarea name="question" cols="40" id="question"><?=$question?></textarea></td></tr><tr><td>
        <?echo $age_min_text?> </td> <td> <select name="age_min" id="age_min"> 
        <?
          for ($i=0;$i<count($age_array);$i++)
          {
          ?>
		<option value="<?echo $age_array[$i];
          if ($age_array[$i]==$age_min)
          {
          echo '"selected>'.$age_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$age_array[$i].'</option> ';
          }
          }
          ?>
      </select>

        <?echo $age_max_text?>
        <select name=" age_max" id="age_max">'.$age_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$age_array[$i].'</option> ';
          }
          }
          ?>
      </select>

        <?echo $age_max_text?>
        <select name="age_max" id="age_max">
        <?
          for ($i=0;$i<count($age_array);$i++)
          {
          ?>
		<option value="<?echo $age_array[$i];
          if ($age_array[$i]==$age_max)
          {
          echo '"selected>'.$age_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$age_array[$i].'</option> ';
          }
          }
        echo "<br>".$age_min_text .$age_min.$age_max_text.$age_max;
          ?>
      </select>

        </td>
    </tr>
    <tr>
      <td colspan=" 2">'.$age_array[$i].'</option> ';
          }
          else
          {
          echo '">'.$age_array[$i].'</option> ';
          }
          }
        echo .$age_min_text .$age_min.$age_max_text.$age_max;
          ?>
      </select>

        </td>
    </tr>
    <tr>
      <td colspan="2"><div align="center"><input type="submit" name="Submit" value="Submit" ></div></td></tr><tr><td>&nbsp;</td><td>&nbsp;</td></tr>
      </table>
    </form>
    
<?php include("footer.php");?>

<?
mysql_close();
?>
?>
User avatar
bluenote
Forum Commoner
Posts: 93
Joined: Sat Mar 01, 2003 4:59 am
Location: Heidelberg, Germany

Post by bluenote »

:twisted:

1. Read thoroughly : http://www.w3.org/TR/html4
2. Read thoroughly : http://de2.php.net/manual/en/

[AFTERWARDS]

3. Read the comments and fix the rest of your code for yourself:

Code: Select all

<?php

include ("sesiuni.php");
include ("config.php");
include ("functii_mail.php");

db_connect($dbserver,$dbuser,$dbpass,$dbname);

//variabile lang

include ($lang);

global $edit_profile_title;

/* 2004-11-28 $bluenote:
   This is not the cause-of-error,
   but you should use $_SERVER if
   you have not defined it elsewhere in your includes */

if (is_banned($_SERVER['REMOTE_ADDR'])) {

echo "IP banned!";

exit();}

global $country_array,$zodia_array,$marital_status_array,$zile_array,$luna_array,$anul_array,$sex_array;

/* 2004-11-28 $bluenote:
   Do you really need to include this twice? */

include ("sesiuni.php");

function setare ($id,$password,$email,$sex,$sexuality,$personal_ad,$location,$country,
$age ,$birth_date,$zodia,$marital_status,$eyes_colour,$hair_colour,$weight,
$music,$partner ,$question,$age_min,$age_max,$height ) {
	
/* 2004-11-28 $bluenote:
   Rename the $sql
   to avaoid collisions with the next one */
	
$sql_01 = "UPDATE users SET password='$password',email='$email',sex='$sex',sexuality='$sexuality',personal_ad='$personal_ad',
location='$location',country='$country',
age=$age ,birth_date='$birth_date',zodia='$zodia',marital_status='$marital_status',eyes_colour='$eyes_colour',hair_colour='$hair_colour',weight='$weight',
music='$music',partner='$partner' ,question='$question',height='$height' WHERE id=$id ";

/* 2004-11-28 $bluenote:
   Rename & Expand the $res_logger
   to avaoid collisions with the next one */

$res_logger_01 = mysql_query ($sql_02) or die(mysql_error());

if (!$res_logger_01) {
	
echo "An error occured in the logger.: \n";
echo mysql_error();
return FALSE;}

else {
	
$sql_02="update match_finder set age_min=$age_min,age_max=$age_max where user_id=$id";
$res_logger_02 = mysql_query ($sql_02) or die(mysql_error());

if (!$res_logger_02) {
	
echo "An error occured in the logger.: \n";
echo mysql_error();
return FALSE;}

return true;}}

/* 2004-11-28 $bluenote:
   Code error-free up to line 68 */

function password_check($password1,$password2) {
	
/* 2004-11-28 $bluenote:
   Passwords should exactly match
   use the '===' (Identical) instead of the '==' (Equal) operator */
	
if ($password1==$password2 ) {
	
return TRUE;}

else {
	
return FALSE;}}

/* 2004-11-28 $bluenote:
   Code error-free up to line 86 */

function email_check($email) {
	
return TRUE;}

if (isset($Submit)) {
	
if (password_check($password,$password1) &&email_check($email)) {
	
$birth_date=$ziua.'/'.$luna.'/'.$anul;

if (setare($usernick,$password,$email,$sex,$sexuality,$personal_ad,$location,$country,
$age ,$birth_date,$zodia,$marital_status,$eyes_colour,$hair_colour,$weight,
$music,$partner ,$question,$age_min,$age_max,$height )) {
	
echo $edit_success;

//?>

<script>window.location="my_account.php"</script>

<?

}}}

/* 2004-11-28 $bluenote:
   Code error-free up to line 113 */

/* 2004-11-28 $bluenote:
   If the query can only have one result, use
   this syntax instead */
   
$sql="SELECT * FROM users WHERE id = '$usernick' LIMIT 0,1";
$result=mysql_query($sql);
$num=mysql_numrows($result);

if ($num = '1') {
	
$i = 0;
	
$password=mysql_result($result,$i,"password");
$nick=mysql_result($result,$i,"nick");
$data=mysql_result($result,$i,"data");
$email=mysql_result($result,$i,"email");
$sex=mysql_result($result,$i,"sex");
$sexuality=mysql_result($result,$i,"sexuality");
$personal_ad=mysql_result($result,$i,"personal_ad");
$location=mysql_result($result,$i,"location");
$country=mysql_result($result,$i,"country");
$age=mysql_result($result,$i,"age");
$birth_date=mysql_result($result,$i,"birth_date");
$zodia=mysql_result($result,$i,"zodia");
$marital_status=mysql_result($result,$i,"marital_status");
$eyes_colour=mysql_result($result,$i,"eyes_colour");
$hair_colour=mysql_result($result,$i,"hair_colour");
$weight=mysql_result($result,$i,"weight");
$music=mysql_result($result,$i,"music");
$partner=mysql_result($result,$i,"partner");
$question=mysql_result($result,$i,"question");

$data_nast=explode("/",$birth_date);

$ziua=$data_nast[0];
$luna=$data_nast[1];
$anul=$data_nast[2];}

/* 2004-11-28 $bluenote:
   What if the query brings no result??? */
   
/* 2004-11-28 $bluenote:
   See above. */

$sql="SELECT age_min,age_max FROM match_finder where user_id= '$usernick' LIMIT 0,1";
$result=mysql_query($sql);
$num=mysql_numrows($result);

if ($num = '1') {
	
$i = 0;

$age_min=mysql_result($result,$i,"age_min");
$age_max=mysql_result($result,$i,"age_max");}

else {

$age_min=$age_array[0];
$age_max=$age_array[0];}

?>

<?php include("header.php"); ?>

<br>
<font size="5" face="Verdana, Arial, Helvetica, sans-serif"><strong>Edit Profile </strong></font><br>

<form name="form1" method="post" action="edit_profile.php">
<p> <br>
<br>
<br>
</p>

<?php echo $nume_users.":".$nick?>

<form action="edit_profile.php" onSubmit="MM_validateForm('email','','NisEmail','password','','R','password1','','R');return document.MM_returnValue">
<table width="450" border="0" cellspacing="0" cellpadding="1">
<tr>
<td><?php echo $password_text ?></td>

<?

/* 2004-11-28 $bluenote:
   What's the use of '=$password'?
   Think that '$password' is better... */
   
?>

<td><input name="password" type="password" id="password" value="<?php $password ?>"></td>
</tr>
<tr>
<td><?php echo $password_text ?></td>
<td><input name="password1" type="password" id="password1"></td>
</tr>
<tr>
<td><?php echo $email_text ?></td>

<?

/* 2004-11-28 $bluenote:
   What's the use of '=$email'?
   Think that '$email' is better... */
   
?>

<td><input name="email" type="text" id="email" value="<?php $email ?>"?></td>

</tr><tr>
<td>

<?php echo $sex_text ?>

</td><td>

<select name="sex" id="sex">

<?

/* 2004-11-28 $bluenote:
   What's that???
   You have closed with ?> after opening the for loop
   then you start a new code block.

   Never use PHP code outside of PHP tags!!!
   
   Below there is the fix; compare it with your version.
   
   Furthermore, i don't understand your application logic...
   you do the for loop and you close it behind 
   
   '">'.$sex_array[$i].'</option> ';}}"
   
   with the final bracket.
   
   Then, three lines below, you create a new select field by typing

   <td><select name=" sexuality" id="sexuality">'.$sex_array[$i].'</option> ';
    
   without setting the required <option value> opening tag... that's not only a PHP
   but an HTML error! I guess that you want to do another loop, so i wrote one in. But
   perhaps that is not the intention of your code, so please check it.*/
   
?>

<?

for ($i=0;$i<count($sex_array);$i++) {

echo "<option value="$sex_array[$i];";

if ($sex_array[$i] == $sex) {

echo "selected>'.$sex_array[$i].'</option>";}

else {

echo ">'.$sex_array[$i].'</option>";}}

?>

</select>

</td>
</tr>
<tr>
<td>

<?php echo $sexuality_text ?>

</td>
<td>

<select name="sexuality" id="sexuality">

<?

for ($i=0;$i<count($sex_array);$i++) {

echo "<option value="$sex_array[$i];";

if ($sex_array[$i] == $sex) {

echo "selected>'.$sex_array[$i].'</option>";}

else {

echo ">'.$sex_array[$i].'</option>";}}

?>

</select>

</td>
</tr>
<tr>
<td>

<?php echo $sexuality_text ?>

</td>

<?

/* 2004-11-28 $bluenote:
   Code error-free up to line 317 */
   
?>

<td>

<?

/* 2004-11-28 $bluenote:
   Concerning the loop: see above. In addition: You can't create a select element
   in a table cell and create the element's list in the next one!
   
   <select name="sexuality" id="sexuality"></td>
   
   I have moved the closing </td> tag to the end of your select element.
   
   THEN: What's that again??? A text area field within a select element
   which was not even opened??? YOUR REALLY CAN'T DO THAT!!
   
   Please read 
   
   http://www.w3.org/TR/html4 and
   http://de2.php.net/manual/en/ */
   
?>

<?

for ($i=0;$i<count($sexuality_array);$i++) {

echo "<option value="$sexuality_array[$i];";

if ($sexuality_array[$i]==$sexuality) {
	
echo "selected>'.$sexuality_array[$i].'</option>";}

else {
	
echo "<'.$sexuality_array[$i].'</option>";}}

?>

</select>

</td>
</tr>
<tr>
<td>

<?php echo $personal_ad_text ?>

</td>
<td>

<?

for ($i=0;$i<count($sexuality_array);$i++) {
	
if ($sexuality_array[$i]==$sexuality) {

echo "<textarea name="personal_ad" id="personal_ad">'.$sexuality_array[$i].'</option>";}

else {}}

?>

<?

/* 2004-11-28 $bluenote:
   Code error-free up to line 386 */
   
?>

</td>
</tr>
<tr>
<td>

<?php echo $personal_ad_text ?>

</td>
<td>

<?

/* 2004-11-28 $bluenote:
   What's the use of '=$personal_ad'?
   Think that '$personal_ad' is better... */
   
?>

<textarea name="personal_ad" id="personal_ad"><?php $personal_ad ?></textarea>

</td>
</tr>
<tr>
<td>

<?php echo $location_text ?>

</td>
<td>

<?

/* 2004-11-28 $bluenote:
   What's the use of '=$location'?
   Think that '$location' is better... 
   
   And:
   
   id="location"value="<?=location ?>"?>
   
   is just terrible, non-working code.
   
   1. There must be a space char between location" and value=:
   
   id="location" value="<?=location ?>"?>
   
   2. The above:
   
   id="location" value="<?php $location ?>"?>
   
   3. You can't just close a none-open PHP tag:
   
   id="location" value="<?php $location ?>" */
   
?>

<input name="location" type="text" id="location" value="<?php location ?>"

</td>
</tr>
<tr>
<td>

<?php echo $country_text ?>

</td>
<td>

<?

/* 2004-11-28 $bluenote:
   Code error-free up to line 461 */
   
?>

<?

/* 2004-11-28 $bluenote:
   You don't like loops and select elements, eh? */
   
?>

<select name="country" size="1" id="country">

<?

for ($i=0;$i<count($country_array);$i++) {

echo "<option value="$country_array[$i];";

if ($country_array[$i]==$country) {

echo "selected>'.$country_array[$i].'</option>";}

else {

echo ">'.$country_array[$i].'</option>";}}

?>

</select>

</td>
</tr>
<tr>
<td>

<?php echo $age_text ?>

</td>
<td>

<select name="age" id="age">

<?

for ($i=0;$i<count($country_array);$i++) {

echo "<option value="$country_array[$i];";

if ($country_array[$i]==$country) {

echo "selected>'.$country_array[$i].'</option>";}

else {

echo ">'.$country_array[$i].'</option>";}}

?>

</select>

</td>
</tr>
<tr>
<td>

<?php echo $age_text ?>

</td>
<td>

<?

/* 2004-11-28 $bluenote:
   Code error-free up to line 535 */
   
?>
- bluenote
tina
Forum Newbie
Posts: 4
Joined: Sat Nov 27, 2004 6:09 pm

Thank you for taking your time out to help me.

Post by tina »

Lots of code...Im in for a long week... :) and thanks for the quick responce. This is an informative place and I'm glad I stopped in.
Post Reply