help with this php code please
Moderator: General Moderators
help with this php code please
i have the following php code on my site and need the link to open in a new window...where do i add target="_blank"
not sure as to where to put it in
if ($bannerDetails['type']=="custom") {
echo "<a href=\"click.php?refid=".$bannerDetails['id']."\" target=\"new\"><img src=\"".$bannerDetails['imgpath']."\" alt=\"".$bannerDetails['alttext']."\" border=\"0\"><br>".$bannerDetails['textunder']."</a>";
// echo "<a href=\"".$bannerDetails['url']."\"><img src=\"".$bannerDetails['imgpath']."\" alt=\"".$bannerDetails['alttext']."\" border=\"0\"><br>".$bannerDetails['textunder']."</a>";
} else if ($bannerDetails['type']=="code") {
echo $bannerDetails['banner_code'];
}
}
mysql_free_result($getAdvert); ?> </td>
thanks
sung
not sure as to where to put it in
if ($bannerDetails['type']=="custom") {
echo "<a href=\"click.php?refid=".$bannerDetails['id']."\" target=\"new\"><img src=\"".$bannerDetails['imgpath']."\" alt=\"".$bannerDetails['alttext']."\" border=\"0\"><br>".$bannerDetails['textunder']."</a>";
// echo "<a href=\"".$bannerDetails['url']."\"><img src=\"".$bannerDetails['imgpath']."\" alt=\"".$bannerDetails['alttext']."\" border=\"0\"><br>".$bannerDetails['textunder']."</a>";
} else if ($bannerDetails['type']=="code") {
echo $bannerDetails['banner_code'];
}
}
mysql_free_result($getAdvert); ?> </td>
thanks
sung
first ask yourself where you put the
Code: Select all
tags....sorry about that
Code: Select all
if ($bannerDetails['type']=="custom") {
echo "<a href="click.php?refid=".$bannerDetails['id']."" target="new"><img src="".$bannerDetails['imgpath']."" alt="".$bannerDetails['alttext']."" border="0"><br>".$bannerDetails['textunder']."</a>";
// echo "<a href="".$bannerDetails['url'].""><img src="".$bannerDetails['imgpath']."" alt="".$bannerDetails['alttext']."" border="0"><br>".$bannerDetails['textunder']."</a>";
} else if ($bannerDetails['type']=="code") {
echo $bannerDetails['banner_code'];
}
}
mysql_free_result($getAdvert); ?> </td>Well that code is just way too hard to read formatted like that. I rewrote parts of it, I didn't test it but the target="_blank" was in the wrong place.
Code: Select all
<?php
if ($bannerDetails['type']=="custom")
{
$data = ''
. '<a target="_blank" href="click.php?refid=' . $bannerDetails['id'] . '">'
. '<img src="' . $bannerDetails['imgpath'] . '" alt="' . $bannerDetails['alttext'] . '" border="0"><br>' . $bannerDetails['textunder'] . '</a>';
// echo "<a href="".$bannerDetails['url'].""><img src="".$bannerDetails['imgpath']."" alt="".$bannerDetails['alttext']."" border="0"><br>".$bannerDetails['textunder']."</a>";
echo $data;
}
elseif ($bannerDetails['type']=="code")
{
echo $bannerDetails['banner_code'];
}
mysql_free_result($getAdvert);
?></td>Yes it does...
Tries to load an image, and when clicked, opens a new browser window.
Code: Select all
<?php
$data = ''
. '<a target="_blank" href="click.php?refid=' . $bannerDetails['id'] . '">'
. '<img src="' . $bannerDetails['imgpath'] . '" alt="' . $bannerDetails['alttext'] . '" border="0"><br>' . $bannerDetails['textunder'] . '</a>';
echo $data;
?>