Posted: Tue Jun 06, 2006 11:30 am
If you guys know what's best for you, you'll leave your egos at the door next time and keep things civilized. Stop this behavior now please.SpiderMonkey wrote:Maybe thats so, but he didnt have to talk down to me like I'm a moron just because I don't believe its nessecary in all situations (like I said, the code in question is currently running just fine on a live site).onion2k wrote:It's unlikely to happen while you're there overseeing things .. but what happens when you go on holiday and someone else is responsible for the site? Then it's bound to happen .. that's how life works. It's pretty trivial to code defensively in a situation like this .. and there's no reason not to. Even if it's a million-to-one chance of the problem happening you might as well code against it just in case.SpiderMonkey wrote:I am well aware of the issue you mentioned, I simply didn't bother with it because it is so unlikely to occur with sensibly named fileds. Given that users aren't going to be writing files to your web server without you being able to filter out idiotic filenames, I didn't consider it was an issue.
Also, when handing over the website over to someone else I'd consider readability of the code to be more important than accounting for a mistake they almost certainly won't make. My code probably wouldn't require a comment, the more complicated version would I think.