Page 3 of 3

Posted: Mon Dec 18, 2006 8:56 pm
by iknownothing
one last time...(hopefully)

Code: Select all

<?

if (isset($_POST['id'])){
$id = $_POST['id'];
mysql_query("DELETE FROM Winners WHERE id = '$id'", $con);
}else {
echo "Nothin was deleted";
}
?>

Posted: Mon Dec 18, 2006 9:03 pm
by netpants
nope, still nothing.

Posted: Tue Dec 19, 2006 1:53 pm
by netpants
SOLVED!!

Here is the final code for those interested.

Code: Select all

<? 
$username=""; 
$password=""; 
$database=""; 

mysql_connect(localhost,$username,$password); 
@mysql_select_db($database) or die( "Unable to select database"); 
$query="SELECT * FROM Winners"; 
$result=mysql_query($query); 
$num=mysql_numrows($result); 
?>

<font color="#FFFFFF"> 

<?php

if (isset($_POST['id'])){
mysql_query("DELETE FROM Winners WHERE id = ".$_POST['id']); 
}else { 
echo "Nothin was deleted"; 
} 

?>


</font>

<html> 

<head> 
<meta http-equiv="Content-Language" content="en-us"> 
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252"> 
<title>Add Winner</title> 
</head> 

<body bgcolor="#000000"> 

<p align="left"> 
<img border="0" src="1392094530_m.jpg" width="170" height="119"> 

<font color="#FFFFFF"> 
<form action="insert.php" method="post"> 
Date: <input type="text" name="loggedDate">  <br> 
First Name: <input type="text" name="firstName">  <br> 
Last Name: <input type="text" name="lastName"><br> 
Birthdate: <input type="text" name="birth"><br> 
Phone Number: <input type="text" name="phone"><br> 
Street Number: <input type="text" name="streetNumber"> 
Street Name: <input type="text" name="streetName"> 
City: <input type="text" name="city"><br> 
State: <input type="text" name="state" size="2"> 
Zip Code: <input type="text" name="zip"> 
Prize: <input type="text" name="prize"><br> 
E-Mail: <input type="text" name="email"><br> 
<input type="Submit" value="Add Winner"> 
</form></font> 

</p> 
<table border="0" width="986"> 
        <tr> 
                <td width="200"><font color="#FFFFFF">Add Winner<p> 
                <font color="#FFFFFF"><a href="display.php">Display Winner</a></font></td> 
                <td width="863" rowspan="3" valign="top"> 
                <table border="0" width="100%"> 
                        <tr> 

                                <td>&nbsp; 


<table border="0" cellspacing="2" cellpadding="2"> 
<tr> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><a href="<? $orderby = 'id' ?>">ID</a></font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Date</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><a href="<? $orderby = 'name' ?>">Name</a></font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Birthday</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Phone</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Street Number</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Street Name</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">City</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">State</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Zip</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Prize</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">E-Mail</font></th> 
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Edit</font></th> 
</tr> 

<? 
$i=0; 
while ($i < $num) { 
$id=mysql_result($result,$i,"id"); 
$date=mysql_result($result,$i,"loggedDate"); 
$first=mysql_result($result,$i,"firstName"); 
$last=mysql_result($result,$i,"lastName"); 
$birth=mysql_result($result,$i,"birth"); 
$phone=mysql_result($result,$i,"phone"); 
$streetnumber=mysql_result($result,$i,"streetNumber"); 
$streetname=mysql_result($result,$i,"streetName"); 
$city=mysql_result($result,$i,"city"); 
$state=mysql_result($result,$i,"state"); 
$zip=mysql_result($result,$i,"zip"); 
$prize=mysql_result($result,$i,"prize"); 
$email=mysql_result($result,$i,"email");  

?> 

<form method="POST" action=""> 
<tr> 
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$id"; ?></font></td> 
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$date"; ?></font></td> 
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$first $last"; ?></font></td> 
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$birth"; ?></font></td> 
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$phone";  ?></font></td> 
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$streetnumber"; ?></font></td> 
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$streetname";  ?></font></td> 
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$city";  ?></font></td> 
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$state";  ?></font></td> 
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$zip";  ?></font></td> 
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$prize";  ?></font></td> 
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><? echo "$email";  ?></font></td> 
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">
<input type="hidden" name="id" value="<?php echo $id; ?>">
<input type="submit" value="delete" name="delete"></font></td></tr> </form> 
<? 
++$i; 
} 
?> 
</table> 
</td> 
</tr> 
</table> 
                <p> 

</body> 
<?
mysql_close(); 
?>
<a href="http://www.freegamespot.net/dancefactory/update.php?id=37">Click Here</a>
</html>
Thanks everyone for your help on this.

Posted: Tue Dec 19, 2006 2:44 pm
by RobertGonzalez
May I suggest a few things?
  1. Wrap strings in quotes. localhost should be 'locahost'.
  2. Do not use error supprestion (@). If you are getting errors you are doing something wrong. It helps to know what is wrong.
  3. Validate your form data. Taking a posted var and deleting from your database with it directly is asking for trouble.
  4. Use complete PHP opening tags, not the short ones. This will save you all kinds of grief in the future and it makes for more portable code.
  5. Try some error handling on your queries.
  6. Try reviewing the PHP manual for some of your functions you are using as it could save you time and code.

Code: Select all

<?php
$username = '';
$password = '';
$database = '';

if (!$conn = mysql_connect('localhost',$username,$password))
{
    die('Could not connect to the database server: ' . mysql_error());
}

if (!mysql_select_db($database))
{
    die('Unable to select database: ' . mysql_error());
}

// this should be called before the query so 
// you don't see someone that was recently deleted
if (isset($_POST['id'])) {
    $del_id = $_POST['id'];
    // Do some validation on this to make sure it is correct
    
    if (!mysql_query("DELETE FROM Winners WHERE id = ".$_POST['id']))
    {
        die('Could not delete from the winners table: ' . mysql_error());
    }
} else {
    echo "Nothin was deleted";
}

$query = "SELECT * FROM Winners";
if (!$result = mysql_query($query))
{
    die('Could not get the winners list: ' . mysql_error());
}

$result_count = mysql_numrows($result);
?>
<html>

<head>
<meta http-equiv="Content-Language" content="en-us">
<meta http-equiv="Content-Type" content="text/html; charset=windows-1252">
<title>Add Winner</title>
</head>

<body bgcolor="#000000">

<p align="left">
<img border="0" src="1392094530_m.jpg" width="170" height="119">

<font color="#FFFFFF">
<form action="insert.php" method="post">
Date: <input type="text" name="loggedDate">  <br>
First Name: <input type="text" name="firstName">  <br>
Last Name: <input type="text" name="lastName"><br>
Birthdate: <input type="text" name="birth"><br>
Phone Number: <input type="text" name="phone"><br>
Street Number: <input type="text" name="streetNumber">
Street Name: <input type="text" name="streetName">
City: <input type="text" name="city"><br>
State: <input type="text" name="state" size="2">
Zip Code: <input type="text" name="zip">
Prize: <input type="text" name="prize"><br>
E-Mail: <input type="text" name="email"><br>
<input type="Submit" value="Add Winner">
</form></font>

</p>
<table border="0" width="986">
        <tr>
                <td width="200"><font color="#FFFFFF">Add Winner<p>
                <font color="#FFFFFF"><a href="display.php">Display Winner</a></font></td>
                <td width="863" rowspan="3" valign="top">
                <table border="0" width="100%">
                        <tr>

                                <td>&nbsp;

<!-- THE TWO PHP CALLS HERE DO ABSOLUTELY NOTHING EXCEPT ASSIGN A VARIABLE --> 
              
             
<table border="0" cellspacing="2" cellpadding="2">
<tr>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><a href="<?php $orderby = 'id' ?>">ID</a></font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Date</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><a href="<?php $orderby = 'name' ?>">Name</a></font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Birthday</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Phone</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Street Number</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Street Name</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">City</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">State</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Zip</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Prize</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">E-Mail</font></th>
<th><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">Edit</font></th>
</tr>

<?php
while ($row = mysql_fetch_array($result))
{
?>

<form method="POST" action="">
<tr>
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['id']; ?></font></td>
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['loggedDate']; ?></font></td>
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['firstName'] . ' ' . $row['lastName']; ?></font></td>
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['birth']; ?></font></td>
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['phone'];  ?></font></td>
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['streetNumber']; ?></font></td>
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['streetname']; ?></font></td>
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['city'];  ?></font></td>
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['state'];  ?></font></td>
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['zip'];  ?></font></td>
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['prize'];  ?></font></td>
<td bgcolor="#202020"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2"><?php echo $row['email'];  ?></font></td>
<td bgcolor="#333333"><font face="Arial, Helvetica, sans-serif" color="#FFFFFF" size="2">
<input type="hidden" name="id" value="<?php echo $row['id']; ?>">
<input type="submit" value="delete" name="delete"></font></td></tr> </form>
<?php
}
mysql_close();
?>
</table>
</td>
</tr>
</table>
<p>

</body>
<a href="http://www.freegamespot.net/dancefactory/update.php?id=37">Click Here</a>
</html>

Posted: Tue Dec 19, 2006 2:59 pm
by netpants
Thank you for your advice, yes there are somethings left in there from other things I was doing and trying to get working. I will give what you posted a shot. I really really new to php and understand what all of it means, I just dont know how to use it most of the time.