shortcuts good or bad?
Posted: Sun Mar 11, 2007 1:16 am
is writing code the short way like this for SQL good or bad? i mean, is it frowned upon?
Code: Select all
function update_user_downloads($username, $type)
{
$result = mysql_query("SELECT user_" . $type . "_downloads FROM users WHERE username='$username'") or die(mysql_error());
$download = mysql_fetch_object($result);
switch ($type)
{
case "anime":
$downloads = $download->user_anime_downloads + 1;
break;
case "manga":
$downloads = $download->user_manga_downloads + 1;
break;
case "midi":
$downloads = $download->user_midi_downloads + 1;
break;
case "mp3":
$downloads = $download->user_mp3_downloads + 1;
break;
case "software":
$downloads = $download->user_software_downloads + 1;
break;
}
mysql_query("UPDATE users
SET user_" . $type . "_downloads ='$downloads'
WHERE username='$username'") or die(mysql_error());
}