php inserting problem

PHP programming forum. Ask questions or help people concerning PHP code. Don't understand a function? Need help implementing a class? Don't understand a class? Here is where to ask. Remember to do your homework!

Moderator: General Moderators

andrade1
Forum Newbie
Posts: 14
Joined: Fri Apr 18, 2008 9:16 am

Re: php inserting problem

Post by andrade1 »

Code: Select all

 
[color=#0000FF]<html>
<body>
 
<?php
 
// connection string
 
 
$con = mysql_connect("agagg", "aggag", "afdaf") or die("could not connect to server");
mysql_select_db("agagadg", $con) or die('Sorry, could not connect to database');
 
 
 
 
// checks to see if the values have been set for all text fields
 
//delcare all posts as variables
 
$DRCVD = $_POST['DRCVD'];
$OCONT = $_POST['OCONT'];
$CONTENTS= $_POST['CONTENTS'];
$DEADLINE = $_POST['DEADLINE'];
$GIVENTO = $_POST['GIVENTO'];
$STATUS= $_POST['STATUS'];
$OUTCOME= $_POST['OUTCOME'];
$NOTES= $_POST['NOTES'];
 
 
if(isset ($_POST['DRCVD']) && isset($_POST['OCONT']) && isset($_POST['CONTENTS']) && isset($_POST['DEADLINE']) && isset($_POST['GIVENTO']) && isset($_POST['STATUS']) && isset($_POST['OUTCOME']) && isset($_POST['NOTES']))
{ 
// sql insert query for the variables into the cases table
$query = "INSERT INTO cases(DRCVD, OCONT, CONTENTS, DEADLINE, GIVENTO,STATUS,OUTCOME, NOTES ) VALUES ('$DRCVD', '$OCONT', '$CONTENTS', '$DEADLINE', '$GIVENTO', '$STATUS', '$OUTCOME', '$NOTES')";
// sql query either processes or fails and outputs an error message
echo $cases; 
mysql_query($query) or die ('origdepat query'.mysql_error());
}
 
 
 
 
// original department checkboxes
 
$query = "INSERT into origdepart (ACINTEG, CIVENG, ENRMGT, IA, OFFCAMP, PUBREL, UCS, ADSVC, CLUBS, ENGR, IACUC, OIA, RETRVR, UHS, AFSTDS, COMMONS, ERICSCH, IS, OIR, R_PARK, UMFNDN, ALREL, CONTED, ESH, IES, OIT, SGA, UPWBD, AMERSTD, CSEE, FACSEN, IRB, ORL, SHRVR, USM, ANCSTD, CSST, FINSERV, IRC, OSP, SOCWRK, VART, ASCRV, CWIT, GALLRY, JCET, OTD, SOCY, VPA_F, ATHL, DANCE, GEOG, LIBRY, PHIL, SJP, VPACAFF, BIO, DEANAHSS, GEST, LRC, PHYS, STUAFF, VPFACAF, BKSTR, DEANCOEIT, GRAD, MAS, POLTSCI, STULIFE, VPIA, CAREER, DEANUE, GSA, MATH, POLICE, STUSIPSRV, VPIT, CASPR, DEANCNMS, GUESTSRV, MECHENG, PPLNT, TECHCTR, VPRDGS, CAST, DPET_CPS, HIST, MIPAR, PRES, TEI, WMCTR, CUERE, ECON, HLTHSCI, MLL, PROC, TELECOMM, WMSTD, CHEM, EDUC, HNRSCOL, MUSIC, PROV, THTR, CHEMENG, EHS, HREL, MYRHOF, PSYC, TRANSIT, CHPDM, ENGL, HRES, OAG, PUBPOL, TRNCTRS)  VALUES (";
 
if($ACINTEG == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CIVENG == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ENRMGT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($IA == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($OFFCAMP == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($PUBREL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($UCS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ADSVC == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CLUBS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ENGR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($IACUC == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($OIA == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($RETRVR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($UHS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($AFSTDS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($COMMONS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ERICSCH == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($IS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($OIR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($R_PARK == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($UMFNDN == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($ALREL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($CONTED == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ESH == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($IES == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($OIT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
if($SGA == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($UPWBD == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($AMERSTD == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CSEE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($FACSEN == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($IRB == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ORL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($SHRVR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($USM == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ANCSTD == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if(CSST == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if(FINSERV == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($IRC == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($OSP == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($SOCWRK == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VART == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ASCRV == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CWIT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($GALLRY == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($JCET == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($OTD == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($SOCY == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VPA_F == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ATHL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($DANCE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($GEOG == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($LIBRY == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($PHIL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($SJP == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VPACAFF == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($BIO == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($DEANAHSS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($GEST == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($LRC == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($PHYS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($STUAFF == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VPFACAF == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($BKSTR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($DEANCOEIT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($GRAD == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
 
if($MAS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($POLTSCI == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($STULIFE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VPIA == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CAREER == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($DEANUE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($GSA == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($MATH == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($POLICE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($STUSIPSRV == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VPIT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CASPR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($DEANCNMS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($GUESTSRV == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($MECHENG == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($PPLNT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($TECHCTR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($VPRDGS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CAST == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($DPET_CPS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($HIST == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($MIPAR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($PRES == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($TEI == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($WMCTR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CUERE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ECON == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($HLTHSCI == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($MLL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($PROC == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($TELECOMM == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($WMSTD == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($CHEM == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($EDUC == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($HNRSCOL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($MUSIC == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($PROV == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($THTR == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CHEMENG == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($EHS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($HREL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($MYRHOF == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($PSYC == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
 
if($TRANSIT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CHPDM == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($ENGL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($HRES == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($OAG == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($PUBPOL == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($TRNCTRS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
$result = mysql_query($query);
echo $query; 
mysql_query($query) or die ('origdepart query'.mysql_error());
 
//responsible offices
 
$query = "INSERT into respoff (DEANAHSS2, PRES2, VPIT2, DEANCNMS2, PROV2, VPRDGS2, DEANCOEIT2, VPA_F2, VPSA, DEANERK, VPDUE, DEANUE, VPIA2) VALUES (";
 
if($DEANAHSS2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($PRES2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
 
if($VPIT2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($DEANCNMS2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($PROV2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VPRDGS2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($DEANCOEIT2== "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VPA_F2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($VPSA == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($DEANERK == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($VPDUE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($DEANUE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($VPIA2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
$result = mysql_query($query);
echo $query; 
mysql_query($query) or die ('respoff query'.mysql_error());
 
 
// requests
 
$query = "INSERT into request (ADVISE, DRAFT, MEDIATE, REPORT, CONTACT, NEGOTIATE, REVIEW, RESEARCH, INVESTIGATE, COORDINATE, MEETING_ATTEND, PRESENTATION) VALUES (";
 
if($ADVISE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($DRAFT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($MEDIATE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($REPORT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($CONTACT == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($NEGOTIATE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($REVIEW == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($RESEARCH == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($INVESTIGATE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($COORDINATE == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($MEETING_ATTEND == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
 
if($PRESENTATION == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
$result = mysql_query($query);
echo $query; 
mysql_query($query) or die ('request query'.mysql_error());
 
 
// completed
 
$query = "INSERT into cases (COMPLETED) VALUES (";
 
if($COMPLETED == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
$result = mysql_query($query);
echo $query; 
mysql_query($query) or die ('cases query'.mysql_error());
 
// referred to
 
 
$query = "INSERT into cases (OAG3, WTP2, OTHER2) VALUES (";
 
if($OAG3 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($WTP2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
if($OTHER2 == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
$result = mysql_query($query);
echo $query; 
mysql_query($query) or die ('cases query'.mysql_error());
 
?>
</body>
</html>
 
 
[/color]
User avatar
andym01480
Forum Contributor
Posts: 390
Joined: Wed Apr 19, 2006 5:01 pm

Re: php inserting problem

Post by andym01480 »

Great1

By echoing the query we can see the problem -it is not closed off
Line 1000

Code: Select all

$query.=')';
will sort it!

Job Done :)

To make life easier though (and be careful because you have more than one lot of form data flying around). You could use arrays to have built the query from form input. Be careful as you have more than one query and the code you post handles a different form to the mega query where we can't see where all those variables were set! But if you go through it you can see how much shorter it would be. It also makes sure the form data is safe for the form where the values should be 1 or 0.

Code: Select all

<?php
//Initialise variables
$data=array();
$firsthalf=array();
 
//deal with form variables and put in $data array where the key is the form variable name and the value is its value
//$data is sanitised - each item will be either 0 or 1, so safe to use in sql query
foreach( $_POST as $key => $value )
    {
    $data[$key]=0;//default is 0
    if ($value=='1') $data[$key]=$value;//only change it if the input was 1, stopping sql injection danger
    }
    
//Build query
//$firsthalf is an array with the keys of $data for use in the first half of the query
foreach($data as $key=>$value)
{
$firsthalf[]=$key;
}
$fields=implode(',',$firsthalf);//makes a string with all the keys separated by commas.
$values=implode(',',$data); //makes a string with all the values separated by commas.
$query="INSERT into TABLE ($fields) VALUES($values)"; //change TABLE name!
 
?>
andrade1
Forum Newbie
Posts: 14
Joined: Fri Apr 18, 2008 9:16 am

Re: php inserting problem

Post by andrade1 »

I inserted the query line that you suggested and I still receive:

origdepart queryYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IS, OIR, R_PARK, UMFNDN, ALREL, CONTED, ESH, IES, OIT, SGA, UPWB

Code: Select all

 
 
if($TRNCTRS == "1")
{
$query = $query . "'1', ";
} else
{
$query = $query . "'0', ";
}
 
[color=#FF0000]$query.=')';[/color]
 
 echo $query; 
mysql_query($query) or die ('origdepart query'.mysql_error());
 
//responsible offices
 
User avatar
andym01480
Forum Contributor
Posts: 390
Joined: Wed Apr 19, 2006 5:01 pm

Re: php inserting problem

Post by andym01480 »

It's the last if statement - a comma that has killed it!

Code: Select all

if($TRNCTRS == "1")
{
$query = $query . "'1' ";//don't want a comma after the value
} else
{
$query = $query . "'0' ";//don't want a comma after the value here 
}
 
$query.=')';
 
 echo $query.'<br/>'; 
mysql_query($query) or die ('origdepart query '.mysql_error());
 
 
That's why using arrays and implode is a better solution.

Hope it works. This thread is getting a little long. If not post the query as echoed as well as the error!!!!! :banghead:

Note - you have the same comma error on the last value in other queries too!
andrade1
Forum Newbie
Posts: 14
Joined: Fri Apr 18, 2008 9:16 am

Re: php inserting problem

Post by andrade1 »

I still get the same thing and I removed all the commas from the queries where you suggested to.

INSERT into origdepart (ACINTEG, CIVENG, ENRMGT, IA, OFFCAMP, PUBREL, UCS, ADSVC, CLUBS, ENGR, IACUC, OIA, RETRVR, UHS, AFSTDS, COMMONS, ERICSCH, IS, OIR, R_PARK, UMFNDN, ALREL, CONTED, ESH, IES, OIT, SGA, UPWBD, AMERSTD, CSEE, FACSEN, IRB, ORL, SHRVR, USM, ANCSTD, CSST, FINSERV, IRC, OSP, SOCWRK, VART, ASCRV, CWIT, GALLRY, JCET, OTD, SOCY, VPA_F, ATHL, DANCE, GEOG, LIBRY, PHIL, SJP, VPACAFF, BIO, DEANAHSS, GEST, LRC, PHYS, STUAFF, VPFACAF, BKSTR, DEANCOEIT, GRAD, MAS, POLTSCI, STULIFE, VPIA, CAREER, DEANUE, GSA, MATH, POLICE, STUSIPSRV, VPIT, CASPR, DEANCNMS, GUESTSRV, MECHENG, PPLNT, TECHCTR, VPRDGS, CAST, DPET_CPS, HIST, MIPAR, PRES, TEI, WMCTR, CUERE, ECON, HLTHSCI, MLL, PROC, TELECOMM, WMSTD, CHEM, EDUC, HNRSCOL, MUSIC, PROV, THTR, CHEMENG, EHS, HREL, MYRHOF, PSYC, TRANSIT, CHPDM, ENGL, HRES, OAG, PUBPOL, TRNCTRS) VALUES ('0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0''0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' '0' )origdepart queryYou have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IS, OIR, R_PARK, UMFNDN, ALREL, CONTED, ESH, IES, OIT, SGA, UPWB
User avatar
andym01480
Forum Contributor
Posts: 390
Joined: Wed Apr 19, 2006 5:01 pm

Re: php inserting problem

Post by andym01480 »

It's the last if statement - a comma that has killed it!
Not all of them. Just the last one before the query is run each time
Post Reply