Hiya, how can I optimize this code, or is there a better one already out there?
Also, see anything wrong with it? Constructive criticism please
Code: Select all
class lol{
var $dblink;
var $dbarraycheck = array();
var $dbinsertstr;
var $dbdeletestr;
var $dbupdatestr;
var $dbselectstr;
public function connect() {
require('skyddad/condb.php');
$this->dblink = $link;
return $this;
}
//Note that $columns & $values is a string that define each value with a , e.g "myvalue ='value', newvalue='value''" and
public function dbinsert($tablename, $column , $values) {
$this->dbinsertstr = "INSERT INTO $tablename (".$columns.") values (".$values.")";
mysql_query($this->dbinsertstr);
echo "Query inserted data into table ".$tablename." in column(s) ".$column." the value(s) ".$values.".";
return $this;
}
public function dbdelete($tablename, $column, $values) {
$this->dbdeletestr = "DELETE FROM $tablename WHERE $column = $values ";
mysql_query($this->dbdeletestr);
echo "Query deleted data from table ".$tablename." in column(s) ".$column." the value(s) ".$values.".";
return $this;
}
public function dbupdate($tablename, $updates){
$this->dbupdatestr = "UPDATE $tablename SET $updates";
mysql_query($this->dbupdatestr);
echo "Query updated data in table ".$tablename." updated were: ".$updates;
return $this;
}
public function dbselect($column, $tablename,$condition, $rownr) {
$this->dbselectstr = "SELECT ".$column." FROM ".$tablename;
if( !empty($condition) ) {
$this->dbselectstr = $this->dbselectstr." ".$condition;
}
$r = mysql_query($this->dbselectstr);
for($i = 0; $i<$rownr; $i++){
$this->dbarraycheck = mysql_fetch_array($r);
}
$this->dbselectstr = $this->dbarraycheck[$column];
return $this;
}
public function disconnect(){
mysql_close($this->dblink);
if(!empty($this->dbselectstr) ) {
return $this->dbselectstr;
}
}
}
~pickle | Please use [ code=html ], [ code=php ], etc tags where appropriate when posting code. Your post has been edited to reflect how we'd like it posted. Please read: