PHP Developers Network

A community of PHP developers offering assistance, advice, discussion, and friendship.
 
Loading
It is currently Thu Apr 19, 2018 12:50 pm

All times are UTC - 5 hours




Post new topic Reply to topic  [ 5 posts ] 
Author Message
PostPosted: Mon Dec 18, 2017 12:45 pm 
Offline
DevNet Master
User avatar

Joined: Wed Jun 27, 2007 9:44 am
Posts: 4313
Location: Sofia, Bulgaria
Several times we had issues with unit testing (and later in production code) classes that use callbacks - it's always the callback signature messed up while calling it. Unit tests could not help (at least not in a nice way) because the callbacks were mocked. Also the mocking of the callback is kind of an PITA.

It was pretty obvious that we need callable prototypes, but somehow it was declined (?!?).
So, eventually our team members agreed on that callables won't be used ever and "callable" interfaces will be created and required instead. Later, as PHP evolved, the anonymous classes where introduced which made our code much more readable.

Syntax: [ Download ] [ Hide ]
interface ITimerCallback {
  public function onTick(ITimer $timer);
}

interface ITimer {
  public function tick(ITimerCallback $handler);
}

...

$this->tick(new class implements ITimerCallback {
  public function onTick(ITimer $timer) {
    echo $timer->getTime();
  }
});

 


Just sharing :)

_________________
There are 10 types of people in this world, those who understand binary and those who don't


Last edited by VladSun on Tue Dec 19, 2017 7:41 am, edited 1 time in total.

Top
 Profile  
 
PostPosted: Mon Dec 18, 2017 3:17 pm 
Offline
Site Administrator
User avatar

Joined: Wed Aug 25, 2004 7:54 pm
Posts: 13538
Location: New York, NY, US
Nice solution. Thanks for sharing.

_________________
(#10850)


Top
 Profile  
 
PostPosted: Mon Dec 18, 2017 7:00 pm 
Offline
Spammer :|
User avatar

Joined: Wed Oct 15, 2008 2:35 am
Posts: 6617
Location: WA, USA
VladSun wrote:
It was pretty obvious that we need callable prototypes, but somehow it was declined (?!?).

PHP discusses everything publicly on their internals mailing list. Whenever you want to know what's going on, reading an archive of the emails is a great place to start.

AFAIK callable_types was supported in concept but had issues. Such as how it would be allowable to craft incredibly complex function signatures
Syntax: [ Download ] [ Hide ]
function foo(int $a, int $b, callable(callable(callable(callable(int, int):int $zebranky, int):int $pik, int):int $fot, int):int $zot): int {
    return $zot($a, $b);
}

And that default values in the signature would not be allowed
Syntax: [ Download ] [ Hide ]
function foo(callable(int = 123) $fn) {

And that it could create problems with strict_types and parameter variance.

In the rest of the OOP world, your problem is solved by interfaces or strict typing.


Top
 Profile  
 
PostPosted: Mon Dec 18, 2017 10:50 pm 
Offline
Site Administrator
User avatar

Joined: Wed Aug 25, 2004 7:54 pm
Posts: 13538
Location: New York, NY, US
requinix wrote:
In the rest of the OOP world, your problem is solved by interfaces or strict typing.

And indeed, the solution VladSun posted is to use interfaces...

_________________
(#10850)


Top
 Profile  
 
PostPosted: Wed Jan 24, 2018 5:23 am 
Offline
DevNet Master
User avatar

Joined: Wed Jun 27, 2007 9:44 am
Posts: 4313
Location: Sofia, Bulgaria
requinix wrote:
In the rest of the OOP world, your problem is solved by interfaces or strict typing.


How To Save The Princess In 8 Programming Languages

Just for fun, no rant :)

_________________
There are 10 types of people in this world, those who understand binary and those who don't


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC - 5 hours


Who is online

Users browsing this forum: No registered users and 4 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Jump to:  
Powered by phpBB® Forum Software © phpBB Group