Current PHP callables considered bad partice
Posted: Mon Dec 18, 2017 11:45 am
Several times we had issues with unit testing (and later in production code) classes that use callbacks - it's always the callback signature messed up while calling it. Unit tests could not help (at least not in a nice way) because the callbacks were mocked. Also the mocking of the callback is kind of an PITA.
It was pretty obvious that we need callable prototypes, but somehow it was declined (?!?).
So, eventually our team members agreed on that callables won't be used ever and "callable" interfaces will be created and required instead. Later, as PHP evolved, the anonymous classes where introduced which made our code much more readable.
Just sharing 
It was pretty obvious that we need callable prototypes, but somehow it was declined (?!?).
So, eventually our team members agreed on that callables won't be used ever and "callable" interfaces will be created and required instead. Later, as PHP evolved, the anonymous classes where introduced which made our code much more readable.
Code: Select all
interface ITimerCallback {
public function onTick(ITimer $timer);
}
interface ITimer {
public function tick(ITimerCallback $handler);
}
...
$this->tick(new class implements ITimerCallback {
public function onTick(ITimer $timer) {
echo $timer->getTime();
}
});