Newbie warning!
I've created (and have recived help here before) a joke database with great help from books etc.
Hoewever i found that the way i used to do thing, was not very good.
I sendt all variables trough a link to a new page, that validated and added the information. Of course this got me into trouble when i added a long joke.
I have also tried to do everything trough a single page, but only recive an error message, but no details. Which is why i hope someone can look trough the code, and see how many things i have done wrong
Code: Select all
<?php
if ( isset( $f_tittel ) && isset( $f_gittav ) && isset( $f_epost ) && isset( $f_kategori) && isset( $f_innhold ) ) {
// User input!
$error = "";
$ret = add_to_database( $f_tittel, $f_gittav, $f_epost, $f_kategori, $f_innhold, $error );
if ( ! $ret )
print "Error: $error<br>";
else
print "Status: Takk skal du ha!";
} else {
write_form();
}
FUNCTION add_to_database( $f_tittel, $f_gittav, $f_epost, $f_kategori, $f_innhold, $error ) {
$user = "Testuser";
$pass = "test";
$link = mysql_pconnect( "localhost", $user, $pass );
if ( ! $link ) {
$error = "Kunne ikke koble til mySQL server";
return false;
}
if ( ! mysql_select_db( $db, $link ) ) {
$error = mysql_error();
return false;
}
$query = "INSERT INTO vitser (tittel, kategori, gittav, epost, innhold) values ('$f_tittel','$f_kategori','$f_gittav','$f_epost','$f_innhold')";
if ( ! mysql_query( $query, ¤link ) ) {
$error = mysql_error();
return false;
}
return true;
}
FUNCTION write_form() {
$connection=mysql_connect("localhost","Testuser","test");
#Se om det funket!
if (!$connection) {
echo "Klarte ikke opprette forbindelse til mySQL serveren!";
exit;
}
# Hvilken database skal vi bruke?
$db=mysql_select_db("vitser",$connection);
#Se at man kan bytte database
if (!$db) {
echo "Klarte ikke endring til databasen!";
exit;
}
$version = 'v1.0.0.3a' ;
$software = 'VitseDB' ;
$navbar = ' | <a href=/demo/>Hovedsiden</A> | <a href=leggtil.php>Ny Vits</A> | <a href=velg_kategori.php>Velg Kategori</A> | <a href=sisteX.php>Siste 5 vitser</A> |<br><br> ' ;
global $PHP_SELF;
$sql="SELECT kategori FROM kategori";
$mysql_result=mysql_query($sql,$connection);
$num_rows=mysql_num_rows($mysql_result);
if ( $num_rows == 0 ) {
echo "$software - $version";
echo "<br><br>";
echo "$navbar";
echo "Beklager, ingen informasjon tilgjengelig";
} else {
# Fant oppføringer
echo "$software - $version";
echo "<br><br>";
echo "$navbar";
echo "<FORM METHOD=POST>";
# $f_tittel=strip_it($f_tittel);
# $f_gittav=strip_it($f_gittav);
# $f_epost=strip_it($epost);
# $f_innhold=strip_it($f_innhold);
# $f_innhold = nl2br($rowї"innhold"]);
echo "Tittel på vitsen<br> <INPUT TYPE="TEXT" NAME="f_tittel" VALUE="$f_tittel"><br>";
echo "Ditt navn<br> <INPUT TYPE="TEXT" NAME="f_gittav" VALUE="$f_gittav"><br>";
echo "Din E-Post<br> <INPUT TYPE="TEXT" NAME="f_epost" VALUE="$f_epost"><br>";
echo "Vits:<br> <textarea name="f_innhold" cols="50" rows="10" WRAP>$f_innhold</textarea><br>";
# Velg kategori
echo "Velg kategori<br>";
echo "<SELECT NAME="f_kategori">";
# FINN INFORMASJON OM KATEGORIER
while ($row=mysql_fetch_array($mysql_result))
{
$f_kategori=$rowї"kategori"];
# Vis resultat
echo "<OPTION>$f_kategori";
}
echo "</select>";
} # END ELSE
echo "<br><br>";
echo "<INPUT TYPE="SUBMIT" VALUE="OK">";
echo "</FORM>";
echo "<FORM METHOD=GET ACTION="$PHP_SELF">";
echo "<INPUT TYPE="SUBMIT" VALUE="Visk ut!">";
mysql_close($connection);
}
?>