MySQL Query Syntax Question

Questions about the MySQL, PostgreSQL, and most other databases, as well as using it with PHP can be asked here.

Moderator: General Moderators

Post Reply
mwaw
Forum Newbie
Posts: 19
Joined: Sun Aug 11, 2002 12:31 am
Location: California

MySQL Query Syntax Question

Post by mwaw »

I have this line in my PHP script:

$delivery = mysql_query("SELECT delivery_city FROM order_summaries WHERE order_number = '$_SESSION[CartNumber]'");

It works fine, but I believe that proper syntax would require a quote marks around the Session array key CartNumber. I am worried that someday, somewhere this line won't work because it does not have proper syntax.

I've tried escaping the various quote marks in this line, but that breaks the code.

Any suggestions?

Thanks!
User avatar
mydimension
Moderator
Posts: 531
Joined: Tue Apr 23, 2002 6:00 pm
Location: Lowell, MA USA
Contact:

Post by mydimension »

there are a few ways to do it. here is my favorite:

Code: Select all

$delivery = mysql_query("SELECT delivery_city FROM order_summaries WHERE order_number = '{$_SESSIONї'CartNumber']}'");
anything within the {} is considered a variable so you can quote the key name as usual.
User avatar
phice
Moderator
Posts: 1416
Joined: Sat Apr 20, 2002 3:14 pm
Location: Dallas, TX
Contact:

Post by phice »

I learn something everyday.

No more $id = $_POST["id"]; lines anymore ;)
Image Image
User avatar
twigletmac
Her Royal Site Adminness
Posts: 5371
Joined: Tue Apr 23, 2002 2:21 am
Location: Essex, UK

Post by twigletmac »

Within double quoted strings there is no need to quote your array elements so:

Code: Select all

$sql = "SELECT delivery_city FROM order_summaries WHERE order_number = '$_SESSION[CartNumber]'";
is just as valid syntactically as:

Code: Select all

$sql = "SELECT delivery_city FROM order_summaries WHERE order_number = '{$_SESSION['CartNumber']}'";
or

Code: Select all

$sql = "SELECT delivery_city FROM order_summaries WHERE order_number = '".$_SESSION['CartNumber']."'";
For more info:
http://www.php.net/manual/en/language.types.array.php
http://www.php.net/manual/en/language.t ... ng.parsing

Mac
mwaw
Forum Newbie
Posts: 19
Joined: Sun Aug 11, 2002 12:31 am
Location: California

THANKS!

Post by mwaw »

Thanks - I appreciate the feedback!
Post Reply