New Server, New Design

Where we keep all the boring tidbits about the PHPDN site, the news, and what not.

Moderator: General Moderators

jason
Site Admin
Posts: 1767
Joined: Thu Apr 18, 2002 3:14 pm
Location: Montreal, CA
Contact:

Post by jason »

These ideas for code review have been addressed. The proposed way is to allow anyone to review code, but allow certain people to get ranked in a way. That way, if you submit your code for review, anyone can review it, but by a ranking, you will know who to trust more.

Of course, if we have a new person join up and they know what they are doing, we don't want to stop them from contributing. So just because someone isn't well known aroudn here, that doesn't mean they don't know how to do a good review.
Cruzado_Mainfrm
Forum Contributor
Posts: 346
Joined: Sun Jun 15, 2003 11:22 pm
Location: Miami, FL

Post by Cruzado_Mainfrm »

i think you should give the right to certain people to rate code...that's what i think, after a certain amount of posts of helping people maybe u can consider the fact that this person can review code
jason
Site Admin
Posts: 1767
Joined: Thu Apr 18, 2002 3:14 pm
Location: Montreal, CA
Contact:

Post by jason »

Well, let me as you this, what's the harm in letting anyone review your code?
Nay
Forum Regular
Posts: 951
Joined: Fri Jun 20, 2003 11:03 am
Location: Brisbane, Australia

Post by Nay »

Harm, well....the most is if it was a "review" the script should be fully working, so the thing is someone might just copy and use it? That's what I fear since newbies have a high rate of doing that - I mean who knows?

The least possible might me sometimes, I mean most of us have seen this before - people with strong opinions. I mean I use heredoc for echo a lot. I normally suggest people to use it since you won't have to escape the quotes and all. But sometimes, things get a little out of hand; I think most of you can figure out what I mean.

Well, there's not much of other problems. Even if there was, It shouldn't be such a big issue.

-Nay
Post Reply