PHP Code tags

Where we keep all the boring tidbits about the PHPDN site, the news, and what not.

Moderator: General Moderators

User avatar
Weirdan
Moderator
Posts: 5978
Joined: Mon Nov 03, 2003 6:13 pm
Location: Odessa, Ukraine

Re: PHP Code tags

Post by Weirdan »

Code: Select all

 
function something() {};
 
:
Image

:evil:
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: PHP Code tags

Post by RobertGonzalez »

The plugin we are using is very specific to proSilver from what I understand. I think the priority was on getting the tags to parse first with the CSS tweaks coming later. I also know that the CSS was being worked on for subSilver and that the proSilver tweaks had not yet been implemented.
User avatar
Kieran Huggins
DevNet Master
Posts: 3635
Joined: Wed Dec 06, 2006 4:14 pm
Location: Toronto, Canada
Contact:

Re: PHP Code tags

Post by Kieran Huggins »

Wow - I've forced a refresh several times and still no joy :-(

FF on Gutsy.
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: PHP Code tags

Post by RobertGonzalez »

In subSilver or proSilver?
User avatar
Kieran Huggins
DevNet Master
Posts: 3635
Joined: Wed Dec 06, 2006 4:14 pm
Location: Toronto, Canada
Contact:

Re: PHP Code tags

Post by Kieran Huggins »

proSilver
User avatar
Weirdan
Moderator
Posts: 5978
Joined: Mon Nov 03, 2003 6:13 pm
Location: Odessa, Ukraine

Re: PHP Code tags

Post by Weirdan »

Kieran Huggins wrote:proSilver
proSilver has not been tweaked from what I see (though 'Collapse / Turn line numbers off / Select all' links started working)
User avatar
Chris Corbyn
Breakbeat Nuttzer
Posts: 13098
Joined: Wed Mar 24, 2004 7:57 am
Location: Melbourne, Australia

Re: PHP Code tags

Post by Chris Corbyn »

Because I'm not a forum admin I've been unable to edit the templates in proslver (editting the files doesn't change anything -- it's go do be done in the admin panel's editor!).

It will be fixed today ;)
User avatar
Chris Corbyn
Breakbeat Nuttzer
Posts: 13098
Joined: Wed Mar 24, 2004 7:57 am
Location: Melbourne, Australia

Re: PHP Code tags

Post by Chris Corbyn »

For anyone using the proSilver theme, you may have noticed that the code blocks have been looking screwy. If you log out and back in again you should see everything as normal now (phpBB caches styles in the session I think).
User avatar
Kieran Huggins
DevNet Master
Posts: 3635
Joined: Wed Dec 06, 2006 4:14 pm
Location: Toronto, Canada
Contact:

Re: PHP Code tags

Post by Kieran Huggins »

Chris Corbyn wrote:phpBB caches styles in the session I think.
THAT was the ticket - thanks Chris!!

Why is BBCode off now?
User avatar
JayBird
Admin
Posts: 4524
Joined: Wed Aug 13, 2003 7:02 am
Location: York, UK
Contact:

Re: PHP Code tags

Post by JayBird »

Kieran Huggins wrote:Why is BBCode off now?
You had the "Disable BBCode" checkbox selected.
matthijs
DevNet Master
Posts: 3360
Joined: Thu Oct 06, 2005 3:57 pm

Re: PHP Code tags

Post by matthijs »

The new php code tags are horrible. The functionality is nice, but the code is very, very hard to look at. Bad font, distracting line-numbers and background horizontal bands. Too little contrast in colors. Using subsilver by the way. Am I the only one?
User avatar
Chris Corbyn
Breakbeat Nuttzer
Posts: 13098
Joined: Wed Mar 24, 2004 7:57 am
Location: Melbourne, Australia

Re: PHP Code tags

Post by Chris Corbyn »

matthijs wrote:The new php code tags are horrible. The functionality is nice, but the code is very, very hard to look at. Bad font, distracting line-numbers and background horizontal bands. Too little contrast in colors. Using subsilver by the way. Am I the only one?
The colors are the default geshi ones. We fixed that up last time we installed a GeSHi mod ;) We'll do it again here. There are lots of things going on to get this new forum up, running and stable so just bear with us :)

The font size is going to be improved and the line numbers will be hacked to be off by default.
matthijs
DevNet Master
Posts: 3360
Joined: Thu Oct 06, 2005 3:57 pm

Re: PHP Code tags

Post by matthijs »

Ok, good to hear that. I was just afraid that it would stay like that.

My suggestions: (if not superfluous):
- bigger font-size
- the old colors (green etc)
- other font-family (don't know what it used to be?)
- ditch the row background colors, doesn't add anything, only distracts

p.s. all the hard work you mods do on the new forum is appreciated
User avatar
Kieran Huggins
DevNet Master
Posts: 3635
Joined: Wed Dec 06, 2006 4:14 pm
Location: Toronto, Canada
Contact:

Re: PHP Code tags

Post by Kieran Huggins »

I, for one, love the new code boxes (boxen?) I vote to keep them. The zebra striping is actually quite useful, IMO.

Maybe it will grow on the others? Change is often like that.
User avatar
VladSun
DevNet Master
Posts: 4313
Joined: Wed Jun 27, 2007 9:44 am
Location: Sofia, Bulgaria

Re: PHP Code tags

Post by VladSun »

Honestly, I dislike the scroll bars in the code blocks - first, I can't see the whole code and second, it makes me angry when I want to scroll the page with the mouse wheel.
Post Reply