A developer I met on these forums and I have been working on this site in the past few days - and now it's to a level where it's usuable, and decent looking. I'm interested in everyone's opinion on it, functionality wise - we're still working out small cosmetic issues. The site is http://linknumber.net
Thanks,
-Tyler
Opinion on site wanted.
Moderator: General Moderators
Not bad!
The design is simple, and straightforward. The colors aren't the worst possible either. The xhtml is valid, and the layout is obvious.
There are a few css validation errors, but they look simple to fix:
http://jigsaw.w3.org/css-validator/vali ... umber.net/
The redirect that you use to send people to the link image uses a HTTP 302 response. Arguably, I think the standard would prefer a 303, but a 302 isn't "wrong", since many http-1.0 clients don't understand 303. (http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html - scroll down to 303).
I would change the wording when you add a new link from ("Data entered successfully. Your number is XX.") to ("Link entered successfully. Your link number is XX.")
I'd offer a GET link to users as well - having to type in a link number on a form isn't ideal.. I'd want to be able to do like.. http://linknumber.net/?page=25 or some such.
The error codes it returns are a little unclear. If the linknumber doesn't exist, it doesn't tell you - it just returns a blank page. Worse, if it is defined, but isn't working right, you get a standard apache error message. Those could be improved on.
It even does well in the colorblind web page test.
All in all, very solid. Well done.
The design is simple, and straightforward. The colors aren't the worst possible either. The xhtml is valid, and the layout is obvious.
There are a few css validation errors, but they look simple to fix:
http://jigsaw.w3.org/css-validator/vali ... umber.net/
The redirect that you use to send people to the link image uses a HTTP 302 response. Arguably, I think the standard would prefer a 303, but a 302 isn't "wrong", since many http-1.0 clients don't understand 303. (http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html - scroll down to 303).
I would change the wording when you add a new link from ("Data entered successfully. Your number is XX.") to ("Link entered successfully. Your link number is XX.")
I'd offer a GET link to users as well - having to type in a link number on a form isn't ideal.. I'd want to be able to do like.. http://linknumber.net/?page=25 or some such.
The error codes it returns are a little unclear. If the linknumber doesn't exist, it doesn't tell you - it just returns a blank page. Worse, if it is defined, but isn't working right, you get a standard apache error message. Those could be improved on.
It even does well in the colorblind web page test.
All in all, very solid. Well done.
Heh, I didn't put the first error and the second I thought was a valid comment style. ^^;
"Data entered successfully." is from an older version...
"http://linknumber.net/?page=25" http://linknumber.net/25 would be even better, as Tyler suggested.
"If the linknumber doesn't exist, it doesn't tell you - it just returns a blank page." It should have, though!!
Stupid coding error.
"Data entered successfully." is from an older version...
"http://linknumber.net/?page=25" http://linknumber.net/25 would be even better, as Tyler suggested.
"If the linknumber doesn't exist, it doesn't tell you - it just returns a blank page." It should have, though!!
if your site is on apache you could easily use mod rewrite to create the link http://linknumber.net/25
I use the code below in a .htacess file in a similar fashion on one my sites to allow users to browse via http://mysite.net/country/[country_code]
so that http://mysite.net/country/GBR takes you through to the UK page.
it maps it through to http://mysite.net/country-profiles.php?countryCode=GBR
would work well for linknumber I think.
I use the code below in a .htacess file in a similar fashion on one my sites to allow users to browse via http://mysite.net/country/[country_code]
so that http://mysite.net/country/GBR takes you through to the UK page.
it maps it through to http://mysite.net/country-profiles.php?countryCode=GBR
would work well for linknumber I think.
Code: Select all
RewriteEngine On
RewriteRule ^country/([A-Z]{3})/profiles$ country-profiles.php?countryCode=$1 [L]