Please help critique my coding

Coding Critique is the place to post source code for peer review by other members of DevNetwork. Any kind of code can be posted. Code posted does not have to be limited to PHP. All members are invited to contribute constructive criticism with the goal of improving the code. Posted code should include some background information about it and what areas you specifically would like help with.

Popular code excerpts may be moved to "Code Snippets" by the moderators.

Moderator: General Moderators

Post Reply
CoolAsCarlito
Forum Contributor
Posts: 192
Joined: Sat May 31, 2008 3:27 pm
Contact:

Please help critique my coding

Post by CoolAsCarlito »

Code: Select all

<?php
    ob_start("ob_gzhandler");  // cache system
 
    require "backstageconfig.php";
    require "backstagefunctions.php";
 
    if ((!empty($_POST)) && (isset($_POST['action']))) 
    {
        $action=$_POST{'action'};
    } 
    else
    {
        $action="mainmenu";
    }
 
    if ((isset($_POST['uname'])) && (isset($_POST['pword'])))
    {
        $uname=$_POST{'uname'};
        $pword=md5($_POST{'pword'});
        validate($fedid, $uname, $pword, 0, 0, $cookiedomain, $cookiepath, $admincssfile);
        $action="mainmenu";
    }
    elseif ((!(isset($_COOKIE['uname']))) && (!(isset($_COOKIE['pword']))))
    {
        require_once "backstage_libs/login.php";
        login($admincssfile,$fed,$url);
    }
    else
    {
        $uname=$_COOKIE["uname"];
        $pword=$_COOKIE["pword"];
        validate($fedid, $uname, $pword, 0, 0, $cookiedomain, $cookiepath, $admincssfile);
 
        if (isset($_POST['newdefaultcharacterid']))
        {
            $newdefaultcharacterid = (integer)$_POST["newdefaultcharacterid"];
            $query = "UPDATE
                    efed_handler
                SET
                    default_char_id = '$newdefaultcharacterid'
                WHERE
                    login = '$uname' and
                    fed_id = '$fedid'"; 
            mysql_db_query($dbname, $query) or Die (mysql_error());
        }
    }
 
    $query = "SELECT
            h.id as userid,
            h.surname as surname,
            h.firstname as firstname,
            h.isadmin as isadmin,
            newscat.id as defaultcategoryid,
            bio.id as defaultcharacterid,
            bio.style_id as styleid,
            bio.username as defaultcharacterusername,
            bio.charactername as defaultcharactername,
            styles.name as style
        FROM
            efed_handler as h
        LEFT JOIN
            efed_bio as bio
        ON
            (
                h.default_char_id = bio.id and
                bio.fed_id = '$fedid'
            )
        LEFT JOIN
            efed_list_styles as styles
        ON
            (
                bio.style_id = styles.id and
                bio.fed_id = '$fedid'
            )
        LEFT JOIN
            efed_list_newscategory as newscat
        ON
            (
                h.default_news_id = newscat.id and
                newscat.fed_id = '$fedid'
            )
        WHERE
            h.login = '$uname' and
            h.password = '$pword' and
            h.fed_id = '$fedid'"; 
    $result = mysql_query ($query); 
    while ($row = mysql_fetch_assoc($result))
    {
        $fieldarray=array('userid','surname','firstname','isadmin','defaultcharacterid','defaultcharacterusername','defaultcharactername','defaultcategoryid','styleid','username','style','charactername');
        foreach ($fieldarray as $fieldlabel)
        {
            if (isset($row[$fieldlabel])) 
            { 
                $$fieldlabel=$row[$fieldlabel];
                $$fieldlabel=cleanquerydata($$fieldlabel);
            }
        }
    }
 
    if ($action != "logout")
    {
        headercode($fedid,$admincssfile,$userid,$isadmin,$defaultcharacterid,$defaultcharacterusername,$defaultcharactername,$surname,$firstname,$action,$dirpath,$folder,$headshot,$bioheadheight,$bioheadwidth,$surname,$firstname,$forums);
    }
    else
    {
        headercode($fedid,$admincssfile,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0);
    }
    // print "<center>\n";
 
    switch ($action)    
    {
        case "mainmenu":
            mainscreen();
            print "</div>\n";
            footercode();
            break;
 
        case "login":
            require_once "backstage_libs/login.php";
            login($admincssfile,$fed,$url);
            break;
 
        case "handler":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/handler.php";
                handler($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$ip); 
            }
            break;
 
        case "character":
            require_once "backstage_libs/character.php";
            character($fedid,$uname,$pword,$userid,$dirpath,$isadmin,$admincssfile,$dbname,$sortorderarray,$iframe,$defaultcharacterid,$styleid,$defaultcharacterusername,$heatmetersenabled,$heatmeters);
            break;
 
        case "newscategory":
            if ($isadmin == "1") 
            {
                require_once "backstage_libs/newscategory.php";
                newscategory($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$targetarray); 
            }
            break;
 
        case "news":
            require_once "backstage_libs/news.php";
            news($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$defaultcategoryid,$ip,$defaultcharacterid,$defaultcharactername);
            break;
 
        case "content":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/content.php";
                content($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname); 
            }
            break;
 
        case "template":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/template.php";
                template($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname); 
            }
            break;
 
        case "biolayout":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/biolayout.php";
                biolayout($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname); 
            }
            break;
 
        case "quotes":
            require_once "backstage_libs/quotes.php";
            quotes($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$defaultcharacterid,$defaultcharactername);
            break;
 
        case "alliesrivals":
            require_once "backstage_libs/alliesrivals.php";
            alliesrivals($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$numalliesrivals,$defaultcharacterid,$defaultcharactername,$defaultcharacterusername);
            break;
 
        case "roleplay":
            require_once "backstage_libs/roleplay.php";
            roleplay($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$defaultcharacterid,$defaultcharactername);
            break;
 
        case "champions":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/champions.php";
                champions($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname); 
            }
            break;
 
        case "title":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/title.php";
                title($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname); 
            }
            break;
 
        case "titlehistory":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/titlehistory.php";
                titlehistory($uname,$pword,$userid,$isadmin,$admincssfile,$dbname); 
            }
            break;
 
        case "division":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/division.php";
                division($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname); 
            }
            break;
 
        case "eventname":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/eventname.php";
                eventname($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname); 
            }
            break;
 
        case "eventbooker":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/eventbooker.php";
                eventbooker($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$dirpath,$headshot); 
            }
            break;
 
        case "submitmatch":
            require_once "backstage_libs/submitmatch.php";
            submitmatch($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$dirpath,$headshot);
            break;
 
        case "submitseg":
            require_once "backstage_libs/submitseg.php";
            submitseg($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$dirpath,$headshot);
            break;
 
        case "resultscompilation":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/resultscompilation.php";
                resultscompilation($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$dirpath,$headshot); 
            }
            break;
 
        case "resultsediting":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/resultsediting.php";
                resultsediting($uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$dirpath,$headshot,$url); 
            }
            break;
 
        case "menustructures":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/menustructures.php";
                menustructures($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$dirpath,$headshot,$url); 
            }
            break;
 
        case "arenas":
            if ($isadmin == "1") 
            { 
                require_once "backstage_libs/arenas.php";
                arenas($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$dirpath,$url); 
            }
            break;
 
        case "manageapplications":
            if ($isadmin == "1") 
            {
                require_once "backstage_libs/manageapplications.php";
                manageapplications($fedid,$uname,$pword,$userid,$isadmin,$admincssfile,$dbname,$dirpath,$url);
            }
            break;
            
        case "logout":
            SetCookie ("uname", "");
            SetCookie ("pword", "");
            require_once "backstage_libs/login.php";
            login($admincssfile,$fed,$url);
            break;
 
        default:
            print "Default Screen<br />";
            footercode();
            break;
    }
    exit;
?>
User avatar
Christopher
Site Administrator
Posts: 13596
Joined: Wed Aug 25, 2004 7:54 pm
Location: New York, NY, US

Re: Please help critique my coding

Post by Christopher »

What is this script supposed to do? And what aspects of the script would you like critiqued?
(#10850)
Post Reply