Seeking Major Feedback

Coding Critique is the place to post source code for peer review by other members of DevNetwork. Any kind of code can be posted. Code posted does not have to be limited to PHP. All members are invited to contribute constructive criticism with the goal of improving the code. Posted code should include some background information about it and what areas you specifically would like help with.

Popular code excerpts may be moved to "Code Snippets" by the moderators.

Moderator: General Moderators

Post Reply
CoolAsCarlito
Forum Contributor
Posts: 192
Joined: Sat May 31, 2008 3:27 pm
Contact:

Seeking Major Feedback

Post by CoolAsCarlito »

This site was designed by buddy of mine that I paid some good money to create a new design for my professional wrestling company. I was just curious to know what everybody thought of the following pages like the typography/layout css structure of each page for anyone who is bored and wouldn't mind looking them over to see what they thought.

http://www.kansasoutlawwrestling.com

Subpages
http://kansasoutlawwrestling.com/archives/542
http://kansasoutlawwrestling.com/roster
http://kansasoutlawwrestling.com/bio?username=cruz
http://kansasoutlawwrestling.com/champions
http://kansasoutlawwrestling.com/titlehistory
http://kansasoutlawwrestling.com/previewcard
http://kansasoutlawwrestling.com/latestresults
http://kansasoutlawwrestling.com/eventarchives
http://kansasoutlawwrestling.com/gallery
http://kansasoutlawwrestling.com/radio
User avatar
social_experiment
DevNet Master
Posts: 2793
Joined: Sun Feb 15, 2009 11:08 am
Location: .za

Re: Seeking Major Feedback

Post by social_experiment »

I read somewhere that red on black is a bit of a bad choice because color blind people struggle to distinguish and sometimes can't read the text.

The site isn't xhtml complaint http://validator.w3.org/check?uri=http% ... ne&group=0

The CSS didn't pass validation http://jigsaw.w3.org/css-validator/vali ... =1&lang=en

With images disabled, there is no way for me to know what link i am clicking until i hover over the area where link appears to be.
Images should always have alt info, especially your heading image.

Possibly there could be more padding between the links that dropdown and the heading. In my browser the 3rd link from the left goes behind the heading so i cannot access it.

My screen resolution is 1366 x 768 and i viewed the page in IE7.
“Don’t worry if it doesn’t work right. If everything did, you’d be out of a job.” - Mosher’s Law of Software Engineering
CoolAsCarlito
Forum Contributor
Posts: 192
Joined: Sat May 31, 2008 3:27 pm
Contact:

Re: Seeking Major Feedback

Post by CoolAsCarlito »

Now that's the sort of feedback I wanted. Thank you. I corrected the validation of the page except for one issue that being the < not a usable character. I tried going and using the suggested < but when I did that it wouldn't show the dropdowns when I hovered over. How can I fix this issue?

Most of the errors for css are of plugins that were downloaded for wordpress.

I'll go back in and give alts to all my images.

What you said about padding did you mean the drop downs and the heading the drop downs belong to?
User avatar
Christopher
Site Administrator
Posts: 13596
Joined: Wed Aug 25, 2004 7:54 pm
Location: New York, NY, US

Re: Seeking Major Feedback

Post by Christopher »

For some reason on a site like this I expected more animation and wonky button effects. It seems like in needs some music too. Stuff you hate on regular sites but make a site like this.
(#10850)
User avatar
social_experiment
DevNet Master
Posts: 2793
Joined: Sun Feb 15, 2009 11:08 am
Location: .za

Re: Seeking Major Feedback

Post by social_experiment »

CoolAsCarlito wrote:What you said about padding did you mean the drop downs and the heading the drop downs belong to?
I think to the whole section below the navigation, see screenshot.

As for the < issue, you could try using an external js file.

Code: Select all

<script type="text/javascript" src="path_to_file"></script>
Attachments
image_.zip
screen shot
(38.52 KiB) Downloaded 507 times
“Don’t worry if it doesn’t work right. If everything did, you’d be out of a job.” - Mosher’s Law of Software Engineering
Post Reply