my first css website

Coding Critique is the place to post source code for peer review by other members of DevNetwork. Any kind of code can be posted. Code posted does not have to be limited to PHP. All members are invited to contribute constructive criticism with the goal of improving the code. Posted code should include some background information about it and what areas you specifically would like help with.

Popular code excerpts may be moved to "Code Snippets" by the moderators.

Moderator: General Moderators

Post Reply
User avatar
php3ch0
Forum Contributor
Posts: 212
Joined: Sun Nov 13, 2005 7:35 am
Location: Folkestone, Kent, UK

my first css website

Post by php3ch0 »

Hi all have a look at my website which is a first for me in css. I have finally given up the tables I know it should have been ages ago but I have decided to take the plunge.

Please be ruthless about the CSS as I want to learn more.

http://www.echohosting.co.uk/~riskat
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Post by RobertGonzalez »

I like the code behind it. I like that the markup and CSS validate. Very well done in that regard.

Rendering degrades nicely when CSS is disabled. Another plus.

You are using about 110K of imagery. That isn't a whole lot, but considering that the header image is 56K and the two supplemental images are 22K and 26K respectively, you can see that this may cause problems to users on dialup systems. However, the site degrades nicely when images are disabled. That is certainly a plus.

One thing to consider is perhaps a splash of lighter color throughout so that there is some contrast in the view. Otherwise, I like that it loads fairly quicker (would like lighter weight imagery, but still it is OK) and that it validates. Good job.
User avatar
califdon
Jack of Zircons
Posts: 4484
Joined: Thu Nov 09, 2006 8:30 pm
Location: California, USA

Post by califdon »

I don't really have any additional comments and everah made a more thorough analysis than I probably would have done, so my response is just to say that I looked at it and agree with his comments.
User avatar
hawleyjr
BeerMod
Posts: 2170
Joined: Tue Jan 13, 2004 4:58 pm
Location: Jax FL & Spokane WA USA

Post by hawleyjr »

Insurance Web Site, Fun! lol, welcome to my world ;)

nice site
User avatar
php3ch0
Forum Contributor
Posts: 212
Joined: Sun Nov 13, 2005 7:35 am
Location: Folkestone, Kent, UK

Post by php3ch0 »

Thanks for all the positive feedback people. I know it is an insurance web site but I did have fun doing it as I like learning new things. Looks like it is CSS in the future for me then.
thinsoldier
Forum Contributor
Posts: 367
Joined: Fri Jul 20, 2007 11:29 am
Contact:

Post by thinsoldier »

I would have used <ul><li><a> for the navigation elements. That's it.
Post Reply