refactoring 101

Coding Critique is the place to post source code for peer review by other members of DevNetwork. Any kind of code can be posted. Code posted does not have to be limited to PHP. All members are invited to contribute constructive criticism with the goal of improving the code. Posted code should include some background information about it and what areas you specifically would like help with.

Popular code excerpts may be moved to "Code Snippets" by the moderators.

Moderator: General Moderators

thinsoldier
Forum Contributor
Posts: 367
Joined: Fri Jul 20, 2007 11:29 am
Contact:

Post by thinsoldier »

Finally this project came up on my schedule again.
More questions later.

I've done 2 other small projects in a manner similar to this one and it does feel like a 'cleaner' way to do things and I have almost no duplicate code but it still feels like I'm doing something wrong in the way I organize things.

Now that I've completely forgotten what this order processing code looks like I'll look it over again and see if there's any other changes I should make.

.... hmmm... I should probably document what I have so far first.
User avatar
Christopher
Site Administrator
Posts: 13596
Joined: Wed Aug 25, 2004 7:54 pm
Location: New York, NY, US

Post by Christopher »

thinsoldier wrote:... it does feel like a 'cleaner' way to do things and I have almost no duplicate code but it still feels like I'm doing something wrong in the way I organize things.
Join the club! ;)
(#10850)
Post Reply