PHP Search Pro

Coding Critique is the place to post source code for peer review by other members of DevNetwork. Any kind of code can be posted. Code posted does not have to be limited to PHP. All members are invited to contribute constructive criticism with the goal of improving the code. Posted code should include some background information about it and what areas you specifically would like help with.

Popular code excerpts may be moved to "Code Snippets" by the moderators.

Moderator: General Moderators

Post Reply
User avatar
hawkenterprises
Forum Commoner
Posts: 54
Joined: Thu Feb 28, 2008 9:56 pm
Location: gresham,oregon
Contact:

PHP Search Pro

Post by hawkenterprises »

Hello All,

Hawk Enterprises has just released it's latest version of PHP Search Pro

PHP Search Pro is a open source (free) script written in PHP that works off of keywords entered into it to pull up search terms. It's similar in the way google creates there indexes. This version offers some improvements such as an admin, install script and a few other goodies. Take a look and bring on the criticisms.
PHP Search Pro
User avatar
pickle
Briney Mod
Posts: 6445
Joined: Mon Jan 19, 2004 6:11 pm
Location: 53.01N x 112.48W
Contact:

Re: PHP Search Pro

Post by pickle »

The [url] tag doesn't need double-quotes around the actual url :wink: . I've fixed your post.
Real programmers don't comment their code. If it was hard to write, it should be hard to understand.
User avatar
hawkenterprises
Forum Commoner
Posts: 54
Joined: Thu Feb 28, 2008 9:56 pm
Location: gresham,oregon
Contact:

Re: PHP Search Pro

Post by hawkenterprises »

Thank you so much.

lol, yeah BBCODE makes me break pencils from time to time. I suppose an simple anchor syntax is too much to ask for.
User avatar
Ambush Commander
DevNet Master
Posts: 3698
Joined: Mon Oct 25, 2004 9:29 pm
Location: New Jersey, US

Re: PHP Search Pro

Post by Ambush Commander »

Open source = what license?
User avatar
hawkenterprises
Forum Commoner
Posts: 54
Joined: Thu Feb 28, 2008 9:56 pm
Location: gresham,oregon
Contact:

Re: PHP Search Pro

Post by hawkenterprises »

I believe either on the site or in the readme in the zip should be information about my terms, I don't use GPL or anything like that, much more laid back.
User avatar
Christopher
Site Administrator
Posts: 13596
Joined: Wed Aug 25, 2004 7:54 pm
Location: New York, NY, US

Re: PHP Search Pro

Post by Christopher »

"laid back" is not a license term I am familiar with. I checked the download and there does not appear to be a license associated with that code, nor on the page you link to. Is it in the Public Domain?
(#10850)
User avatar
hawkenterprises
Forum Commoner
Posts: 54
Joined: Thu Feb 28, 2008 9:56 pm
Location: gresham,oregon
Contact:

Re: PHP Search Pro

Post by hawkenterprises »

I'm not really into the strict sense of legal jargon, I believe this is something equivalent use 'as is' if you modify it you may not remove the credit line without my permission.
User avatar
Christopher
Site Administrator
Posts: 13596
Joined: Wed Aug 25, 2004 7:54 pm
Location: New York, NY, US

Re: PHP Search Pro

Post by Christopher »

That would be either an MIT or BSD license. If that's what you want -- tell people by specifying the license. But since the software has no stated license, that either means proprietary or public domain. I would recommend that people consider it proprietary to be on the safe side.
(#10850)
User avatar
hawkenterprises
Forum Commoner
Posts: 54
Joined: Thu Feb 28, 2008 9:56 pm
Location: gresham,oregon
Contact:

Re: PHP Search Pro

Post by hawkenterprises »

Hmmm something like this BSD License

* Copyright (c) <year>, <copyright holder>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions are met:
* * Redistributions of source code must retain the above copyright
* notice, this list of conditions and the following disclaimer.
* * Redistributions in binary form must reproduce the above copyright
* notice, this list of conditions and the following disclaimer in the
* documentation and/or other materials provided with the distribution.
* * Neither the name of the <organization> nor the
* names of its contributors may be used to endorse or promote products
* derived from this software without specific prior written permission.
*
* THIS SOFTWARE IS PROVIDED BY <copyright holder> ``AS IS'' AND ANY
* EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
* WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL <copyright holder> BE LIABLE FOR ANY
* DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
* (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
* LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
* ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
* SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
User avatar
Christopher
Site Administrator
Posts: 13596
Joined: Wed Aug 25, 2004 7:54 pm
Location: New York, NY, US

Re: PHP Search Pro

Post by Christopher »

That would be good. You let people know exactly how they can use your software and that you need the copyright to stay with it if they use it. So you get the props. It also lets more people use your software, because if there is no license anyone with any sense won't use it because they don't know if they legally can. You look like you have some good stuff that is worth it.
(#10850)
Post Reply