EasySwift and the default encoding
Posted: Mon Feb 18, 2008 8:06 am
Hi there,
first of all thank you for Swift Mailer, it seems to be a good project, really.
I am here just to report a bug in last release, exactely in file EasySwift and line 739.
Since 3 lines before you wrote
* @param string The encoding used (default is base64)
I think you should change the default null value from parameter $encoding and method addAttachment.
It is just because if someone is using this great wrapper for old Swift version and he doesn't add base64 encoding this wrapper will send a new Swift_Message_Attachment($data, $filename, $type, $encoding), with null value.
I am not sure the problem I had with PDF was there, anyway this is just a little doc or code problem that you could easily solve, changing the comment or using $encoding="base64" as default, as is in Swift_Message_Attachment constructor.
Cheers,
Andrea Giammarchi
first of all thank you for Swift Mailer, it seems to be a good project, really.
I am here just to report a bug in last release, exactely in file EasySwift and line 739.
Since 3 lines before you wrote
* @param string The encoding used (default is base64)
I think you should change the default null value from parameter $encoding and method addAttachment.
It is just because if someone is using this great wrapper for old Swift version and he doesn't add base64 encoding this wrapper will send a new Swift_Message_Attachment($data, $filename, $type, $encoding), with null value.
I am not sure the problem I had with PDF was there, anyway this is just a little doc or code problem that you could easily solve, changing the comment or using $encoding="base64" as default, as is in Swift_Message_Attachment constructor.
Cheers,
Andrea Giammarchi