PHP Developers Network

I'm bumping this topic to raise awareness that [syntax=php] tags should be used instead of [php] tags because this issue still exists.

Sample [php][/php]

Sample [syntax=php][/syntax]

I don't know where in the code this is implemented. It may be a part of the same library we are using to add all the other tags. I'll look into it when I get a minute. Have I mentioned the phpBB codebase is psychotic?

_________________

maybe I'm wrong... but is not just matter of:
a) delete the row associated to the [php] tag in the table bbcodes or
b) update that row with the same definitions that the tag [syntax] has, allowing in this way to don't break old post ?

When I quote posts the code looks good, so in theory they should replace "[php]" with "[syntax=php]" with a rewrite rule.

While that could work, it would also replace [php] with [syntax=php] right here, making me look as though I'm comparing [syntax=php] with [syntax=php]. While not a huge deal right now, who knows if it could be in the future. What if I was writing code that used an array with php as a key?

I took a brief look at the code and it appears that it uses the language such php, css, html, ini etc to look for a corresponding parser which is located as a file on disk based on the language name. I'm not able to spend much time on that right now so if anyone else wants to have a look feel free. I believe the geshi code for phpBB is easy to find.

_________________

@benjamin:

Maybe you could attach the message_parser.php file in case somebody could take a look at it, also will help to know which phpbb mod was installed to implement Geshi... was bbGeshi_0.7.5 ?