Page 1 of 4

New [php] tags hyperlink vote

Posted: Sun Feb 05, 2006 5:35 am
by Chris Corbyn
Seems we have some differing opinions on the new

Code: Select all

 tags.  What do you think we should do with the hyperlinks on the documented function names?  Do you find them useful? :)

Voting ends in 5 days (Friday 10th).

[syntax=php]$foo = 'bar';

function say_it_twice($str)
{
    return str_repeat($str, 2); //Documented
}

echo say_it_twice($foo); //Not documented[/syntax]

Posted: Sun Feb 05, 2006 6:46 am
by jayshields
Great idea linking them. Many other sites do that. I was going to suggest it.

I'm not fussed about styling, functionality is more important.

Well done :)

Posted: Sun Feb 05, 2006 7:01 am
by shiznatix
i like em. very useful i must say. the color is obvious link color so it works out. go team.

Posted: Sun Feb 05, 2006 7:17 am
by feyd
although I know it's a bit of work, allowing the colors/style to be chosen would help satisfy all the people. I think everyone, from those that don't like the coloring at all, to those would like the code in a slight different set of colors, to guests that aren't registered at all.

I do believe the default should stay this way, or maybe bold, or even background color (say yellow?) the links to really make them pop. At least that would benefit guests and newbs likely the most.

Posted: Sun Feb 05, 2006 8:03 am
by RobertGonzalez
Bolding the link might bring attention to it without carpping out the style of the highlighter. I would agree that making the links stand out is a necessary feature, but I think we would also want to keep the look and feel as clean as possible.

Either way, the fact that this feature is on this board is a definite improvement and will be a helpful tool to a lot of developers.

Posted: Sun Feb 05, 2006 9:21 am
by d3ad1ysp0rk
I wish you guys had used a css class for styling them instead of style="blah" in the a tags. Now I can't use the Web Developer's Toolbar to edit the CSS on the fly to check the differences and what looks best.

Not a big deal, but now I have to just guess what may look the best ;)

Posted: Sun Feb 05, 2006 9:40 am
by feyd
that's actually due to how the original phpbb mod works. I'm hoping to bring the mod more inline with what we had with mine.

Posted: Sun Feb 05, 2006 10:13 am
by RobertGonzalez
Do you think there would be any benefit to using GeSHi? I believe this application stemmed from the original code highlighting feature found in phpBB. GeSHi also supports multiple language formats (HTML, CSS, Javascript) which are also included in a lot of questions and answers around here.

Just thought I throw it out there.

Posted: Sun Feb 05, 2006 10:18 am
by feyd
geshi implementation is being debated (somewhat) amongst the moderators at the moment. It was part of an overall solution I suggested, along with making preparing for new languages a bit easier.

Posted: Sun Feb 05, 2006 1:54 pm
by Roja
feyd wrote:I do believe the default should stay this way, or maybe bold, or even background color (say yellow?) the links to really make them pop.
A background of yellow would make me want to vomit. :)

Thankfully, the poll so far leans towards leaving it as-is.

Posted: Sun Feb 05, 2006 3:34 pm
by Jenk
With a whopping 4 votes.. hardly conclusive that the entire forum wants them.

I've voted for toggle, but would have voted for "leave as links and blue but with no text decoration".

Posted: Sun Feb 05, 2006 3:50 pm
by Roja
Jenk wrote:With a whopping 4 votes.. hardly conclusive that the entire forum wants them.

I've voted for toggle, but would have voted for "leave as links and blue but with no text decoration".
Agreed, just commenting on early results.

Having toggle in the choices may just confuse the situation.. I've got no issues with having a toggle available. The question was what to do by default.

Posted: Sun Feb 05, 2006 3:54 pm
by shiznatix
a toggle with a default as is would be best. dont throw that toggle thing in a users face right off the bat as to not confuse them.

Posted: Sun Feb 05, 2006 3:58 pm
by Chris Corbyn
Jenk wrote:With a whopping 4 votes.. hardly conclusive that the entire forum wants them.

I've voted for toggle, but would have voted for "leave as links and blue but with no text decoration".
There was a "Something else" option ;)

Have you actually thought about the practical implementation of having hyperlinks that look the same as the rest of the text? It's a well known usability no-no... 8O

Here you go... what you're saying is just as silly as trying to find the link in this text:


There's three hyperlinks in there... good luck :P

http://w3style.co.uk/phpdn/usability-no-no.html

EDIT | Now compare it to: http://w3style.co.uk/phpdn/usability-better.html

Posted: Sun Feb 05, 2006 4:24 pm
by josh
They should stand out in some way, when they first went live they were just bold I think, that looked just fine to me. Aesthetically pleasing, fits the colors for function names most editors and the official documentation uses, and still functional. I also think bold stands out as a link then a non-standard purple-like color.