The green arrow after links

We know you have an opinion on how things should be run around here. These are suggestions for the forums, and the website.This forum is not a place to ask for suggestions to your own coding (or otherwise) problems.

Moderator: General Moderators

User avatar
jayshields
DevNet Resident
Posts: 1912
Joined: Mon Aug 22, 2005 12:11 pm
Location: Leeds/Manchester, England

The green arrow after links

Post by jayshields »

Why? It's acceptable until it comes into the syntax/PHP blocks, then it's obtrusive; saying that, auto-links in the syntax/PHP blocks are obtrusive anyway.

I think the green arrow should be removed altogether and auto-links should be removed from the code blocks.
User avatar
JayBird
Admin
Posts: 4524
Joined: Wed Aug 13, 2003 7:02 am
Location: York, UK
Contact:

Post by JayBird »

I get no arrow after links in PHP or Syntax tags.

Which theme you using? Im guessing Sherbert?

As for the autolink...i like them

Code: Select all

test link: http://www.google.com
Edit..hmm it does it there

Code: Select all

//test link: http://www.google.com
Edit 2...the arrows weren't there a minute ago

Edit 3...ah, i see, they dont appear when your posting a new message, then click preview
Last edited by JayBird on Fri Oct 20, 2006 8:18 am, edited 1 time in total.
User avatar
Chris Corbyn
Breakbeat Nuttzer
Posts: 13098
Joined: Wed Mar 24, 2004 7:57 am
Location: Melbourne, Australia

Post by Chris Corbyn »

It's a good point. I don't think they should be in code blocks. It was very nice of somebody to put the time and effort in to add the feature though so lets not be too harsh :)
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Post by RobertGonzalez »

Theoretically (spelling anyone?) smilies shouldn't be in code blocks either, but they are there. I don't think it is really an issue to be honest.

Code: Select all

<?php
// Visit http://somesite.com 
?>
User avatar
Maugrim_The_Reaper
DevNet Master
Posts: 2704
Joined: Tue Nov 02, 2004 5:43 am
Location: Ireland

Post by Maugrim_The_Reaper »

It is if someone is copying your code...;)

Isn't there some way of preventing it appearing with CSS selectors? The syntax blocks likely have unique CSS classes...
User avatar
Maugrim_The_Reaper
DevNet Master
Posts: 2704
Joined: Tue Nov 02, 2004 5:43 am
Location: Ireland

Post by Maugrim_The_Reaper »

Code: Select all

.syntax-code a.postlink {
   padding-right: 0px;
   background: none;
}
Anyone care to test? Seems to work if added to a user defined CSS file with Firefox (Webdeveloper extension).
User avatar
jayshields
DevNet Resident
Posts: 1912
Joined: Mon Aug 22, 2005 12:11 pm
Location: Leeds/Manchester, England

Post by jayshields »

d11wtq wrote:It's a good point. I don't think they should be in code blocks. It was very nice of somebody to put the time and effort in to add the feature though so lets not be too harsh :)
Sorry, didn't mean to come across harsh :)

And yeah, the smilies are a point I forgot to mention.
User avatar
feyd
Neighborhood Spidermoddy
Posts: 31559
Joined: Mon Mar 29, 2004 3:24 pm
Location: Bothell, Washington, USA

Post by feyd »

I don't particularly see what the problem is with the link arrows inside the code posts is, but the smilies have been annoying since we "upgraded" the syntax highlighter. I'm not sure how simple it will be to get inside there and fix those. However Geshi allows the linkages to happen in the code, which is the real culprit. I'm not willing to stick in a band-aid.
User avatar
Chris Corbyn
Breakbeat Nuttzer
Posts: 13098
Joined: Wed Mar 24, 2004 7:57 am
Location: Melbourne, Australia

Post by Chris Corbyn »

feyd wrote:However Geshi allows the linkages to happen in the code, which is the real culprit. I'm not willing to stick in a band-aid.
FYI that can be turned off via the phpBB admin panel and also in the mode itself. The smilies are a pain. I remember looking at that issue when I was an admin and giving up feeling a bit sore.
User avatar
feyd
Neighborhood Spidermoddy
Posts: 31559
Joined: Mon Mar 29, 2004 3:24 pm
Location: Bothell, Washington, USA

Post by feyd »

d11wtq wrote:FYI that can be turned off via the phpBB admin panel and also in the mode itself. The smilies are a pain. I remember looking at that issue when I was an admin and giving up feeling a bit sore.
I don't see controls for URL's being processed. They are processed after Geshi does the highlighting.
User avatar
Chris Corbyn
Breakbeat Nuttzer
Posts: 13098
Joined: Wed Mar 24, 2004 7:57 am
Location: Melbourne, Australia

Post by Chris Corbyn »

feyd wrote:
d11wtq wrote:FYI that can be turned off via the phpBB admin panel and also in the mode itself. The smilies are a pain. I remember looking at that issue when I was an admin and giving up feeling a bit sore.
I don't see controls for URL's being processed. They are processed after Geshi does the highlighting.
I could be wrong but my understanding is that Geshi makes the links. I use Geshi on my own sites and it puts links in them too.

The documentation shows how to turn them on and off (I'll search for it in a min).

Oh Doh!!!! I'm an idiot. I thought we were talking about the function linking :oops:
User avatar
AKA Panama Jack
Forum Regular
Posts: 878
Joined: Mon Nov 14, 2005 4:21 pm

Post by AKA Panama Jack »

Feyd added the annoying little link arrows. I guess he is trying to make phpBB2 look more like a Wiki.

Code: Select all

/* feyd 2006-10-19 */
a.postlink { background: url(templates/subSilver/images/external.png) right no-repeat; padding-right: 12px; }

If you are running Opera 9 as your browser you can EASILY get rid of the annoying little arrows.

1. Click on the Tools menu

2. Select Advanced

3. Select Blocked Content

4. Click the ADD button and enter the following if you are using the Sherbert template

templates/sherbet/images/external.png

or enter the following if you are using the subSilver template

templates/subSilver/images/external.png

5. Click Close and you are finished.

The little arrows will nolonger show up at the side of any link.

I could have made a user_js (user javascript) file just for the Dev Network forums that would replace the a.postlink style with something else but I took the easy way out. :)
Last edited by AKA Panama Jack on Fri Oct 20, 2006 4:03 pm, edited 1 time in total.
User avatar
feyd
Neighborhood Spidermoddy
Posts: 31559
Joined: Mon Mar 29, 2004 3:24 pm
Location: Bothell, Washington, USA

Post by feyd »

AKA Panama Jack wrote:Feyd added the annoying little link arrows. I guess he is trying to make phpBB2 look more like a Wiki.
It has nothing to do with wanting to look more like a Wiki. :roll: I've already stated why we've added it.
User avatar
hawleyjr
BeerMod
Posts: 2170
Joined: Tue Jan 13, 2004 4:58 pm
Location: Jax FL & Spokane WA USA

Post by hawleyjr »

AKA Panama Jack wrote:Feyd added the annoying little link arrows. I guess he is trying to make phpBB2 look more like a Wiki.
Actually the mod team voted on it. I really like it. Good work Feyd.
User avatar
Maugrim_The_Reaper
DevNet Master
Posts: 2704
Joined: Tue Nov 02, 2004 5:43 am
Location: Ireland

Post by Maugrim_The_Reaper »

I read back a bit and realised this is not impacting the function links? Am I right in saying that? If that's the case it doesn't impact the code syntax or layout other than actual http: links written into source code which are being parsed by phpBB presumably.

Please tell me I have it right this time ;).

I do like the new addition by the way. It clearly marks links and it looks well. I was worried it was appending the image to every function in the PHP syntax but if that's not the case...
Post Reply