Page 2 of 3

Posted: Fri Jan 05, 2007 10:24 am
by Luke
Weirdan wrote:Stylish
This is awesome.

Posted: Fri Jan 05, 2007 10:25 am
by Chris Corbyn
I voted for the change the day this thread appeared :) I don't like italics (or underscores for that matter) in mono-spaced code.

Posted: Fri Jan 05, 2007 10:26 am
by feyd
d11wtq wrote:I voted for the change the day this thread appeared :) I don't like italics (or underscores for that matter) in mono-spaced code.
Same here. Bold is okay provided it doesn't affect the dimensional requirements for the font thereby screwing up alignment, but other then that, colors only for myself personally. :)

Posted: Fri Jan 05, 2007 10:33 am
by RobertGonzalez
I could certainly do without the underlines or italics, and voted as such.

Posted: Wed Jan 10, 2007 11:01 am
by feyd
okay, so there appears to be few nay votes.

Now, the color has also been brought up as something to possible change. So here's what we can do:
  1. I remove the italics without altering the color immediately
  2. We discuss colors for a while and then change the highlighting afterward
Please choose.

Posted: Wed Jan 10, 2007 11:32 am
by Maugrim_The_Reaper
I say change italics, let colour changes wait a short while. I don't really mind the lighter colouring, mainly because it lets the code stand out more - darker comments might actually reduce that level of readability.

Posted: Wed Jan 10, 2007 11:48 am
by feyd
Maugrim_The_Reaper wrote:I don't really mind the lighter colouring, mainly because it lets the code stand out more - darker comments might actually reduce that level of readability.
In my personal settings I often use a light gray (or green) for comments so they blend into the white background a bit.
possible example wrote:/**
* Open a stream
* \param[in] aDescriptor Supply a description that will allow the
* stream to be opened. What that specifically
* is will depend on the particular
* implementation.
* \note Default value is an empty string.
* \returns void
*/

public function Open($aDescriptor = '');
edit: I should note I'm not advocating changing all the colors, I just added more for some contrast.

Posted: Wed Jan 10, 2007 12:02 pm
by RobertGonzalez
I don't mind the orange for comments. Right now I use orange for single line comments and light gray for multi-line comments (in Eclipse). In notepad++ I use orange and green. just about any light colored, non obtrusive color that is not part of the 'action' colors is OK with me. But getting rid of the italics is a good way to go and would advocate that immediately.

Posted: Wed Jan 10, 2007 12:26 pm
by daedalus__
I prefer orange because it stands out. Sometimes I'll be scrolling through a couple thousand of lines of code and be thanking jesus when I see that heavenly orange text.
stylish wrote:User styles empower your browsing experience by letting you fix ugly sites
rofl!

Posted: Wed Jan 10, 2007 1:00 pm
by Kieran Huggins
Thought it would be useful to have a visual comparison:

Current style:

Code: Select all

// php-defined functions are red
$row = MySQL_fetch_assoc($result);

$quoted_text = 'hot pink, baby!';

// user functions are whatever this color is:
function userFunction($arg1=NULL,$arg2='bob'){
	$someVar = $arg1?$arg1:$arg2;
	if($something){
		// do something
	}else(
		// don't	
		
		// control structures are blue
		return(false);
	)
	foreach($something as $key => $val){
		/*	
			iterate 
			the 
			array 
		*/
	}
	echo '<a href="#">all done here, '.$username.'</a>';
	exit;
}
New style?
// php-defined functions are red
$row = MySQL_fetch_assoc($result);

$quoted_text = 'hot pink, baby!';

// user functions are whatever this color is:
function userFunction($arg1=NULL,$arg2='bob'){
$someVar = $arg1?$arg1:$arg2;
if($something){
// do something
}else(
// don't

// control structures are blue
return(false);
)
foreach($something as $key => $val){
/*
iterate
the
array
*/

}
echo '<a href="#">all done here, '.$username.'</a>';
exit;
}
I wish I could simulate proper indenting (which I'd personally like to see reduced a little) Let me know what you guys think?

Posted: Wed Jan 10, 2007 1:02 pm
by Ollie Saunders
Hmm yes judging by the responses and being personally unsure of even my own opinion where colour is concerned I'd say leave it as is.

Posted: Wed Jan 10, 2007 1:27 pm
by feyd
Kieran Huggins wrote:New style?
// php-defined functions are red
$row = MySQL_fetch_assoc($result);

$quoted_text = 'hot pink, baby!';

// user functions are whatever this color is:
function userFunction($arg1=NULL,$arg2='bob'){
$someVar = $arg1?$arg1:$arg2;
if($something){
// do something
}else(
// don't

// control structures are blue
return(false);
)
foreach($something as $key => $val){
/*
iterate
the
array
*/

}
echo '<a href="#">all done here, '.$username.'</a>';
exit;
}
I wish I could simulate proper indenting (which I'd personally like to see reduced a little) Let me know what you guys think?
I'm not sure I'm a fan of ... pastel. :)

Posted: Wed Jan 10, 2007 2:02 pm
by volka
I find the $ having the same color as keywords but the variable name another a bit distracting ...and second
feyd wrote:I'm not sure I'm a fan of ... pastel.

Posted: Wed Jan 10, 2007 2:07 pm
by feyd
I don't think it's even possible for us to segregate the $ form the variable name (especially to it's own color) within the highlighter.

Posted: Wed Jan 10, 2007 2:18 pm
by Kieran Huggins
It's not necessary for the $ to be a different color.

Also, I'd be more than happy to hack away at a the code highlighter on your behalf.