Code expand not working

We know you have an opinion on how things should be run around here. These are suggestions for the forums, and the website.This forum is not a place to ask for suggestions to your own coding (or otherwise) problems.

Moderator: General Moderators

Post Reply
matthijs
DevNet Master
Posts: 3360
Joined: Thu Oct 06, 2005 3:57 pm

Code expand not working

Post by matthijs »

I haven't been able to use code expand toggle for a few months now. Anyone else have the same problem?

Using subsilver theme, FF/mac, Safari/mac
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: Code expand not working

Post by RobertGonzalez »

JS is turned on?
matthijs
DevNet Master
Posts: 3360
Joined: Thu Oct 06, 2005 3:57 pm

Re: Code expand not working

Post by matthijs »

Yes
User avatar
Zoxive
Forum Regular
Posts: 974
Joined: Fri Apr 01, 2005 4:37 pm
Location: Bay City, Michigan

Re: Code expand not working

Post by Zoxive »

It's not working for me as well. Tested on Ubuntu 8.04 with Firefox 3 Beta 5, and Windows Xp Firefox 2.0.0.14
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: Code expand not working

Post by RobertGonzalez »

Are the line numbers / select all working? Which themes are you all using?
User avatar
Zoxive
Forum Regular
Posts: 974
Joined: Fri Apr 01, 2005 4:37 pm
Location: Bay City, Michigan

Re: Code expand not working

Post by Zoxive »

Everah wrote:Are the line numbers / select all working? Which themes are you all using?
Line numbers works, I'm using subsilver2.

Where's the select all?
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: Code expand not working

Post by RobertGonzalez »

Select all may only be in Prosilver.

Can you try switching your theme and see if the Expand works for you in Prosilver?
User avatar
Zoxive
Forum Regular
Posts: 974
Joined: Fri Apr 01, 2005 4:37 pm
Location: Bay City, Michigan

Re: Code expand not working

Post by Zoxive »

Everah wrote:Select all may only be in Prosilver.

Can you try switching your theme and see if the Expand works for you in Prosilver?
Select all works, and All Expand does is hide/show the code. It does not expand it to show it all, it just stays at the same height (around 330px) and toggles visibility it looks like.

Before Expand would make the div full height, so there was no scroll bar.

PS. Prosilver is ugly
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: Code expand not working

Post by RobertGonzalez »

I think (if I remember correctly) that we chose to not offer fully expanded code boxed. I can't remember why we chose that, but I believe it was a decision early in the mod addition process.
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: Code expand not working

Post by RobertGonzalez »

Are any of you using FF3?
User avatar
Zoxive
Forum Regular
Posts: 974
Joined: Fri Apr 01, 2005 4:37 pm
Location: Bay City, Michigan

Re: Code expand not working

Post by Zoxive »

Everah wrote:Are any of you using FF3?
Yes, i said what I use in my post above.
Zoxive wrote:It's not working for me as well. Tested on Ubuntu 8.04 with Firefox 3 Beta 5, and Windows Xp Firefox 2.0.0.14
But now from your last post, what is the expected behaviour of the Expand button?
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: Code expand not working

Post by RobertGonzalez »

Sorry Zoxive, I managed to totally look right past your settings/software.

I think I might have an idea. The markup is totally different for the two themes. Prosilver, where it works, does not have any inline styles applied to the code box. subSilver does. This might be affecting the overall effects of the JS.

I will see if I can mess around with this sometime this weekend.
matthijs
DevNet Master
Posts: 3360
Joined: Thu Oct 06, 2005 3:57 pm

Re: Code expand not working

Post by matthijs »

I also checked the other theme (prosilver) quickly and there it is working. Although not as I expected (opening completely).

If there is collapsing, I'd like to see toggle to complete opened. Just opening to 300px and closing is not that interesting, in my opinion.

Thanks for the effort Everah
User avatar
RobertGonzalez
Site Administrator
Posts: 14293
Joined: Tue Sep 09, 2003 6:04 pm
Location: Fremont, CA, USA

Re: Code expand not working

Post by RobertGonzalez »

I will bring this up to the mod team.
Post Reply