Page 1 of 1

Code expand not working

Posted: Wed Apr 30, 2008 5:52 am
by matthijs
I haven't been able to use code expand toggle for a few months now. Anyone else have the same problem?

Using subsilver theme, FF/mac, Safari/mac

Re: Code expand not working

Posted: Thu May 01, 2008 11:46 pm
by RobertGonzalez
JS is turned on?

Re: Code expand not working

Posted: Fri May 02, 2008 12:25 am
by matthijs
Yes

Re: Code expand not working

Posted: Fri May 02, 2008 1:36 am
by Zoxive
It's not working for me as well. Tested on Ubuntu 8.04 with Firefox 3 Beta 5, and Windows Xp Firefox 2.0.0.14

Re: Code expand not working

Posted: Fri May 02, 2008 12:22 pm
by RobertGonzalez
Are the line numbers / select all working? Which themes are you all using?

Re: Code expand not working

Posted: Fri May 02, 2008 12:26 pm
by Zoxive
Everah wrote:Are the line numbers / select all working? Which themes are you all using?
Line numbers works, I'm using subsilver2.

Where's the select all?

Re: Code expand not working

Posted: Fri May 02, 2008 12:39 pm
by RobertGonzalez
Select all may only be in Prosilver.

Can you try switching your theme and see if the Expand works for you in Prosilver?

Re: Code expand not working

Posted: Fri May 02, 2008 12:53 pm
by Zoxive
Everah wrote:Select all may only be in Prosilver.

Can you try switching your theme and see if the Expand works for you in Prosilver?
Select all works, and All Expand does is hide/show the code. It does not expand it to show it all, it just stays at the same height (around 330px) and toggles visibility it looks like.

Before Expand would make the div full height, so there was no scroll bar.

PS. Prosilver is ugly

Re: Code expand not working

Posted: Fri May 02, 2008 12:57 pm
by RobertGonzalez
I think (if I remember correctly) that we chose to not offer fully expanded code boxed. I can't remember why we chose that, but I believe it was a decision early in the mod addition process.

Re: Code expand not working

Posted: Fri May 02, 2008 6:13 pm
by RobertGonzalez
Are any of you using FF3?

Re: Code expand not working

Posted: Fri May 02, 2008 7:42 pm
by Zoxive
Everah wrote:Are any of you using FF3?
Yes, i said what I use in my post above.
Zoxive wrote:It's not working for me as well. Tested on Ubuntu 8.04 with Firefox 3 Beta 5, and Windows Xp Firefox 2.0.0.14
But now from your last post, what is the expected behaviour of the Expand button?

Re: Code expand not working

Posted: Fri May 02, 2008 11:31 pm
by RobertGonzalez
Sorry Zoxive, I managed to totally look right past your settings/software.

I think I might have an idea. The markup is totally different for the two themes. Prosilver, where it works, does not have any inline styles applied to the code box. subSilver does. This might be affecting the overall effects of the JS.

I will see if I can mess around with this sometime this weekend.

Re: Code expand not working

Posted: Sat May 03, 2008 2:26 am
by matthijs
I also checked the other theme (prosilver) quickly and there it is working. Although not as I expected (opening completely).

If there is collapsing, I'd like to see toggle to complete opened. Just opening to 300px and closing is not that interesting, in my opinion.

Thanks for the effort Everah

Re: Code expand not working

Posted: Sat May 03, 2008 2:40 am
by RobertGonzalez
I will bring this up to the mod team.