Page 1 of 1

code evaluation

Posted: Sun Jun 01, 2003 2:14 pm
by redhair
I am programming php a few years now, just learned (...and still learning ;) ) it via books, tuttorials, samples and forums like this.

Now...my 'problem' is that i have nobody to turn to, when i want my (working) code evaluated/ commented by someone real good.

Some of the solutions i use to accomplish something, could be un-safe or be accomplished in other, maybe better ways. (although i try real hard to be 'real good' to)

I feel the need for a place where php programmers, who are as in-secure like me :roll: can have their codes evaluated.


So i'dd like to see a code-evaluation forum placed.
I think it would be very usefull/ educational for all programmers around.

Posted: Sun Jun 01, 2003 2:28 pm
by twigletmac
It's in the pipeline...

Mac

Posted: Sun Jun 01, 2003 7:06 pm
by nielsene
I think some form of co-operative code review would be useful, but I'm not sure if a forum is the right form for it. If a forum is used you need to have a lot of moderation/stickies I think.

You also need to plan out exactly what type of review is being done. Are you asking people to critque your design? your security? your UI? your coding style? etc...

What do you plan to provide when you submit code for review? In most cases, if I were to do a code review I would want a detailed problem statement, describing problem/service the program attempts to solve/provide. I'ld also want some design documentation to help get oriented in the code before I jump in. I'd also want to have a test-server where I can play with the application to some degree.

In some sense I think a news style format would woek better than a form. The news blurb would include a brief description of the project, include links to the code, design documents, and specifiec concerns to address in the review. The linked discussion thread can then refer to the code or quote small sections rather than having to scroll through huge chunks of code.

For instance I have a project I'ld love to get some feedback on, but its about 15KLoC at present and growing. Even posting just a list of files would be too much "noise" in a form structure. Asking people to "comment in general" isn't like to yield anything useful. I'ld have to say something like "I'm not happy with my solution for 'Foo' and section 'Bar' can people take a look and see if they see a better solution. While a given answer might need to refer to code in very different sections of the application, at least the review is focused....

Posted: Sun Jun 01, 2003 7:09 pm
by nielsene
twigletmac wrote:It's in the pipeline...

Mac
Hey if y'all want some extra help with it, I'm potentially interested/willing to do some work....

Posted: Sun Jun 01, 2003 8:34 pm
by phice
That's an amazing idea.

I've had several code sniplets that I thought could be done easier, faster, etc.

We could add on to this portal.php for this functionl; much like this forum, but a little different. Just a title, code input, and submit it. The reviewers will be able to review it, rate it (1-10), and even recode it (if needed).

Posted: Mon Jun 02, 2003 8:00 am
by redhair
phice wrote:That's an amazing idea.
Well yeah! :) i can understand the difficulties Eric mentions.
It must be set up in a logical way.

some ideas:
For a code submission, there must be these fields:

*title/description/owner of the project,
*where the working version might be found
*how much files there are in the project
(..when for example there are multiple files, say 4, have 4 formfields pop-open where the php-code goes into. Maybe it might also be possible to have the codes uploaded straight to the forum.)

To 'echo' the project, i was thinking about an ordinary forum body, with links to the relevant code of the project. And...with all the goodies phice mentioned. I was also thinking about the way the php is showen. Ofcourse it would be syntax highlighted, but i was also thinking to have a line nr. in front of each new line that is clickable, once clicked, a commenter is taken to a field where they can comment on that specific line in the project.

...i'll keep on brainstorming on this.

Posted: Mon Jun 02, 2003 8:28 am
by []InTeR[]
Okay, when is it ready? :)

Posted: Wed Jun 25, 2003 8:25 am
by nielsene
twigletmac wrote:It's in the pipeline...

Mac
Ping...

Does "in the pipeline" mean its under active construction? under conceptual design? something we have on our TODO list? How can I help make it happen?

I don't want to just start working on my own version if you already have work begun, but....

Posted: Wed Jun 25, 2003 8:30 am
by twigletmac
I've got a fairly good idea of what I want to do but haven't actually gotten to the 'really doing anything proper with it' part.

Mac